fix(wasm): Remove the CMAKE_STAGING_PREFIX variable from wasm preset#240
Merged
Conversation
dbanks12
approved these changes
Mar 14, 2023
ludamad
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 22, 2023
ludamad
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This removes the
CMAKE_STAGING_PREFIXvariable from the wasm prefix. This was a holdover from the wasi-sdk toolchain file. I originally left it in because I didn't know what it did; however, I've discovered that this value is used as the install prefix if it is set (see https://discourse.cmake.org/t/cmake-staging-prefix-vs-cmake-install-prefix/6485) and that makes the wasm file install into the wasi-sdk sysroot, which is wrong for our project.Removing this allows the wasm file to install into the same prefix as the rest of the project.
Checklist:
/markdown/specshave been updated.@briefdescribing the intended functionality.