Skip to content

Detection and Workbook for customers using Eaton Foreseer application#4557

Merged
NikTripathi merged 14 commits into
Azure:masterfrom
kushaljh:cdc2/kushalj/eaton
May 6, 2022
Merged

Detection and Workbook for customers using Eaton Foreseer application#4557
NikTripathi merged 14 commits into
Azure:masterfrom
kushaljh:cdc2/kushalj/eaton

Conversation

@kushaljh
Copy link
Copy Markdown
Contributor

@kushaljh kushaljh commented Apr 1, 2022

Required items, please complete

Change(s):

  • Created a new Sentinel Solution - EatonForeseer

Reason for Change(s):

  • Adding health and security visibility for customers using Eaton Foreseer

Version Updated:

  • Yes. New Detection.

Testing Completed:

  • Yes

Checked that the validations are passing and have addressed any issues that are present:

  • Yes

@kushaljh kushaljh marked this pull request as draft April 1, 2022 22:44
@v-sabiraj v-sabiraj added Solution Solution specialty review needed Detection Detection specialty review needed Workbook Workbook specialty review needed labels Apr 4, 2022
@v-sabiraj
Copy link
Copy Markdown
Contributor

Hey @kushaljh, can you please confirm is this pull request still in progress? Because it is still in draft?

@kushaljh kushaljh marked this pull request as ready for review April 11, 2022 06:26
@kushaljh
Copy link
Copy Markdown
Contributor Author

Hey @kushaljh, can you please confirm is this pull request still in progress? Because it is still in draft?

@v-sabiraj Thank you for checking in. This PR is ready for review.

@v-sabiraj
Copy link
Copy Markdown
Contributor

Hey @aprakash13, can you please review Analytic Rules, thanks.

Copy link
Copy Markdown
Contributor

@aprakash13 aprakash13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made few small suggestions. Please have a look. Thanks.

Comment thread Solutions/EatonForeseer/Analytic Rules/EatonUnautorizedLogins.yaml Outdated
Comment thread Solutions/EatonForeseer/Analytic Rules/EatonUnautorizedLogins.yaml
Comment thread Solutions/EatonForeseer/Analytic Rules/EatonUnautorizedLogins.yaml Outdated
Comment thread Solutions/EatonForeseer/Analytic Rules/EatonUnautorizedLogins.yaml Outdated
@kushaljh kushaljh requested a review from aprakash13 April 14, 2022 17:12
@v-sabiraj
Copy link
Copy Markdown
Contributor

Hey @kushaljh, Workbook looks good, will you just rename the preview images with black and white rather than dark and light, e.g. EatonForeseerHealthAndAccessBlack.png for black (dark) image and EatonForeseerHealthAndAccessWhite.png for white (light) image, thanks.

@v-sabiraj
Copy link
Copy Markdown
Contributor

Hey @aprakash13, will you please review and approve the changes done, thanks.

@kushaljh
Copy link
Copy Markdown
Contributor Author

Hey @kushaljh, Workbook looks good, will you just rename the preview images with black and white rather than dark and light, e.g. EatonForeseerHealthAndAccessBlack.png for black (dark) image and EatonForeseerHealthAndAccessWhite.png for white (light) image, thanks.

Thank you for reviewing the workbook @v-sabiraj
I have updated the names as requested

Copy link
Copy Markdown
Contributor

@aprakash13 aprakash13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a query perspective. Thanks @kushaljh

@kushaljh
Copy link
Copy Markdown
Contributor Author

kushaljh commented May 5, 2022

@v-sabiraj
Can we get an approving reviewer to review this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Detection Detection specialty review needed Solution Solution specialty review needed Workbook Workbook specialty review needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants