diff --git a/eng/scripts/run_pylint.py b/eng/scripts/run_pylint.py index df2b6226bfb..002451950f1 100644 --- a/eng/scripts/run_pylint.py +++ b/eng/scripts/run_pylint.py @@ -30,7 +30,7 @@ def _single_dir_pylint(mod): "-m", "pylint", "--rcfile={}".format(rfc_file_location), - "--load-plugins=pylint_guidelines_checker" + "--load-plugins=pylint_guidelines_checker", "--output-format=parseable", str(inner_class.absolute()), ] @@ -77,10 +77,11 @@ def _single_dir_pylint(mod): if len(dirs) > 1: with Pool() as pool: result = pool.map(_single_dir_pylint, dirs) - if not all(result): - logging.error( - "Linting fails" - ) - exit(1) + response = all(result) else: - _single_dir_pylint(dirs[0]) + response = _single_dir_pylint(dirs[0]) + if not response: + logging.error( + "Linting fails" + ) + exit(1) diff --git a/pylintrc b/pylintrc index 6f21bc12704..3f0ceebffa4 100644 --- a/pylintrc +++ b/pylintrc @@ -11,7 +11,7 @@ ignore=_generated,samples,examples,test,tests,doc,.tox # cyclic-import: because of https://github.com/PyCQA/pylint/issues/850 # too-many-arguments: Due to the nature of the CLI many commands have large arguments set which reflect in large arguments set in corresponding methods. # Let's black deal with bad-continuation -disable=useless-object-inheritance,missing-docstring,locally-disabled,fixme,cyclic-import,too-many-arguments,invalid-name,duplicate-code,too-few-public-methods,bad-continuation,check-docstrings,consider-using-f-string,super-with-arguments,redefined-builtin,import-outside-toplevel +disable=useless-object-inheritance,missing-docstring,locally-disabled,fixme,cyclic-import,too-many-arguments,invalid-name,duplicate-code,too-few-public-methods,bad-continuation,check-docstrings,consider-using-f-string,super-with-arguments,redefined-builtin,import-outside-toplevel,missing-client-constructor-parameter-credential [FORMAT] max-line-length=120