From d20634739c55f430dee8b297b67f68ae7fbe5d7d Mon Sep 17 00:00:00 2001 From: "Saurabh Singh (SQL)" Date: Thu, 2 Jul 2020 02:15:07 -0700 Subject: [PATCH 1/3] Fix incorrect comments. Looks like the comments were copied over from KeyOperation and the type name was fixed but the values weren't --- .../keys/cryptography/models/KeyWrapAlgorithm.java | 10 +++++----- .../azure/security/keyvault/keys/models/KeyType.java | 8 ++++---- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/sdk/keyvault/azure-security-keyvault-keys/src/main/java/com/azure/security/keyvault/keys/cryptography/models/KeyWrapAlgorithm.java b/sdk/keyvault/azure-security-keyvault-keys/src/main/java/com/azure/security/keyvault/keys/cryptography/models/KeyWrapAlgorithm.java index 940b04bd9593..5c387443778a 100644 --- a/sdk/keyvault/azure-security-keyvault-keys/src/main/java/com/azure/security/keyvault/keys/cryptography/models/KeyWrapAlgorithm.java +++ b/sdk/keyvault/azure-security-keyvault-keys/src/main/java/com/azure/security/keyvault/keys/cryptography/models/KeyWrapAlgorithm.java @@ -15,27 +15,27 @@ public final class KeyWrapAlgorithm extends ExpandableStringEnum { /** - * Static value Encrypt for KeyWrapAlgorithm. + * Static value RSA-OAEP for KeyWrapAlgorithm. */ public static final KeyWrapAlgorithm RSA_OAEP = fromString("RSA-OAEP"); /** - * Static value Decrypt for KeyWrapAlgorithm. + * Static value RSA-OAEP-256 for KeyWrapAlgorithm. */ public static final KeyWrapAlgorithm RSA_OAEP_256 = fromString("RSA-OAEP-256"); /** - * Static value Sign for KeyWrapAlgorithm. + * Static value RSA1_5 for KeyWrapAlgorithm. */ public static final KeyWrapAlgorithm RSA1_5 = fromString("RSA1_5"); /** - * Static value Verify for KeyWrapAlgorithm. + * Static value A192KW for KeyWrapAlgorithm. */ public static final KeyWrapAlgorithm A192KW = fromString("A192KW"); /** - * Static value Wrap Key for KeyWrapAlgorithm. + * Static value A128KW for KeyWrapAlgorithm. */ public static final KeyWrapAlgorithm A128KW = fromString("A128KW"); diff --git a/sdk/keyvault/azure-security-keyvault-keys/src/main/java/com/azure/security/keyvault/keys/models/KeyType.java b/sdk/keyvault/azure-security-keyvault-keys/src/main/java/com/azure/security/keyvault/keys/models/KeyType.java index 98b8c7864422..9173be9481b5 100644 --- a/sdk/keyvault/azure-security-keyvault-keys/src/main/java/com/azure/security/keyvault/keys/models/KeyType.java +++ b/sdk/keyvault/azure-security-keyvault-keys/src/main/java/com/azure/security/keyvault/keys/models/KeyType.java @@ -20,22 +20,22 @@ public final class KeyType extends ExpandableStringEnum { public static final KeyType EC = fromString("EC"); /** - * Static value Decrypt for KeyType. + * Static value EC-HSM for KeyType. */ public static final KeyType EC_HSM = fromString("EC-HSM"); /** - * Static value Sign for KeyType. + * Static value RSA for KeyType. */ public static final KeyType RSA = fromString("RSA"); /** - * Static value Verify for KeyType. + * Static value RSA-HSM for KeyType. */ public static final KeyType RSA_HSM = fromString("RSA-HSM"); /** - * Static value Wrap Key for KeyType. + * Static value oct for KeyType. */ public static final KeyType OCT = fromString("oct"); From 1d2213efb7f0ca373d8f28f8e728a55a51ad40c8 Mon Sep 17 00:00:00 2001 From: "Saurabh Singh (SQL)" Date: Thu, 2 Jul 2020 02:19:53 -0700 Subject: [PATCH 2/3] Fix more comments --- .../models/SignatureAlgorithm.java | 20 +++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/sdk/keyvault/azure-security-keyvault-keys/src/main/java/com/azure/security/keyvault/keys/cryptography/models/SignatureAlgorithm.java b/sdk/keyvault/azure-security-keyvault-keys/src/main/java/com/azure/security/keyvault/keys/cryptography/models/SignatureAlgorithm.java index 07801352dcb0..1994403a287e 100644 --- a/sdk/keyvault/azure-security-keyvault-keys/src/main/java/com/azure/security/keyvault/keys/cryptography/models/SignatureAlgorithm.java +++ b/sdk/keyvault/azure-security-keyvault-keys/src/main/java/com/azure/security/keyvault/keys/cryptography/models/SignatureAlgorithm.java @@ -15,52 +15,52 @@ public final class SignatureAlgorithm extends ExpandableStringEnum { /** - * Static value RSA_OAEP for SignatureAlgorithm. + * Static value PS256 for SignatureAlgorithm. */ public static final SignatureAlgorithm PS256 = fromString("PS256"); /** - * Static value RSA_OAEP_256 for SignatureAlgorithm. + * Static value PS384 for SignatureAlgorithm. */ public static final SignatureAlgorithm PS384 = fromString("PS384"); /** - * Static value RSA1_5 for SignatureAlgorithm. + * Static value PS512 for SignatureAlgorithm. */ public static final SignatureAlgorithm PS512 = fromString("PS512"); /** - * Static value A256CBC_HS512 for SignatureAlgorithm. + * Static value RS256 for SignatureAlgorithm. */ public static final SignatureAlgorithm RS256 = fromString("RS256"); /** - * Static value A128CBC_HS256 for SignatureAlgorithm. + * Static value RS384 for SignatureAlgorithm. */ public static final SignatureAlgorithm RS384 = fromString("RS384"); /** - * Static value A192CBC_HS384 for SignatureAlgorithm. + * Static value RS512 for SignatureAlgorithm. */ public static final SignatureAlgorithm RS512 = fromString("RS512"); /** - * Static value A256CBC for SignatureAlgorithm. + * Static value ES256 for SignatureAlgorithm. */ public static final SignatureAlgorithm ES256 = fromString("ES256"); /** - * Static value A192CBC for SignatureAlgorithm. + * Static value ES384 for SignatureAlgorithm. */ public static final SignatureAlgorithm ES384 = fromString("ES384"); /** - * Static value A128CBC for SignatureAlgorithm. + * Static value ES512 for SignatureAlgorithm. */ public static final SignatureAlgorithm ES512 = fromString("ES512"); /** - * Static value A128CBC for SignatureAlgorithm. + * Static value ES256K for SignatureAlgorithm. */ public static final SignatureAlgorithm ES256K = fromString("ES256K"); From 5c4aeebc8b66f7209686ee7283aec035cbc04d2b Mon Sep 17 00:00:00 2001 From: "Saurabh Singh (SQL)" Date: Thu, 2 Jul 2020 15:01:03 -0700 Subject: [PATCH 3/3] Address feedback --- .../java/com/azure/security/keyvault/keys/models/KeyType.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/keyvault/azure-security-keyvault-keys/src/main/java/com/azure/security/keyvault/keys/models/KeyType.java b/sdk/keyvault/azure-security-keyvault-keys/src/main/java/com/azure/security/keyvault/keys/models/KeyType.java index 9173be9481b5..5f8ee90add43 100644 --- a/sdk/keyvault/azure-security-keyvault-keys/src/main/java/com/azure/security/keyvault/keys/models/KeyType.java +++ b/sdk/keyvault/azure-security-keyvault-keys/src/main/java/com/azure/security/keyvault/keys/models/KeyType.java @@ -15,7 +15,7 @@ public final class KeyType extends ExpandableStringEnum { /** - * Static value Encrypt for KeyType. + * Static value EC for KeyType. */ public static final KeyType EC = fromString("EC");