From eecbd868ded215daefcbfe0e37edb54af0938b6f Mon Sep 17 00:00:00 2001
From: Rick Ley <frley@microsoft.com>
Date: Mon, 13 Jul 2020 15:05:36 -0700
Subject: [PATCH 1/5] Updated lots of docs

---
 sdk/storage/azure-storage-blob-nio/README.md  |   6 +-
 .../blob/nio/AzureBasicFileAttributeView.java |  19 +-
 .../blob/nio/AzureBasicFileAttributes.java    |  42 +++-
 .../blob/nio/AzureBlobFileAttributeView.java  |  14 +-
 .../blob/nio/AzureBlobFileAttributes.java     | 109 ++++++---
 .../blob/nio/AzureDirectoryStream.java        |   2 +-
 .../storage/blob/nio/AzureFileStore.java      |  54 +++--
 .../storage/blob/nio/AzureFileSystem.java     |  98 ++++++--
 .../blob/nio/AzureFileSystemProvider.java     | 222 ++++++++++++++----
 .../storage/blob/nio/LoggingUtility.java      |   2 +-
 .../storage/blob/nio/NioBlobInputStream.java  |   2 +-
 .../storage/blob/nio/NioBlobOutputStream.java |   2 +-
 .../azure/storage/blob/nio/ReadmeSamples.java |   3 +-
 .../storage/blob/nio/AttributeViewTest.groovy |   2 -
 14 files changed, 418 insertions(+), 159 deletions(-)

diff --git a/sdk/storage/azure-storage-blob-nio/README.md b/sdk/storage/azure-storage-blob-nio/README.md
index bf9c0f7fb96e..7b5513b7d935 100644
--- a/sdk/storage/azure-storage-blob-nio/README.md
+++ b/sdk/storage/azure-storage-blob-nio/README.md
@@ -116,7 +116,7 @@ fallback and retry options available.
 The view of the FileSystem from within an instance of the JVM will be consistent, but the AzureFileSystem makes no 
 guarantees on behavior or state should other processes operate on the same data. The AzureFileSystem will assume that it 
 has exclusive access to the resources stored in Azure Blob Storage and will behave without regard for potential 
-interfering applications
+interfering applications.
 
 Finally, this implementation has currently chosen to always read/write directly to/from Azure Storage without a local 
 cache. Our team has determined that with the tradeoffs of complexity, correctness, safety, performance, debuggability, 
@@ -149,8 +149,9 @@ Please see the docs for `AzureFileSystemProvider` for a full explanation of init
 <!-- embedme ./src/samples/java/com/azure/storage/blob/nio/ReadmeSamples.java#L39-L42 -->
 ```java
 Map<String, Object> config = new HashMap<>();
+String[] stores = {"<your_container_name", "another_container_name"}; // Any iterable is acceptable
 config.put(AzureFileSystem.AZURE_STORAGE_ACCOUNT_KEY, "<your_account_key>");
-config.put(AzureFileSystem.AZURE_STORAGE_FILE_STORES, "<container_names>");
+config.put(AzureFileSystem.AZURE_STORAGE_FILE_STORES, stores);
 FileSystem myFs = FileSystems.newFileSystem(new URI("azb://?account=<your_account_name"), config);
 ```
 
@@ -282,6 +283,7 @@ not be possible or otherwise may conflict with established design goals and ther
 - Hidden files
 - Random writes
 - File locks
+- Read only files or file stores
 - Watches on directory events
 - Support for other Azure Storage services such as ADLS Gen 2 (Datalake) and Azure Files (shares)
 - Token authentication
diff --git a/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureBasicFileAttributeView.java b/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureBasicFileAttributeView.java
index 01ae0bd2e7a2..2b855cb4aedc 100644
--- a/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureBasicFileAttributeView.java
+++ b/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureBasicFileAttributeView.java
@@ -10,14 +10,12 @@
 
 /**
  * Provides support for basic file attributes.
- *
+ * <p>
  * The operations supported by this view and the attributes it reads are a strict subset of
  * {@link AzureBlobFileAttributeView} and has the same network behavior. Therefore, while this type is offered for
  * compliance with the NIO spec, {@link AzureBlobFileAttributeView} is generally preferred.
- *
+ * <p>
  * {@link #setTimes(FileTime, FileTime, FileTime)} is not supported.
- *
- * {@inheritDoc}
  */
 public final class AzureBasicFileAttributeView implements BasicFileAttributeView {
 
@@ -30,8 +28,9 @@ public final class AzureBasicFileAttributeView implements BasicFileAttributeView
     }
 
     /**
-     * Returns {@code "azureBasic"}
-     * {@inheritDoc}
+     * Returns the name of the attribute view: {@code "azureBasic"}
+     *
+     * @return the name of the attribute view: {@code "azureBasic"}
      */
     @Override
     public String name() {
@@ -39,7 +38,11 @@ public String name() {
     }
 
     /**
-     * {@inheritDoc}
+     * Reads the basic file attributes as a bulk operation.
+     * <p>
+     * All file attributes are read as an atomic operation with respect to other file system operations.
+     *
+     * @return {@link AzureBasicFileAttributes}
      */
     @Override
     public AzureBasicFileAttributes readAttributes() throws IOException {
@@ -50,7 +53,7 @@ public AzureBasicFileAttributes readAttributes() throws IOException {
      * Unsupported.
      *
      * @throws UnsupportedOperationException Operation not supported.
-     * {@inheritDoc}
+     * @throws IOException never
      */
     @Override
     public void setTimes(FileTime lastModifiedTime, FileTime lastAccessTime, FileTime createTime) throws IOException {
diff --git a/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureBasicFileAttributes.java b/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureBasicFileAttributes.java
index b6c2d555a090..c41e28471285 100644
--- a/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureBasicFileAttributes.java
+++ b/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureBasicFileAttributes.java
@@ -24,9 +24,8 @@
  * {@link AzureBlobFileAttributes} is generally preferred.
  * <p>
  * Some attributes are not supported. Refer to the javadocs on each method for more information.
- * {@inheritDoc}
  */
-public class AzureBasicFileAttributes implements BasicFileAttributes {
+public final class AzureBasicFileAttributes implements BasicFileAttributes {
     private final ClientLogger logger = new ClientLogger(AzureBasicFileAttributes.class);
 
     // For verifying parameters on FileSystemProvider.readAttributes
@@ -62,7 +61,9 @@ public class AzureBasicFileAttributes implements BasicFileAttributes {
     }
 
     /**
-     * {@inheritDoc}
+     * Returns the time of last modification.
+     *
+     * @return the time of last modification.
      */
     @Override
     public FileTime lastModifiedTime() {
@@ -70,17 +71,22 @@ public FileTime lastModifiedTime() {
     }
 
     /**
-     * Unsupported.
-     * @throws UnsupportedOperationException Operation not supported.
-     * {@inheritDoc}
+     * Returns the time of last modification.
+     * <p>
+     * Last access time is not supported by the blob service. In this case, it is typical for implementations to return
+     * the {@link #lastModifiedTime()}.
+     *
+     * @return the time of last modification.
      */
     @Override
     public FileTime lastAccessTime() {
-        throw new UnsupportedOperationException();
+        return this.lastModifiedTime();
     }
 
     /**
-     * {@inheritDoc}
+     * Returns the creation time. The creation time is the time that the file was created.
+     *
+     * @return The creation time.
      */
     @Override
     public FileTime creationTime() {
@@ -88,7 +94,9 @@ public FileTime creationTime() {
     }
 
     /**
-     * {@inheritDoc}
+     * Tells whether the file is a regular file with opaque content.
+     *
+     * @return whether the file is a regular file.
      */
     @Override
     public boolean isRegularFile() {
@@ -96,11 +104,13 @@ public boolean isRegularFile() {
     }
 
     /**
-     * {@inheritDoc}
+     * Tells whether the file is a directory.
      * <p>
      * Will only return true if the directory is a concrete directory. See
      * {@link AzureFileSystemProvider#createDirectory(Path, FileAttribute[])} for more information on virtual and
      * concrete directories.
+     *
+     * @return whether the file is a directory
      */
     @Override
     public boolean isDirectory() {
@@ -108,6 +118,8 @@ public boolean isDirectory() {
     }
 
     /**
+     * Tells whether the file is a symbolic link.
+     *
      * @return false. Symbolic links are not supported.
      */
     @Override
@@ -116,7 +128,9 @@ public boolean isSymbolicLink() {
     }
 
     /**
-     * @return false
+     * Tells whether the file is something other than a regular file, directory, or symbolic link.
+     *
+     * @return false. No other object types are supported.
      */
     @Override
     public boolean isOther() {
@@ -124,7 +138,9 @@ public boolean isOther() {
     }
 
     /**
-     * {@inheritDoc}
+     * Returns the size of the file (in bytes).
+     *
+     * @return the size of the file
      */
     @Override
     public long size() {
@@ -133,8 +149,8 @@ public long size() {
 
     /**
      * Unsupported.
+     *
      * @throws UnsupportedOperationException Operation not supported.
-     * {@inheritDoc}
      */
     @Override
     public Object fileKey() {
diff --git a/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureBlobFileAttributeView.java b/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureBlobFileAttributeView.java
index 241d72e474ae..1bd14b5168b7 100644
--- a/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureBlobFileAttributeView.java
+++ b/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureBlobFileAttributeView.java
@@ -70,8 +70,9 @@ static Map<String, Consumer<Object>> setAttributeConsumers(AzureBlobFileAttribut
     }
 
     /**
-     * Returns "azureBlob".
-     * {@inheritDoc}
+     * Returns the name of the attribute view: {@code "azureBlob"}
+     *
+     * @return the name of the attribute view: {@code "azureBlob"}
      */
     @Override
     public String name() {
@@ -80,8 +81,9 @@ public String name() {
 
     /**
      * Reads the file attributes as a bulk operation.
-     *
-     * Gets a fresh copy every time it is called.
+     * <p>
+     * All file attributes are read as an atomic operation with respect to other file system operations. A fresh copy is
+     * retrieved every time this method is called.
      * @return {@link AzureBlobFileAttributes}
      * @throws IOException if an IOException occurs.
      */
@@ -122,7 +124,7 @@ public void setMetadata(Map<String, String> metadata) throws IOException {
 
     /**
      * Sets the {@link AccessTier} on the file.
-     *
+     * <p>
      * See {@link BlobClientBase#setAccessTier(AccessTier)} for more information.
      * @param tier {@link AccessTier}
      * @throws IOException if an IOException occurs.
@@ -139,7 +141,7 @@ public void setTier(AccessTier tier) throws IOException {
      * Unsupported.
      *
      * @throws UnsupportedOperationException Operation not supported.
-     * {@inheritDoc}
+     * @throws IOException never
      */
     @Override
     public void setTimes(FileTime fileTime, FileTime fileTime1, FileTime fileTime2) throws IOException {
diff --git a/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureBlobFileAttributes.java b/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureBlobFileAttributes.java
index 7c8c25b7fe53..ab224ca8ee1b 100644
--- a/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureBlobFileAttributes.java
+++ b/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureBlobFileAttributes.java
@@ -24,7 +24,7 @@
 import java.util.function.Supplier;
 
 /**
- * File attributes associated with a file stored as a blob in Azure Storage.
+ * Provides support for attributes associated with a file stored as a blob in Azure Storage.
  * <p>
  * Some of the attributes inherited from {@link BasicFileAttributes} are not supported. See the docs on each method for
  * more information.
@@ -32,10 +32,11 @@
 public final class AzureBlobFileAttributes implements BasicFileAttributes {
     /*
     Some blob properties do not have getters as they do not make sense in the context of nio. These properties are:
-        - incremental snapshot related properties
-        - lease related properties
-        - sequence number
-        - encryption key sha256
+        - incremental snapshot related properties (only for page blobs)
+        - lease related properties (leases not currently supported)
+        - sequence number (only for page blobs)
+        - encryption key sha256 (cpk not supported)
+        - committed block count (only for append blobs)
      */
 
     private final ClientLogger logger = new ClientLogger(AzureBlobFileAttributes.class);
@@ -69,7 +70,6 @@ static Map<String, Supplier<Object>> getAttributeSuppliers(AzureBlobFileAttribut
         map.put("archiveStatus", attributes::archiveStatus);
         map.put("accessTierChangeTime", attributes::accessTierChangeTime);
         map.put("metadata", attributes::metadata);
-        map.put("committedBlockCount", attributes::committedBlockCount);
         map.put("isRegularFile", attributes::isRegularFile);
         map.put("isDirectory", attributes::isDirectory);
         map.put("isSymbolicLink", attributes::isSymbolicLink);
@@ -79,7 +79,9 @@ static Map<String, Supplier<Object>> getAttributeSuppliers(AzureBlobFileAttribut
     }
 
     /**
-     * {@inheritDoc}
+     * Returns the creation time. The creation time is the time that the file was created.
+     *
+     * @return The creation time.
      */
     @Override
     public FileTime creationTime() {
@@ -87,7 +89,9 @@ public FileTime creationTime() {
     }
 
     /**
-     * {@inheritDoc}
+     * Returns the time of last modification.
+     *
+     * @return the time of last modification.
      */
     @Override
     public FileTime lastModifiedTime() {
@@ -95,6 +99,8 @@ public FileTime lastModifiedTime() {
     }
 
     /**
+     * Returns the eTag of the blob.
+     *
      * @return the eTag of the blob
      */
     public String eTag() {
@@ -102,6 +108,8 @@ public String eTag() {
     }
 
     /**
+     * Returns the {@link BlobHttpHeaders} of the blob.
+     *
      * @return {@link BlobHttpHeaders}
      */
     public BlobHttpHeaders blobHttpHeaders() {
@@ -120,6 +128,8 @@ public BlobHttpHeaders blobHttpHeaders() {
     }
 
     /**
+     * Returns the type of the blob.
+     *
      * @return the type of the blob
      */
     public BlobType blobType() {
@@ -127,92 +137,116 @@ public BlobType blobType() {
     }
 
     /**
-     * @return the identifier of the last copy operation. If this blob hasn't been the target of a copy operation or has
+     * Returns the identifier of the last copy operation. If this blob hasn't been the target of a copy operation or has
      * been modified since this won't be set.
+     *
+     * @return the identifier of the last copy operation.
      */
     public String copyId() {
         return this.properties.getCopyId();
     }
 
     /**
-     * @return the status of the last copy operation. If this blob hasn't been the target of a copy operation or has
+     * Returns the status of the last copy operation. If this blob hasn't been the target of a copy operation or has
      * been modified since this won't be set.
+     *
+     * @return the status of the last copy operation.
      */
     public CopyStatusType copyStatus() {
         return this.properties.getCopyStatus();
     }
 
     /**
-     * @return the source blob URL from the last copy operation. If this blob hasn't been the target of a copy operation
+     * Returns the source blob URL from the last copy operation. If this blob hasn't been the target of a copy operation
      * or has been modified since this won't be set.
+     *
+     * @return the source blob URL from the last copy operation.
      */
     public String copySource() {
         return this.properties.getCopySource();
     }
 
     /**
-     * @return the number of bytes copied and total bytes in the source from the last copy operation (bytes copied/total
+     * Returns the number of bytes copied and total bytes in the source from the last copy operation (bytes copied/total
      * bytes). If this blob hasn't been the target of a copy operation or has been modified since this won't be set.
+     *
+     * @return the number of bytes copied and total bytes in the source from the last copy operation
      */
     public String copyProgress() {
         return this.properties.getCopyProgress();
     }
 
     /**
-     * @return the completion time of the last copy operation. If this blob hasn't been the target of a copy operation
+     * Returns the completion time of the last copy operation. If this blob hasn't been the target of a copy operation
      * or has been modified since this won't be set.
+     *
+     * @return the completion time of the last copy operation.
      */
     public OffsetDateTime copyCompletionTime() {
         return this.properties.getCopyCompletionTime();
     }
 
     /**
-     * @return the description of the last copy failure, this is set when the {@link #copyStatus() getCopyStatus} is
+     * Returns the description of the last copy failure, this is set when the {@link #copyStatus() getCopyStatus} is
      * {@link CopyStatusType#FAILED failed} or {@link CopyStatusType#ABORTED aborted}. If this blob hasn't been the
      * target of a copy operation or has been modified since this won't be set.
+     *
+     * @return the description of the last copy failure.
      */
     public String copyStatusDescription() {
         return this.properties.getCopyStatusDescription();
     }
 
     /**
-     * @return the status of the blob being encrypted on the server
+     * Returns the status of the blob being encrypted on the server.
+     *
+     * @return the status of the blob being encrypted on the server.
      */
     public Boolean isServerEncrypted() {
         return this.properties.isServerEncrypted();
     }
 
     /**
-     * @return the tier of the blob. This is only set for Page blobs on a premium storage account or for Block blobs on
+     * Returns the tier of the blob. This is only set for Page blobs on a premium storage account or for Block blobs on
      * blob storage or general purpose V2 account.
+     *
+     * @return the tier of the blob.
      */
     public AccessTier accessTier() {
         return this.properties.getAccessTier();
     }
 
     /**
-     * @return the status of the tier being inferred for the blob. This is only set for Page blobs on a premium storage
+     * Returns the status of the tier being inferred for the blob. This is only set for Page blobs on a premium storage
      * account or for Block blobs on blob storage or general purpose V2 account.
+     *
+     * @return the status of the tier being inferred for the blob.
      */
     public Boolean isAccessTierInferred() {
         return this.properties.isAccessTierInferred();
     }
 
     /**
-     * @return the archive status of the blob. This is only for blobs on a blob storage and general purpose v2 account.
+     * Returns the archive status of the blob. This is only for blobs on a blob storage and general purpose v2 account.
+     *
+     * @return the archive status of the blob.
      */
     public ArchiveStatus archiveStatus() {
         return this.properties.getArchiveStatus();
     }
 
     /**
-     * @return the time when the access tier for the blob was last changed
+     * Returns the time when the access tier for the blob was last changed.
+     *
+     * @return the time when the access tier for the blob was last changed.
      */
     public OffsetDateTime accessTierChangeTime() {
         return this.properties.getAccessTierChangeTime();
     }
 
     /**
+     * Returns the metadata associated with this blob.
+     *
      * @return the metadata associated with this blob
      */
     public Map<String, String> metadata() {
@@ -220,24 +254,22 @@ public Map<String, String> metadata() {
     }
 
     /**
-     * @return the number of committed blocks in the blob. This is only returned for Append blobs.
-     */
-    public Integer committedBlockCount() {
-        return this.properties.getCommittedBlockCount();
-    }
-
-    /**
-     * Unsupported.
-     * @throws UnsupportedOperationException Operation not supported.
-     * {@inheritDoc}
+     * Returns the time of last modification.
+     * <p>
+     * Last access time is not supported by the blob service. In this case, it is typical for implementations to return
+     * the {@link #lastModifiedTime()}.
+     *
+     * @return the time of last modification.
      */
     @Override
     public FileTime lastAccessTime() {
-        throw new UnsupportedOperationException();
+        return this.lastModifiedTime();
     }
 
     /**
-     * {@inheritDoc}
+     * Tells whether the file is a regular file with opaque content.
+     *
+     * @return whether the file is a regular file.
      */
     @Override
     public boolean isRegularFile() {
@@ -245,11 +277,13 @@ public boolean isRegularFile() {
     }
 
     /**
-     * {@inheritDoc}
+     * Tells whether the file is a directory.
      * <p>
      * Will only return true if the directory is a concrete directory. See
      * {@link AzureFileSystemProvider#createDirectory(Path, FileAttribute[])} for more information on virtual and
      * concrete directories.
+     *
+     * @return whether the file is a directory
      */
     @Override
     public boolean isDirectory() {
@@ -257,6 +291,8 @@ public boolean isDirectory() {
     }
 
     /**
+     * Tells whether the file is a symbolic link.
+     *
      * @return false. Symbolic links are not supported.
      */
     @Override
@@ -265,7 +301,9 @@ public boolean isSymbolicLink() {
     }
 
     /**
-     * @return false
+     * Tells whether the file is something other than a regular file, directory, or symbolic link.
+     *
+     * @return false. No other object types are supported.
      */
     @Override
     public boolean isOther() {
@@ -273,7 +311,9 @@ public boolean isOther() {
     }
 
     /**
-     * {@inheritDoc}
+     * Returns the size of the file (in bytes).
+     *
+     * @return the size of the file
      */
     @Override
     public long size() {
@@ -283,7 +323,6 @@ public long size() {
     /**
      * Unsupported.
      * @throws UnsupportedOperationException Operation not supported.
-     * {@inheritDoc}
      */
     @Override
     public Object fileKey() {
diff --git a/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureDirectoryStream.java b/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureDirectoryStream.java
index b8b92e0c39ef..2ae98a2bd094 100644
--- a/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureDirectoryStream.java
+++ b/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureDirectoryStream.java
@@ -26,7 +26,7 @@
  *
  * {@inheritDoc}
  */
-public class AzureDirectoryStream implements DirectoryStream<Path> {
+public final class AzureDirectoryStream implements DirectoryStream<Path> {
     private final ClientLogger logger = new ClientLogger(AzureDirectoryStream.class);
 
     private final AzurePath path;
diff --git a/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureFileStore.java b/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureFileStore.java
index bf5507446bef..4b4011bb20c5 100644
--- a/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureFileStore.java
+++ b/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureFileStore.java
@@ -13,14 +13,13 @@
 import java.util.Objects;
 
 /**
- * An {@code AzureFileStore} is backed by an Azure Blob Storage container.
- *
- * {@inheritDoc}
+ * An {@code AzureFileStore} is a {@link FileStore} backed by an Azure Blob Storage container.
  */
 public final class AzureFileStore extends FileStore {
+    private final ClientLogger logger = new ClientLogger(AzureFileStore.class);
+
     private static final String AZURE_FILE_STORE_TYPE = "AzureBlobContainer";
 
-    private final ClientLogger logger = new ClientLogger(AzureFileStore.class);
     private final AzureFileSystem parentFileSystem;
     private final BlobContainerClient containerClient;
 
@@ -48,7 +47,7 @@ public final class AzureFileStore extends FileStore {
     /**
      * Returns the name of the container that underlies this file store.
      *
-     * {@inheritDoc}
+     * @return the name of the container that underlies this file store.
      */
     @Override
     public String name() {
@@ -59,7 +58,7 @@ public String name() {
      * Returns the {@code String "AzureBlobContainer"} to indicate that the file store is backed by a remote blob
      * container in Azure Storage.
      *
-     * {@inheritDoc}
+     * @return {@code "AzureBlobContainer"}
      */
     @Override
     public String type() {
@@ -67,12 +66,14 @@ public String type() {
     }
 
     /**
-     * Always returns false. It may be the case that the authentication method provided to this file system only
+     * Always returns false.
+     * <p>
+     * It may be the case that the authentication method provided to this file system only
      * supports read operations and hence the file store is implicitly read only in this view, but that does not
      * imply the underlying container/file store is inherently read only. Creating/specifying read only file stores
      * is not currently supported.
      *
-     * {@inheritDoc}
+     * @return false.
      */
     @Override
     public boolean isReadOnly() {
@@ -80,9 +81,12 @@ public boolean isReadOnly() {
     }
 
     /**
+     * Returns the size, in bytes, of the file store.
+     * <p>
      * Containers do not limit the amount of data stored. This method will always return max long.
      *
-     * {@inheritDoc}
+     * @return the size of the file store.
+     * @throws IOException If an I/O error occurs.
      */
     @Override
     public long getTotalSpace() throws IOException {
@@ -90,9 +94,12 @@ public long getTotalSpace() throws IOException {
     }
 
     /**
+     * Returns the number of bytes available to this Java virtual machine on the file store.
+     * <p>
      * Containers do not limit the amount of data stored. This method will always return max long.
      *
-     * {@inheritDoc}
+     * @return the number of bytes available on the file store.
+     * @throws IOException If an I/O error occurs.
      */
     @Override
     public long getUsableSpace() throws IOException {
@@ -100,9 +107,12 @@ public long getUsableSpace() throws IOException {
     }
 
     /**
+     * Returns the number of unallocated bytes in the file store.
+     * <p>
      * Containers do not limit the amount of data stored. This method will always return max long.
      *
-     * {@inheritDoc}
+     * @return the number of unallocated bytes in the file store.
+     * @throws IOException If an I/O error occurs.
      */
     @Override
     public long getUnallocatedSpace() throws IOException {
@@ -110,14 +120,16 @@ public long getUnallocatedSpace() throws IOException {
     }
 
     /**
+     * Tells whether or not this file store supports the file attributes identified by the given file attribute view.
+     * <p>
      * All file stores in this file system support the following views:
      * <ul>
      *     <li>{@link java.nio.file.attribute.BasicFileAttributeView}</li>
-     *     <li>{@link java.nio.file.attribute.UserDefinedFileAttributeView}</li>
      *     <li>{@link AzureBasicFileAttributeView}</li>
+     *     <li>{@link AzureBlobFileAttributeView}</li>
      * </ul>
      *
-     * {@inheritDoc}
+     * @return Whether the file attribute view is supported.
      */
     @Override
     public boolean supportsFileAttributeView(Class<? extends FileAttributeView> aClass) {
@@ -125,14 +137,16 @@ public boolean supportsFileAttributeView(Class<? extends FileAttributeView> aCla
     }
 
     /**
+     * Tells whether or not this file store supports the file attributes identified by the given file attribute view.
+     * <p>
      * All file stores in this file system support the following views:
      * <ul>
      *     <li>{@link java.nio.file.attribute.BasicFileAttributeView}</li>
-     *     <li>{@link java.nio.file.attribute.UserDefinedFileAttributeView}</li>
      *     <li>{@link AzureBasicFileAttributeView}</li>
+     *     <li>{@link AzureBlobFileAttributeView}</li>
      * </ul>
      *
-     * {@inheritDoc}
+     * @return whether the file attribute view is supported.
      */
     @Override
     public boolean supportsFileAttributeView(String s) {
@@ -140,9 +154,11 @@ public boolean supportsFileAttributeView(String s) {
     }
 
     /**
+     * Returns a FileStoreAttributeView of the given type.
+     * <p>
      * This method always returns null as no {@link FileStoreAttributeView} is currently supported.
      *
-     * {@inheritDoc}
+     * @return null
      */
     @Override
     public <V extends FileStoreAttributeView> V getFileStoreAttributeView(Class<V> aClass) {
@@ -150,10 +166,14 @@ public <V extends FileStoreAttributeView> V getFileStoreAttributeView(Class<V> a
     }
 
     /**
+     * Unsupported.
+     * <p>
      * This method always throws an {@code UnsupportedOperationException} as no {@link FileStoreAttributeView} is
      * currently supported.
      *
-     * {@inheritDoc}
+     * @return The attribute value.
+     * @throws UnsupportedOperationException unsupported
+     * @throws IOException never
      */
     @Override
     public Object getAttribute(String s) throws IOException {
diff --git a/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureFileSystem.java b/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureFileSystem.java
index 423264e135b5..203199103e5c 100644
--- a/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureFileSystem.java
+++ b/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureFileSystem.java
@@ -17,6 +17,7 @@
 import java.io.IOException;
 import java.nio.file.FileStore;
 import java.nio.file.FileSystem;
+import java.nio.file.InvalidPathException;
 import java.nio.file.Path;
 import java.nio.file.PathMatcher;
 import java.nio.file.WatchService;
@@ -31,16 +32,25 @@
 import java.util.Map;
 import java.util.Objects;
 import java.util.Set;
+import java.util.regex.PatternSyntaxException;
 import java.util.stream.Collectors;
 
 /**
+ * Implement's Java's {@link FileSystem} interface for Azure Blob Storage.
+ * <p>
+ * The following behavior is specific to this FileSystem:
+ * <p>
  * In the hierarchy of this file system, an {@code AzureFileSystem} corresponds to an Azure Blob Storage account. A
  * file store is represented by a container in the storage account. Each container has one root directory.
- *
+ * <p>
  * Closing the file system will not block on outstanding operations. Any operations in progress will be allowed to
  * terminate naturally after the file system is closed, though no further operations may be started after the parent
  * file system is closed.
- * {@inheritDoc}
+ * <p>
+ * All instance of {@code AzureFileSystem} are opened for read-write access.
+ * <p>
+ * For a more complete description of the uses for the constants described here, please see the instructions for opening
+ * and configuring a FileSystem in the docs of {@link FileSystemProvider}.
  */
 public final class AzureFileSystem extends FileSystem {
     private final ClientLogger logger = new ClientLogger(AzureFileSystem.class);
@@ -115,9 +125,13 @@ public final class AzureFileSystem extends FileSystem {
      * Expected type: Boolean
      */
     public static final String AZURE_STORAGE_USE_HTTPS = "AzureStorageUseHttps";
+
     static final String AZURE_STORAGE_HTTP_CLIENT = "AzureStorageHttpClient"; // undocumented; for test.
     static final String AZURE_STORAGE_HTTP_POLICIES = "AzureStorageHttpPolicies"; // undocumented; for test.
 
+    /**
+     * Expected type: String
+     */
     public static final String AZURE_STORAGE_FILE_STORES = "AzureStorageFileStores";
 
     static final String PATH_SEPARATOR = "/";
@@ -174,7 +188,9 @@ public final class AzureFileSystem extends FileSystem {
     }
 
     /**
-     * {@inheritDoc}
+     * Returns the provider that created this file system.
+     *
+     * @return the provider that created this file system.
      */
     @Override
     public FileSystemProvider provider() {
@@ -182,12 +198,19 @@ public FileSystemProvider provider() {
     }
 
     /**
+     * Closes this file system.
+     * <p>
+     * After a file system is closed then all subsequent access to the file system, either by methods defined by this
+     * class or on objects associated with this file system, throw ClosedFileSystemException. If the file system is
+     * already closed then invoking this method has no effect.
+     * <p>
      * Closing the file system will not block on outstanding operations. Any operations in progress will be allowed to
      * terminate naturally after the file system is closed, though no further operations may be started after the
      * parent file system is closed.
-     *
+     * <p>
      * Once closed, a file system with the same identifier as the one closed may be re-opened.
-     * {@inheritDoc}
+     *
+     * @throws IOException If an I/O error occurs.
      */
     @Override
     public void close() throws IOException {
@@ -196,7 +219,9 @@ public void close() throws IOException {
     }
 
     /**
-     * {@inheritDoc}
+     * Tells whether or not this file system is open.
+     *
+     * @return whether or not this file system is open.
      */
     @Override
     public boolean isOpen() {
@@ -204,12 +229,14 @@ public boolean isOpen() {
     }
 
     /**
+     * Tells whether or not this file system allows only read-only access to its file stores.
+     * <p>
      * Always returns false. It may be the case that the authentication method provided to this file system only
      * supports read operations and hence the file system is implicitly read only in this view, but that does not
      * imply the underlying account/file system is inherently read only. Creating/specifying read only file
      * systems is not supported.
      *
-     * {@inheritDoc}
+     * @return false
      */
     @Override
     public boolean isReadOnly() {
@@ -217,9 +244,11 @@ public boolean isReadOnly() {
     }
 
     /**
+     * Returns the name separator, represented as a string.
+     * <p>
      * The separator used in this file system is {@code "/"}.
      *
-     * {@inheritDoc}
+     * @return "/"
      */
     @Override
     public String getSeparator() {
@@ -227,50 +256,60 @@ public String getSeparator() {
     }
 
     /**
+     * Returns an object to iterate over the paths of the root directories.
+     * <p>
      * The list of root directories corresponds to the list of available file stores and therefore containers specified
-     * upon initialization. A root directory always takes the form {@code "&lt;file-store-name&gt;:"}. This list will
+     * upon initialization. A root directory always takes the form {@code "<file-store-name>:"}. This list will
      * respect the parameters provided during initialization.
      * <p>
      * If a finite list of containers was provided on start up, this list will not change during the lifetime of this
      * object. If containers are added to the account after initialization, they will be ignored. If a container is
      * deleted or otherwise becomes unavailable, its root directory will still be returned but operations to it will
-     * fail. If the file system was set to use all containers in the account, the account will be re-queried and the
-     * list may grow or shrink if containers were added or deleted.
+     * fail.
      *
-     * {@inheritDoc}
+     * @return  an object to iterate over the paths of the root directories
      */
     @Override
     public Iterable<Path> getRootDirectories() {
+        /*
+        Should we add different initialization options later:
+        If the file system was set to use all containers in the account, the account will be re-queried and the
+        list may grow or shrink if containers were added or deleted.
+         */
         return fileStores.keySet().stream()
             .map(name -> this.getPath(name + AzurePath.ROOT_DIR_SUFFIX))
             .collect(Collectors.toList());
     }
 
     /**
+     * Returns an object to iterate over the underlying file stores
+     * <p>
      * This list will respect the parameters provided during initialization.
      * <p>
      * If a finite list of containers was provided on start up, this list will not change during the lifetime of this
      * object. If containers are added to the account after initialization, they will be ignored. If a container is
      * deleted or otherwise becomes unavailable, its root directory will still be returned but operations to it will
-     * fail. If the file system was set to use all containers in the account, the account will be re-queried and the
-     * list may grow or shrink if containers were added or deleted.
-     *
-     * {@inheritDoc}
+     * fail.
      */
     @Override
     public Iterable<FileStore> getFileStores() {
+        /*
+        Should we add different intialization options later:
+        If the file system was set to use all containers in the account, the account will be re-queried and the
+        list may grow or shrink if containers were added or deleted.
+         */
         return this.fileStores.values();
     }
 
     /**
+     * Returns the set of the names of the file attribute views supported by this FileSystem.
+     * <p>
      * This file system supports the following views:
      * <ul>
      *     <li>{@link java.nio.file.attribute.BasicFileAttributeView}</li>
-     *     <li>{@link java.nio.file.attribute.UserDefinedFileAttributeView}</li>
      *     <li>{@link AzureBasicFileAttributeView}</li>
+     *     <li>{@link AzureBlobFileAttributeView}</li>
      * </ul>
-     *
-     * {@inheritDoc}
      */
     @Override
     public Set<String> supportedFileAttributeViews() {
@@ -278,6 +317,13 @@ public Set<String> supportedFileAttributeViews() {
     }
 
     /**
+     * Converts a path string, or a sequence of strings that when joined form a path string, to a Path.
+     * <p>
+     * If more does not specify any elements then the value of the first parameter is the path string to convert. If
+     * more specifies one or more elements then each non-empty string, including first, is considered to be a sequence
+     * of name elements (see Path) and is joined to form a path string. The strings will be joined using the name
+     * separator.
+     * <p>
      * Each name element will be {@code String}-joined to the other elements by this file system's path separator.
      * Naming conventions and allowed characters are as
      * <a href="https://docs.microsoft.com/en-us/rest/api/storageservices/Naming-and-Referencing-Containers--Blobs--and-Metadata">defined</a>
@@ -285,7 +331,7 @@ public Set<String> supportedFileAttributeViews() {
      * are interpreted as a part of the blob name. The character {@code ':'} is only allowed in the root component and
      * must be the last character of the root component.
      *
-     * {@inheritDoc}
+     * @throws InvalidPathException if the path string cannot be converted.
      */
     @Override
     public Path getPath(String s, String... strings) {
@@ -295,16 +341,19 @@ public Path getPath(String s, String... strings) {
     /**
      * Unsupported.
      *
-     * {@inheritDoc}
+     * @throws UnsupportedOperationException unsupported.
+     * @throws IllegalArgumentException never
+     * @throws PatternSyntaxException never
      */
     @Override
-    public PathMatcher getPathMatcher(String s) {
+    public PathMatcher getPathMatcher(String s) throws IllegalArgumentException, PatternSyntaxException {
         throw LoggingUtility.logError(logger, new UnsupportedOperationException());
     }
 
     /**
      * Unsupported.
-     * {@inheritDoc}
+     *
+     * @throws UnsupportedOperationException unsupported.
      */
     @Override
     public UserPrincipalLookupService getUserPrincipalLookupService() {
@@ -314,7 +363,8 @@ public UserPrincipalLookupService getUserPrincipalLookupService() {
     /**
      * Unsupported.
      *
-     * {@inheritDoc}
+     * @throws UnsupportedOperationException unsupported.
+     * @throws IOException never.
      */
     @Override
     public WatchService newWatchService() throws IOException {
diff --git a/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureFileSystemProvider.java b/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureFileSystemProvider.java
index 1a63f257dd36..2b0254e2c274 100644
--- a/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureFileSystemProvider.java
+++ b/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureFileSystemProvider.java
@@ -76,7 +76,7 @@
  * {@link FileSystemProvider}.
  * <p>
  * The scheme for this provider is {@code "azb"}, and the format of the URI to identify an {@code AzureFileSystem} is
- * {@code "azb://?account=&lt;accountName&gt;"}. The name of the Storage account is used to uniquely identify the file
+ * {@code "azb://?account=<accountName>"}. The name of the Storage account is used to uniquely identify the file
  * system.
  * <p>
  * An {@link AzureFileSystem} is backed by an account. An {@link AzureFileStore} is backed by a container. Any number of
@@ -125,11 +125,34 @@
 public final class AzureFileSystemProvider extends FileSystemProvider {
     private final ClientLogger logger = new ClientLogger(AzureFileSystemProvider.class);
 
+    /**
+     * A helper for setting the HTTP properties when creating a directory.
+     */
     public static final String CONTENT_TYPE = "Content-Type";
+
+    /**
+     * A helper for setting the HTTP properties when creating a directory.
+     */
     public static final String CONTENT_DISPOSITION = "Content-Disposition";
+
+    /**
+     * A helper for setting the HTTP properties when creating a directory.
+     */
     public static final String CONTENT_LANGUAGE = "Content-Language";
+
+    /**
+     * A helper for setting the HTTP properties when creating a directory.
+     */
     public static final String CONTENT_ENCODING = "Content-Encoding";
+
+    /**
+     * A helper for setting the HTTP properties when creating a directory.
+     */
     public static final String CONTENT_MD5 = "Content-MD5";
+
+    /**
+     * A helper for setting the HTTP properties when creating a directory.
+     */
     public static final String CACHE_CONTROL = "Cache-Control";
 
     private static final String ACCOUNT_QUERY_KEY = "account";
@@ -147,7 +170,9 @@ public AzureFileSystemProvider() {
     }
 
     /**
-     * Returns {@code "azb".}
+     * Returns the URI scheme that identifies this provider: {@code "azb".}
+     *
+     * @return {@code "azb"}
      */
     @Override
     public String getScheme() {
@@ -155,10 +180,18 @@ public String getScheme() {
     }
 
     /**
-     * The format of a {@code URI} identifying a file system is {@code "azb://?account=&lt;accountName&gt;"}.
+     * Constructs a new FileSystem object identified by a URI.
+     * <p>
+     * The format of a {@code URI} identifying a file system is {@code "azb://?account=<accountName>"}.
      * <p>
      * Once closed, a file system with the same identifier may be reopened.
-     * {@inheritDoc}
+     *
+     * @return a new file system.
+     * @throws IllegalArgumentException If the pre-conditions for the uri parameter aren't met, or the env parameter
+     * does not contain properties required by the provider, or a property value is invalid.
+     * @throws IOException If an I/O error occurs.
+     * @throws SecurityException never
+     * @throws FileSystemAlreadyExistsException If the file system has already been created.
      */
     @Override
     public FileSystem newFileSystem(URI uri, Map<String, ?> config) throws IOException {
@@ -175,11 +208,17 @@ public FileSystem newFileSystem(URI uri, Map<String, ?> config) throws IOExcepti
     }
 
     /**
+     * Returns an existing FileSystem created by this provider.
+     * <p>
      * The format of a {@code URI} identifying an file system is {@code "azb://?account=&lt;accountName&gt;"}.
      * <p>
      * Trying to retrieve a closed file system will throw a {@link FileSystemNotFoundException}. Once closed, a
      * file system with the same identifier may be reopened.
-     * {@inheritDoc}
+     *
+     * @return the file system
+     * @throws IllegalArgumentException If the pre-conditions for the uri parameter aren't met
+     * @throws FileSystemNotFoundException If the file system already exists
+     * @throws SecurityException never
      */
     @Override
     public FileSystem getFileSystem(URI uri) {
@@ -191,7 +230,16 @@ public FileSystem getFileSystem(URI uri) {
     }
 
     /**
-     * {@inheritDoc}
+     * Return a Path object by converting the given URI. The resulting Path is associated with a FileSystem that already
+     * exists.
+     *
+     * @return The path identified by the URI.
+     * @throws IllegalArgumentException If the URI scheme does not identify this provider or other preconditions on the
+     * uri parameter do not hold
+     * @throws FileSystemNotFoundException if the file system identified by the query does not exist
+     * @throws SecurityException never
+     *
+     * @see #getFileSystem(URI) for information on the URI format
      */
     @Override
     public Path getPath(URI uri) {
@@ -199,8 +247,16 @@ public Path getPath(URI uri) {
     }
 
     /**
+     * Unsupported. Use {@link #newInputStream(Path, OpenOption...)} or {@link #newOutputStream(Path, OpenOption...)}
+     * instead.
+     *
+     * @returns a new seekable byte channel
      * @throws UnsupportedOperationException Operation is not supported.
-     * {@inheritDoc}
+     * @throws IllegalArgumentException if the set contains an invalid combination of options
+     * @throws FileAlreadyExistsException  if a file of that name already exists and the CREATE_NEW option is specified
+     * (optional specific exception)
+     * @throws IOException If an I/O error occurs.
+     * @throws SecurityException never
      */
     @Override
     public SeekableByteChannel newByteChannel(Path path, Set<? extends OpenOption> set,
@@ -217,7 +273,11 @@ public SeekableByteChannel newByteChannel(Path path, Set<? extends OpenOption> s
      * <p>
      * Only {@link StandardOpenOption#READ} is supported. Any other option will throw.
      *
-     * {@inheritDoc}
+     * @return a new input stream
+     * @throws IllegalArgumentException if an invalid combination of options is specified
+     * @throws UnsupportedOperationException if an unsupported option is specified
+     * @throws IOException If an I/O error occurs.
+     * @throws SecurityException never
      */
     @Override
     public InputStream newInputStream(Path path, OpenOption... options) throws IOException {
@@ -267,7 +327,11 @@ public InputStream newInputStream(Path path, OpenOption... options) throws IOExc
      * This can be a useful tool because writing happens asynchronously, and therefore an error from a previous write
      * may not otherwise be thrown unless the stream is flushed, closed, or written to again.
      *
-     * {@inheritDoc}
+     * @return a new output stream
+     * @throws IllegalArgumentException if an invalid combination of options is specified
+     * @throws UnsupportedOperationException if an unsupported option is specified
+     * @throws IOException If an I/O error occurs.
+     * @throws SecurityException never
      */
     @Override
     public OutputStream newOutputStream(Path path, OpenOption... options) throws IOException {
@@ -340,10 +404,23 @@ public OutputStream newOutputStream(Path path, OpenOption... options) throws IOE
     }
 
     /**
-     * Returns an {@link AzureDirectoryStream} for iterating over the contents of a directory.
+     * Returns an {@link AzureDirectoryStream} for iterating over the contents of a directory. The elements returned by
+     * the directory stream's iterator are of type Path, each one representing an entry in the directory. The Path
+     * objects are obtained as if by resolving the name of the directory entry against dir. The entries returned by the
+     * iterator are filtered by the given filter.
+     * <p>
+     * When not using the try-with-resources construct, then directory stream's close method should be invoked after
+     * iteration is completed so as to free any resources held for the open directory.
+     * <p>
+     * Where the filter terminates due to an uncaught error or runtime exception then it is propagated to the hasNext or
+     * next method. Where an IOException is thrown, it results in the hasNext or next method throwing a
+     * DirectoryIteratorException with the IOException as the cause.
      *
-     * {@inheritDoc}
+     * @return a new and open {@code DirectoryStream} object
      * @throws IllegalArgumentException If the path type is not an instance of {@link AzurePath}.
+     * @throws NotDirectoryException if the file could not otherwise be opened because it is not a directory
+     * @throws IOException If an I/O error occurs.
+     * @throws SecurityException never
      */
     @Override
     public DirectoryStream<Path> newDirectoryStream(Path path, DirectoryStream.Filter<? super Path> filter)
@@ -399,7 +476,8 @@ public DirectoryStream<Path> newDirectoryStream(Path path, DirectoryStream.Filte
      * location. In other words, it is possible to "double create" a directory if it first weakly exists and then is
      * strongly created. This is both because it is impossible to atomically check if a virtual directory exists while
      * creating a concrete directory and because such behavior will have minimal side effects--no files will be
-     * overwritten and the directory will still be available for writing as intended, though it may not be empty.
+     * overwritten and the directory will still be available for writing as intended, though it may not be empty. This
+     * is not a complete list of such unintuitive behavior.
      * <p>
      * This method will attempt to extract standard HTTP content headers from the list of file attributes to set them
      * as blob headers. All other attributes will be set as blob metadata. The value of every attribute will be
@@ -419,8 +497,13 @@ public DirectoryStream<Path> newDirectoryStream(Path path, DirectoryStream.Filte
      * <a href="https://docs.microsoft.com/en-us/rest/api/storageservices/set-blob-properties">Azure Docs</a> for more
      * information.
      *
-     * {@inheritDoc}
      * @throws IllegalArgumentException If the path type is not an instance of {@link AzurePath}.
+     * @throws UnsupportedOperationException if the array contains an attribute that cannot be set atomically when
+     * creating the directory
+     * @throws FileAlreadyExistsException if a directory could not otherwise be created because a file of that name
+     * already exists
+     * @throws IOException If an I/O error occurs.
+     * @throws SecurityException never
      */
     @Override
     public void createDirectory(Path path, FileAttribute<?>... fileAttributes) throws IOException {
@@ -453,12 +536,16 @@ public void createDirectory(Path path, FileAttribute<?>... fileAttributes) throw
     /**
      * Deletes the specified resource.
      * <p>
-     * This method is not atomic. It is possible to delete a file in use by another process, and doing so will not
-     * immediately invalidate any channels open to that file--they will simply start to fail. Root directories cannot be
-     * deleted even when empty.
-     * {@inheritDoc}
+     * This method is not atomic with respect to other file system operations. It is possible to delete a file in use by
+     * another process, and doing so will not immediately invalidate any channels open to that file--they will simply
+     * start to fail. Root directories cannot be deleted even when empty.
      *
      * @throws IllegalArgumentException If the path type is not an instance of {@link AzurePath}.
+     * @throws NoSuchFileException if the file does not exist
+     * @throws DirectoryNotEmptyException if the file is a directory and could not otherwise be deleted because the
+     * directory is not empty
+     * @throws IOException If an I/O error occurs.
+     * @throws SecurityException never
      */
     @Override
     public void delete(Path path) throws IOException {
@@ -488,26 +575,33 @@ public void delete(Path path) throws IOException {
     /**
      * Copies the resource at the source location to the destination.
      * <p>
-     * This method is not atomic. More specifically, the checks necessary to validate the
-     * inputs and state of the file system are not atomic with the actual copying of data. If the copy is triggered,
-     * the copy itself is atomic and only a complete copy will ever be left at the destination.
+     * This method is not atomic with respect to other file system operations. More specifically, the checks necessary
+     * to validate the inputs and state of the file system are not atomic with the actual copying of data. If the copy
+     * is triggered, the copy itself is atomic and only a complete copy will ever be left at the destination.
+     * <p>
+     * In addition to those in the docs for {@link FileSystemProvider#copy(Path, Path, CopyOption...)}, this method has
+     * the following requirements for successful completion. {@link StandardCopyOption#COPY_ATTRIBUTES} must be passed
+     * as it is impossible not to copy blob properties; if this option is not passed, an
+     * {@link UnsupportedOperationException} will be thrown. Neither the source nor the destination can be a root
+     * directory; if either is a root directory, an {@link IllegalArgumentException} will be thrown. The parent
+     * directory of the destination must at least weakly exist; if it does not, an {@link IOException} will be thrown.
+     * The only supported option other than {@link StandardCopyOption#COPY_ATTRIBUTES} is
+     * {@link StandardCopyOption#REPLACE_EXISTING}; the presence of any other option will result in an
+     * {@link UnsupportedOperationException}.
      * <p>
-     * In addition to those in the nio javadocs, this method has the following requirements for successful completion.
-     * {@link StandardCopyOption#COPY_ATTRIBUTES} must be passed as it is impossible not to copy blob properties;
-     * if this option is not passed, an {@link UnsupportedOperationException} will be thrown. Neither the source nor the
-     * destination can be a root directory; if either is a root directory, an {@link IllegalArgumentException} will be
-     * thrown. The parent directory of the destination must at least weakly exist; if it does not, an
-     * {@link IOException} will be thrown. The only supported option other than
-     * {@link StandardCopyOption#COPY_ATTRIBUTES} is {@link StandardCopyOption#REPLACE_EXISTING}; the presence of any
-     * other option will result in an {@link UnsupportedOperationException}.
-     *
      * This method supports both virtual and concrete directories as both the source and destination. Unlike when
      * creating a directory, the existence of a virtual directory at the destination will cause this operation to fail.
      * This is in order to prevent the possibility of overwriting a non-empty virtual directory with a file. Still, as
      * mentioned above, this check is not atomic with the creation of the resultant directory.
      *
-     * {@inheritDoc}
+     * @throws UnsupportedOperationException if the array contains a copy option that is not supported
+     * @throws FileAlreadyExistsException if the target file exists but cannot be replaced because the REPLACE_EXISTING
+     * option is not specified
+     * @throws DirectoryNotEmptyException the REPLACE_EXISTING option is specified but the file cannot be replaced
+     * because it is a non-empty directory
+     * @throws IOException If an I/O error occurs.
      * @throws IllegalArgumentException If the path type is not an instance of {@link AzurePath}.
+     * @throws SecurityException never
      * @see #createDirectory(Path, FileAttribute[]) for more information about directory existence.
      */
     @Override
@@ -612,8 +706,9 @@ public void copy(Path source, Path destination, CopyOption... copyOptions) throw
     }*/
 
     /**
+     * Unsupported.
+     *
      * @throws UnsupportedOperationException Operation is not supported.
-     * {@inheritDoc}
      */
     @Override
     public void move(Path path, Path path1, CopyOption... copyOptions) throws IOException {
@@ -621,8 +716,9 @@ public void move(Path path, Path path1, CopyOption... copyOptions) throws IOExce
     }
 
     /**
+     * Unsupported.
+     *
      * @throws UnsupportedOperationException Operation is not supported.
-     * {@inheritDoc}
      */
     @Override
     public boolean isSameFile(Path path, Path path1) throws IOException {
@@ -630,7 +726,11 @@ public boolean isSameFile(Path path, Path path1) throws IOException {
     }
 
     /**
-     * {@inheritDoc}
+     * Always returns false as hidden files are not supported.
+     *
+     * @return false
+     * @throws IOException If an I/O error occurs.
+     * @throws SecurityException never
      */
     @Override
     public boolean isHidden(Path path) throws IOException {
@@ -638,8 +738,12 @@ public boolean isHidden(Path path) throws IOException {
     }
 
     /**
+     * Unsupported.
+     *
+     * @return the file store where the file is stored.
      * @throws UnsupportedOperationException Operation is not supported.
-     * {@inheritDoc}
+     * @throws IOException If an I/O error occurs.
+     * @throws SecurityException never
      */
     @Override
     public FileStore getFileStore(Path path) throws IOException {
@@ -647,8 +751,14 @@ public FileStore getFileStore(Path path) throws IOException {
     }
 
     /**
+     * Unsupported.
+     *
      * @throws UnsupportedOperationException Operation is not supported.
-     * {@inheritDoc}
+     * @throws NoSuchFileException if a file does not exist
+     * @throws java.nio.file.AccessDeniedException the requested access would be denied or the access cannot be
+     * determined because the Java virtual machine has insufficient privileges or other reasons
+     * @throws IOException If an I/O error occurs.
+     * @throws SecurityException never
      */
     @Override
     public void checkAccess(Path path, AccessMode... accessModes) throws IOException {
@@ -657,12 +767,13 @@ public void checkAccess(Path path, AccessMode... accessModes) throws IOException
 
     /**
      * Returns a file attribute view of a given type.
-     *
+     * <p>
      * See {@link AzureBasicFileAttributeView} and {@link AzureBlobFileAttributeView} for more information.
-     *
+     * <p>
      * Reading or setting attributes on a virtual directory is not supported and will throw an {@link IOException}. See
      * {@link #createDirectory(Path, FileAttribute[])} for more information on virtual directories.
-     * {@inheritDoc}
+     *
+     * @return a file attribute view of the specified type, or null if the attribute view type is not available
      */
     @Override
     @SuppressWarnings("unchecked")
@@ -682,12 +793,16 @@ public <V extends FileAttributeView> V getFileAttributeView(Path path, Class<V>
 
     /**
      * Reads a file's attributes as a bulk operation.
-     *
+     * <p>
      * See {@link AzureBasicFileAttributes} and {@link AzureBlobFileAttributes} for more information.
-     *
+     * <p>
      * Reading attributes on a virtual directory is not supported and will throw an {@link IOException}. See
      * {@link #createDirectory(Path, FileAttribute[])} for more information on virtual directories.
-     * {@inheritDoc}
+     *
+     * @return the file attributes
+     * @throws UnsupportedOperationException if an attributes of the given type are not supported
+     * @throws IOException If an I/O error occurs.
+     * @throws SecurityException never
      */
     @Override
     @SuppressWarnings("unchecked")
@@ -711,12 +826,18 @@ public <A extends BasicFileAttributes> A readAttributes(Path path, Class<A> aCla
 
     /**
      * Reads a set of file attributes as a bulk operation.
-     *
+     * <p>
      * See {@link AzureBasicFileAttributes} and {@link AzureBlobFileAttributes} for more information.
-     *
+     * <p>
      * Reading attributes on a virtual directory is not supported and will throw an {@link IOException}. See
      * {@link #createDirectory(Path, FileAttribute[])} for more information on virtual directories.
-     * {@inheritDoc}
+     *
+     * @return a map of the attributes returned; may be empty. The map's keys are the attribute names, its values are
+     * the attribute values
+     * @throws UnsupportedOperationException if an attributes of the given type are not supported
+     * @throws IllegalArgumentException if no attributes are specified or an unrecognized attributes is specified
+     * @throws IOException If an I/O error occurs.
+     * @throws SecurityException never
      */
     @Override
     public Map<String, Object> readAttributes(Path path, String s, LinkOption... linkOptions) throws IOException {
@@ -819,12 +940,19 @@ public Map<String, Object> readAttributes(Path path, String s, LinkOption... lin
 
     /**
      * Sets the value of a file attribute.
-     *
+     * <p>
      * See {@link AzureBlobFileAttributeView} for more information.
-     *
+     * <p>
      * Setting attributes on a virtual directory is not supported and will throw an {@link IOException}. See
      * {@link #createDirectory(Path, FileAttribute[])} for more information on virtual directories.
-     * {@inheritDoc}
+     *
+     * @throws UnsupportedOperationException if an attribute view is not available
+     * @throws IllegalArgumentException if the attribute name is not specified, or is not recognized, or the attribute
+     * value is of the correct type but has an inappropriate value
+     * @throws ClassCastException If the attribute value is not of the expected type or is a collection containing
+     * elements that are not of the expected type
+     * @throws IOException If an I/O error occurs.
+     * @throws SecurityException never
      */
     @Override
     public void setAttribute(Path path, String s, Object o, LinkOption... linkOptions) throws IOException {
diff --git a/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/LoggingUtility.java b/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/LoggingUtility.java
index b2a98e32b2a3..3cd503f98c21 100644
--- a/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/LoggingUtility.java
+++ b/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/LoggingUtility.java
@@ -8,7 +8,7 @@
 /**
  * Only a minimal Utility class to get around a shortcoming in Core's logging.
  */
-class LoggingUtility {
+final class LoggingUtility {
     public static <T extends Exception> T logError(ClientLogger logger, T e) {
         logger.error(e.getMessage());
         return e;
diff --git a/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/NioBlobInputStream.java b/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/NioBlobInputStream.java
index ed350cb00f0b..b765ab73e737 100644
--- a/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/NioBlobInputStream.java
+++ b/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/NioBlobInputStream.java
@@ -12,7 +12,7 @@
 /**
  * Provides an InputStream to read a file stored as an Azure Blob.
  */
-public class NioBlobInputStream extends InputStream {
+public final class NioBlobInputStream extends InputStream {
     private final ClientLogger logger = new ClientLogger(NioBlobInputStream.class);
 
     private final BlobInputStream blobInputStream;
diff --git a/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/NioBlobOutputStream.java b/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/NioBlobOutputStream.java
index 6ec976616ebb..b048128d6445 100644
--- a/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/NioBlobOutputStream.java
+++ b/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/NioBlobOutputStream.java
@@ -12,7 +12,7 @@
 /**
  * Provides an OutputStream to write to a file stored as an Azure Blob.
  */
-public class NioBlobOutputStream extends OutputStream {
+public final class NioBlobOutputStream extends OutputStream {
     private final ClientLogger logger = new ClientLogger(NioBlobOutputStream.class);
 
     private final BlobOutputStream blobOutputStream;
diff --git a/sdk/storage/azure-storage-blob-nio/src/samples/java/com/azure/storage/blob/nio/ReadmeSamples.java b/sdk/storage/azure-storage-blob-nio/src/samples/java/com/azure/storage/blob/nio/ReadmeSamples.java
index 004d5cfd1e1e..88c9ded9f25a 100644
--- a/sdk/storage/azure-storage-blob-nio/src/samples/java/com/azure/storage/blob/nio/ReadmeSamples.java
+++ b/sdk/storage/azure-storage-blob-nio/src/samples/java/com/azure/storage/blob/nio/ReadmeSamples.java
@@ -37,8 +37,9 @@ public ReadmeSamples() throws URISyntaxException, IOException {
 
     public void createAFileSystem() throws URISyntaxException, IOException {
         Map<String, Object> config = new HashMap<>();
+        String[] stores = {"<your_container_name", "another_container_name"}; // Any iterable is acceptable
         config.put(AzureFileSystem.AZURE_STORAGE_ACCOUNT_KEY, "<your_account_key>");
-        config.put(AzureFileSystem.AZURE_STORAGE_FILE_STORES, "<container_names>");
+        config.put(AzureFileSystem.AZURE_STORAGE_FILE_STORES, stores);
         FileSystem myFs = FileSystems.newFileSystem(new URI("azb://?account=<your_account_name"), config);
     }
 
diff --git a/sdk/storage/azure-storage-blob-nio/src/test/java/com/azure/storage/blob/nio/AttributeViewTest.groovy b/sdk/storage/azure-storage-blob-nio/src/test/java/com/azure/storage/blob/nio/AttributeViewTest.groovy
index 1a9585a9378e..b573094d8f4f 100644
--- a/sdk/storage/azure-storage-blob-nio/src/test/java/com/azure/storage/blob/nio/AttributeViewTest.groovy
+++ b/sdk/storage/azure-storage-blob-nio/src/test/java/com/azure/storage/blob/nio/AttributeViewTest.groovy
@@ -97,7 +97,6 @@ class AttributeViewTest extends APISpec {
         props.getArchiveStatus() == attr.archiveStatus()
         props.getAccessTierChangeTime() == attr.accessTierChangeTime()
         props.getMetadata() == attr.metadata()
-        props.getCommittedBlockCount() == attr.committedBlockCount()
 
         /*
         suppliers. Used in FileSystemProvider.readAttributes(String)
@@ -133,7 +132,6 @@ class AttributeViewTest extends APISpec {
         props.getArchiveStatus() == suppliers.get("archiveStatus").get()
         props.getAccessTierChangeTime() == suppliers.get("accessTierChangeTime").get()
         props.getMetadata() == suppliers.get("metadata").get()
-        props.getCommittedBlockCount() == suppliers.get("committedBlockCount").get()
     }
 
     @Unroll

From c95c28a68e3963fae1b531520829685b02f8534c Mon Sep 17 00:00:00 2001
From: Rick Ley <frley@microsoft.com>
Date: Tue, 14 Jul 2020 13:58:14 -0700
Subject: [PATCH 2/5] Added javadocs to AzurePath

---
 .../com/azure/storage/blob/nio/AzurePath.java | 222 +++++++++++++++---
 1 file changed, 186 insertions(+), 36 deletions(-)

diff --git a/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzurePath.java b/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzurePath.java
index 9f2fb2449a3f..7cd0e2330b1e 100644
--- a/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzurePath.java
+++ b/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzurePath.java
@@ -29,6 +29,8 @@
 import java.util.stream.Stream;
 
 /**
+ * An object that may be used to locate a file in a file system.
+ * <p>
  * The root component, if it is present, is the first element of the path and is denoted by a {@code ':'} as the last
  * character. Hence, only one instance of {@code ':'} may appear in a path string and it may only be the last character
  * of the first element in the path. The root component is used to identify which container a path belongs to.
@@ -41,9 +43,9 @@
  * If a resource is accessed via a relative path, it will be resolved against the default directory of the file system.
  * The default directory is as defined in the {@link AzureFileSystem} docs.
  * <p>
- * Leading and trailing separators will be stripped. This has the effect of making "foo/" and "foo" equivalent paths.
- *
- * {@inheritDoc}
+ * Leading and trailing separators will be stripped from each component passed to
+ * {@link AzureFileSystem#getPath(String, String...)}. This has the effect of treating "foo/" as though it were simply
+ * "foo".
  */
 public final class AzurePath implements Path {
     private final ClientLogger logger = new ClientLogger(AzurePath.class);
@@ -91,7 +93,9 @@ public final class AzurePath implements Path {
     }
 
     /**
-     * {@inheritDoc}
+     * Returns the file system that created this object.
+     *
+     * @return the file system that created this object
      */
     @Override
     public FileSystem getFileSystem() {
@@ -99,9 +103,12 @@ public FileSystem getFileSystem() {
     }
 
     /**
-     * A path is considered absolute in this file system if it contains a root component.
+     * Tells whether or not this path is absolute.
+     * <p>
+     * An absolute path is complete in that it doesn't need to be combined with other path information in order to
+     * locate a file. A path is considered absolute in this file system if it contains a root component.
      *
-     * {@inheritDoc}
+     * @return whether the path is absolute
      */
     @Override
     public boolean isAbsolute() {
@@ -109,11 +116,13 @@ public boolean isAbsolute() {
     }
 
     /**
+     * Returns the root component of this path as a Path object, or null if this path does not have a root component.
+     * <p>
      * The root component of this path also identifies the Azure Storage Container in which the file is stored. This
      * method will not validate that the root component corresponds to an actual file store/container in this
      * file system. It will simply return the root component of the path if one is present and syntactically valid.
      *
-     * {@inheritDoc}
+     * @return a path representing the root component of this path, or null
      */
     @Override
     public Path getRoot() {
@@ -126,7 +135,10 @@ public Path getRoot() {
     }
 
     /**
-     * {@inheritDoc}
+     * Returns the name of the file or directory denoted by this path as a Path object. The file name is the farthest
+     * element from the root in the directory hierarchy.
+     *
+     * @return a path representing the name of the file or directory, or null if this path has zero elements
      */
     @Override
     public Path getFileName() {
@@ -141,7 +153,21 @@ public Path getFileName() {
     }
 
     /**
-     * {@inheritDoc}
+     * Returns the parent path, or null if this path does not have a parent.
+     * <p>
+     * The parent of this path object consists of this path's root component, if any, and each element in the path
+     * except for the farthest from the root in the directory hierarchy. This method does not access the file system;
+     * the path or its parent may not exist. Furthermore, this method does not eliminate special names such as "." and
+     * ".." that may be used in some implementations. On UNIX for example, the parent of "/a/b/c" is "/a/b", and the
+     * parent of "x/y/." is "x/y". This method may be used with the normalize method, to eliminate redundant names, for
+     * cases where shell-like navigation is required.
+     * <p>
+     * If this path has one or more elements, and no root component, then this method is equivalent to evaluating the
+     * expression:
+     *
+     *  {@code subpath(0, getNameCount()-1);}
+     *
+     * @return a path representing the path's parent
      */
     @Override
     public Path getParent() {
@@ -159,7 +185,9 @@ public Path getParent() {
     }
 
     /**
-     * {@inheritDoc}
+     * Returns the number of name elements in the path.
+     *
+     * @return the number of elements in the path, or 0 if this path only represents a root component
      */
     @Override
     public int getNameCount() {
@@ -170,7 +198,14 @@ public int getNameCount() {
     }
 
     /**
-     * {@inheritDoc}
+     * Returns a name element of this path as a Path object.
+     * <p>
+     * The index parameter is the index of the name element to return. The element that is closest to the root in the
+     * directory hierarchy has index 0. The element that is farthest from the root has index {@code count-1}.
+     *
+     * @return the name element
+     * @throws IllegalArgumentException if index is negative, index is greater than or equal to the number of elements,
+     * or this path has zero name elements
      */
     @Override
     public Path getName(int i) {
@@ -190,7 +225,14 @@ public Path getName(int i) {
     }
 
     /**
-     * {@inheritDoc}
+     * Returns a relative Path that is a subsequence of the name elements of this path.
+     * <p>
+     * The beginIndex and endIndex parameters specify the subsequence of name elements. The name that is closest to the
+     * root in the directory hierarchy has index 0. The name that is farthest from the root has index {@code count-1}.
+     * The returned Path object has the name elements that begin at beginIndex and extend to the element at index
+     * {@code endIndex-1}.
+     *
+     * @return a new Path object that is a subsequence of the name elements in this Path
      */
     @Override
     public Path subpath(int begin, int end) {
@@ -209,10 +251,21 @@ public Path subpath(int begin, int end) {
     }
 
     /**
+     * Tests if this path starts with the given path.
+     * <p>
+     * This path starts with the given path if this path's root component starts with the root component of the given
+     * path, and this path starts with the same name elements as the given path. If the given path has more name
+     * elements than this path then false is returned.
+     * <p>
+     * If this path does not have a root component and the given path has a root component then this path does not start
+     * with the given path.
+     * <p>
+     * If the given path is associated with a different FileSystem to this path then false is returned.
+     * <p>
      * In this implementation, a root component starts with another root component if the two root components are
      * equivalent strings. In other words, if the files are stored in the same container.
      *
-     * {@inheritDoc}
+     * @return true if this path starts with the given path; otherwise false
      */
     @Override
     public boolean startsWith(Path path) {
@@ -240,7 +293,11 @@ public boolean startsWith(Path path) {
     }
 
     /**
-     * {@inheritDoc}
+     * Tests if this path starts with a Path, constructed by converting the given path string, in exactly the manner
+     * specified by the startsWith(Path) method.
+     *
+     * @return true if this path starts with the given path; otherwise false
+     * @throws InvalidPathException If the path string cannot be converted to a Path.
      */
     @Override
     public boolean startsWith(String s) {
@@ -248,10 +305,23 @@ public boolean startsWith(String s) {
     }
 
     /**
+     * Tests if this path ends with the given path.
+     * <p>
+     * If the given path has N elements, and no root component, and this path has N or more elements, then this path
+     * ends with the given path if the last N elements of each path, starting at the element farthest from the root,
+     * are equal.
+     * <p>
+     * If the given path has a root component then this path ends with the given path if the root component of this path
+     * ends with the root component of the given path, and the corresponding elements of both paths are equal. If this
+     * path does not have a root component and the given path has a root component then this path does not end with the
+     * given path.
+     * <p>
+     * If the given path is associated with a different FileSystem to this path then false is returned.
+     * <p>
      * In this implementation, a root component ends with another root component if the two root components are
      * equivalent strings. In other words, if the files are stored in the same container.
      *
-     * {@inheritDoc}
+     * @return true if this path ends with the given path; otherwise false
      */
     @Override
     public boolean endsWith(Path path) {
@@ -287,7 +357,11 @@ public boolean endsWith(Path path) {
     }
 
     /**
-     * {@inheritDoc}
+     * Tests if this path ends with a Path, constructed by converting the given path string, in exactly the manner
+     * specified by the endsWith(Path) method.
+     *
+     * @return true if this path starts with the given path; otherwise false
+     * @throws InvalidPathException If the path string cannot be converted to a Path.
      */
     @Override
     public boolean endsWith(String s) {
@@ -295,9 +369,19 @@ public boolean endsWith(String s) {
     }
 
     /**
-     * This file system follows the standard practice mentioned in the original docs.
+     * Returns a path that is this path with redundant name elements eliminated.
+     * <p>
+     * It derives from this path, a path that does not contain redundant name elements. The "." and ".." are special
+     * names used to indicate the current directory and parent directory. All occurrences of "." are considered
+     * redundant. If a ".." is preceded by a non-".." name then both names are considered redundant (the process to
+     * identify such names is repeated until is it no longer applicable).
+     * <p>
+     * This method does not access the file system; the path may not locate a file that exists. Eliminating ".." and a
+     * preceding name from a path may result in the path that locates a different file than the original path
+     *
+     * @return the resulting path or this path if it does not contain redundant name elements; an empty path is returned
+     * if this path does have a root component and all name elements are redundant
      *
-     * {@inheritDoc}
      */
     @Override
     public Path normalize() {
@@ -336,9 +420,16 @@ public Path normalize() {
     }
 
     /**
-     * If the other path has a root component, it is considered absolute, and it is returned.
+     * Resolve the given path against this path.
+     * <p>
+     * If the other parameter is an absolute path then this method trivially returns other. If other is an empty path
+     * then this method trivially returns this path. Otherwise this method considers this path to be a directory and
+     * resolves the given path against this path. In the simplest case, the given path does not have a root component,
+     * in which case this method joins the given path to this path and returns a resulting path that ends with the given
+     * path. Where the given path has a root component then resolution is highly implementation dependent and therefore
+     * unspecified.
      *
-     * {@inheritDoc}
+     * @return the resulting path
      */
     @Override
     public Path resolve(Path path) {
@@ -352,7 +443,11 @@ public Path resolve(Path path) {
     }
 
     /**
-     * {@inheritDoc}
+     * Converts a given path string to a Path and resolves it against this Path in exactly the manner specified by the
+     * {@link #resolve(Path) resolve} method.
+     *
+     * @return the resulting path
+     * @throws InvalidPathException if the path string cannot be converted to a Path.
      */
     @Override
     public Path resolve(String s) {
@@ -360,7 +455,13 @@ public Path resolve(String s) {
     }
 
     /**
-     * {@inheritDoc}
+     * Resolves the given path against this path's parent path. This is useful where a file name needs to be replaced
+     * with another file name. For example, suppose that the name separator is "/" and a path represents
+     * "dir1/dir2/foo", then invoking this method with the Path "bar" will result in the Path "dir1/dir2/bar". If this
+     * path does not have a parent path, or other is absolute, then this method returns other. If other is an empty path
+     * then this method returns this path's parent, or where this path doesn't have a parent, the empty path.
+     *
+     * @return the resulting path
      */
     @Override
     public Path resolveSibling(Path path) {
@@ -373,7 +474,11 @@ public Path resolveSibling(Path path) {
     }
 
     /**
-     * {@inheritDoc}
+     * Converts a given path string to a Path and resolves it against this path's parent path in exactly the manner
+     * specified by the resolveSibling method.
+     *
+     * @return the resulting path
+     * @throws InvalidPathException if the path string cannot be converted to a Path.
      */
     @Override
     public Path resolveSibling(String s) {
@@ -381,9 +486,19 @@ public Path resolveSibling(String s) {
     }
 
     /**
-     * If both paths have a root component, it is still to relativize one against the other.
+     * Constructs a relative path between this path and a given path.
+     * <p>
+     * Relativization is the inverse of resolution. This method attempts to construct a relative path that when resolved
+     * against this path, yields a path that locates the same file as the given path.
+     * <p>
+     * A relative path cannot be constructed if only one of the paths have a root component. If both paths have a root
+     * component, it is still possible to relativize one against the other. If this path and the given path are equal then an empty path is returned.
+     * <p>
+     * For any two normalized paths p and q, where q does not have a root component,
+     *     {@code p.relativize(p.resolve(q)).equals(q)}
      *
-     * {@inheritDoc}
+     * @return the resulting relative path, or an empty path if both paths are equal
+     * @throws IllegalArgumentException if other is not a Path that can be relativized against this path
      */
     @Override
     public Path relativize(Path path) {
@@ -413,10 +528,15 @@ public Path relativize(Path path) {
     }
 
     /**
+     * Returns a URI to represent this path.
+     * <p>
+     * This method constructs an absolute URI with a scheme equal to the URI scheme that identifies the provider.
+     * <p>
      * No authority component is defined for the {@code URI} returned by this method. This implementation offers the
      * same equivalence guarantee as the default provider.
      *
-     * {@inheritDoc}
+     * @return the URI representing this path
+     * @throws SecurityException never
      */
     @Override
     public URI toUri() {
@@ -429,7 +549,13 @@ public URI toUri() {
     }
 
     /**
-     * {@inheritDoc}
+     * Returns a Path object representing the absolute path of this path.
+     * <p>
+     * If this path is already absolute then this method simply returns this path. Otherwise, this method resolves the
+     * path against the default directory.
+     *
+     * @return a Path object representing the absolute path
+     * @throws SecurityException never
      */
     @Override
     public Path toAbsolutePath() {
@@ -442,7 +568,8 @@ public Path toAbsolutePath() {
     /**
      * Unsupported.
      * <p>
-     * {@inheritDoc}
+     * @return the real path
+     * @throws UnsupportedOperationException operation not suported.
      */
     @Override
     public Path toRealPath(LinkOption... linkOptions) throws IOException {
@@ -450,7 +577,10 @@ public Path toRealPath(LinkOption... linkOptions) throws IOException {
     }
 
     /**
-     * {@inheritDoc}
+     * Unsupported.
+     * <p>
+     * @return the file
+     * @throws UnsupportedOperationException operation not suported.
      */
     @Override
     public File toFile() {
@@ -460,7 +590,8 @@ public File toFile() {
     /**
      * Unsupported.
      * <p>
-     * {@inheritDoc}
+     * @return the watch key
+     * @throws UnsupportedOperationException operation not suported.
      */
     @Override
     public WatchKey register(WatchService watchService, WatchEvent.Kind<?>[] kinds, WatchEvent.Modifier... modifiers)
@@ -471,7 +602,8 @@ public WatchKey register(WatchService watchService, WatchEvent.Kind<?>[] kinds,
     /**
      * Unsupported.
      * <p>
-     * {@inheritDoc}
+     * @return the watch key
+     * @throws UnsupportedOperationException operation not suported.
      */
     @Override
     public WatchKey register(WatchService watchService, WatchEvent.Kind<?>... kinds) throws IOException {
@@ -479,9 +611,13 @@ public WatchKey register(WatchService watchService, WatchEvent.Kind<?>... kinds)
     }
 
     /**
-     * Unsupported
+     * Returns an iterator over the name elements of this path.
      * <p>
-     * {@inheritDoc}
+     * The first element returned by the iterator represents the name element that is closest to the root in the
+     * directory hierarchy, the second element is the next closest, and so on. The last element returned is the name of
+     * the file or directory denoted by this path. The root component, if present, is not returned by the iterator.
+     *
+     * @return an iterator over the name elements of this path.
      */
     @Override
     public Iterator<Path> iterator() {
@@ -495,9 +631,16 @@ public Iterator<Path> iterator() {
     }
 
     /**
+     * Compares two abstract paths lexicographically. This method does not access the file system and neither file is
+     * required to exist.
+     * <p>
+     * This method may not be used to compare paths that are associated with different file system providers.
+     * <p>
      * This result of this method is identical to a string comparison on the underlying path strings.
      *
-     * {@inheritDoc}
+     * @return zero if the argument is equal to this path, a value less than zero if this path is lexicographically less
+     * than the argument, or a value greater than zero if this path is lexicographically greater than the argument
+     * @throws ClassCastException if the paths are associated with different providers
      */
     @Override
     public int compareTo(Path path) {
@@ -510,7 +653,14 @@ public int compareTo(Path path) {
     }
 
     /**
-     * {@inheritDoc}
+     * Returns the string representation of this path.
+     * <p>
+     * If this path was created by converting a path string using the getPath method then the path string returned by
+     * this method may differ from the original String used to create the path.
+     * <p>
+     * The returned path string uses the default name separator to separate names in the path.
+     *
+     * @return the string representation of this path
      */
     @Override
     public String toString() {
@@ -521,7 +671,7 @@ public String toString() {
      * A path is considered equal to another path if it is associated with the same file system instance and if the
      * path strings are equivalent.
      *
-     * {@inheritDoc}
+     * @return true if, and only if, the given object is a Path that is identical to this Path
      */
     @Override
     public boolean equals(Object o) {

From 6f10416a313e1074444a45fa96dad89736dd1b08 Mon Sep 17 00:00:00 2001
From: Rick Ley <frley@microsoft.com>
Date: Tue, 14 Jul 2020 15:12:42 -0700
Subject: [PATCH 3/5] Added docs for all parameters passed to methods

---
 .../blob/nio/AzureBasicFileAttributeView.java |  3 +
 .../blob/nio/AzureBlobFileAttributeView.java  |  5 +-
 .../storage/blob/nio/AzureFileStore.java      | 12 ++-
 .../storage/blob/nio/AzureFileSystem.java     | 13 ++--
 .../blob/nio/AzureFileSystemProvider.java     | 77 ++++++++++++++-----
 .../com/azure/storage/blob/nio/AzurePath.java | 42 +++++++---
 6 files changed, 112 insertions(+), 40 deletions(-)

diff --git a/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureBasicFileAttributeView.java b/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureBasicFileAttributeView.java
index 2b855cb4aedc..338c95b1b641 100644
--- a/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureBasicFileAttributeView.java
+++ b/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureBasicFileAttributeView.java
@@ -52,6 +52,9 @@ public AzureBasicFileAttributes readAttributes() throws IOException {
     /**
      * Unsupported.
      *
+     * @param lastModifiedTime the new last modified time, or null to not change the value
+     * @param lastAccessTime the last access time, or null to not change the value
+     * @param createTime the file's create time, or null to not change the value
      * @throws UnsupportedOperationException Operation not supported.
      * @throws IOException never
      */
diff --git a/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureBlobFileAttributeView.java b/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureBlobFileAttributeView.java
index 1bd14b5168b7..3162309752a0 100644
--- a/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureBlobFileAttributeView.java
+++ b/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureBlobFileAttributeView.java
@@ -140,11 +140,14 @@ public void setTier(AccessTier tier) throws IOException {
     /**
      * Unsupported.
      *
+     * @param lastModifiedTime the new last modified time, or null to not change the value
+     * @param lastAccessTime the last access time, or null to not change the value
+     * @param createTime the file's create time, or null to not change the value
      * @throws UnsupportedOperationException Operation not supported.
      * @throws IOException never
      */
     @Override
-    public void setTimes(FileTime fileTime, FileTime fileTime1, FileTime fileTime2) throws IOException {
+    public void setTimes(FileTime lastModifiedTime, FileTime lastAccessTime, FileTime createTime) throws IOException {
         throw new UnsupportedOperationException();
     }
 }
diff --git a/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureFileStore.java b/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureFileStore.java
index 4b4011bb20c5..8495b7d334d1 100644
--- a/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureFileStore.java
+++ b/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureFileStore.java
@@ -129,11 +129,12 @@ public long getUnallocatedSpace() throws IOException {
      *     <li>{@link AzureBlobFileAttributeView}</li>
      * </ul>
      *
+     * @param type the file attribute view type
      * @return Whether the file attribute view is supported.
      */
     @Override
-    public boolean supportsFileAttributeView(Class<? extends FileAttributeView> aClass) {
-        return AzureFileSystem.SUPPORTED_ATTRIBUTE_VIEWS.containsKey(aClass);
+    public boolean supportsFileAttributeView(Class<? extends FileAttributeView> type) {
+        return AzureFileSystem.SUPPORTED_ATTRIBUTE_VIEWS.containsKey(type);
     }
 
     /**
@@ -146,11 +147,12 @@ public boolean supportsFileAttributeView(Class<? extends FileAttributeView> aCla
      *     <li>{@link AzureBlobFileAttributeView}</li>
      * </ul>
      *
+     * @param name the name of the file attribute view
      * @return whether the file attribute view is supported.
      */
     @Override
-    public boolean supportsFileAttributeView(String s) {
-        return AzureFileSystem.SUPPORTED_ATTRIBUTE_VIEWS.containsValue(s);
+    public boolean supportsFileAttributeView(String name) {
+        return AzureFileSystem.SUPPORTED_ATTRIBUTE_VIEWS.containsValue(name);
     }
 
     /**
@@ -158,6 +160,7 @@ public boolean supportsFileAttributeView(String s) {
      * <p>
      * This method always returns null as no {@link FileStoreAttributeView} is currently supported.
      *
+     * @param aClass a class
      * @return null
      */
     @Override
@@ -171,6 +174,7 @@ public <V extends FileStoreAttributeView> V getFileStoreAttributeView(Class<V> a
      * This method always throws an {@code UnsupportedOperationException} as no {@link FileStoreAttributeView} is
      * currently supported.
      *
+     * @param s a string
      * @return The attribute value.
      * @throws UnsupportedOperationException unsupported
      * @throws IOException never
diff --git a/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureFileSystem.java b/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureFileSystem.java
index 203199103e5c..ce5a30893ca5 100644
--- a/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureFileSystem.java
+++ b/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureFileSystem.java
@@ -317,30 +317,33 @@ public Set<String> supportedFileAttributeViews() {
     }
 
     /**
-     * Converts a path string, or a sequence of strings that when joined form a path string, to a Path.
+     * Converts a path string, or a sequence of more that when joined form a path string, to a Path.
      * <p>
      * If more does not specify any elements then the value of the first parameter is the path string to convert. If
      * more specifies one or more elements then each non-empty string, including first, is considered to be a sequence
-     * of name elements (see Path) and is joined to form a path string. The strings will be joined using the name
+     * of name elements (see Path) and is joined to form a path string. The more will be joined using the name
      * separator.
      * <p>
-     * Each name element will be {@code String}-joined to the other elements by this file system's path separator.
+     * Each name element will be {@code String}-joined to the other elements by this file system'first path separator.
      * Naming conventions and allowed characters are as
      * <a href="https://docs.microsoft.com/en-us/rest/api/storageservices/Naming-and-Referencing-Containers--Blobs--and-Metadata">defined</a>
      * by the Azure Blob Storage service. The root component is interpreted as the container name and all name elements
      * are interpreted as a part of the blob name. The character {@code ':'} is only allowed in the root component and
      * must be the last character of the root component.
      *
+     * @param first the path string or initial part of the path string
+     * @param more additional strings to be joined to form the path string
      * @throws InvalidPathException if the path string cannot be converted.
      */
     @Override
-    public Path getPath(String s, String... strings) {
-        return new AzurePath(this, s, strings);
+    public Path getPath(String first, String... more) {
+        return new AzurePath(this, first, more);
     }
 
     /**
      * Unsupported.
      *
+     * @param s the matcher
      * @throws UnsupportedOperationException unsupported.
      * @throws IllegalArgumentException never
      * @throws PatternSyntaxException never
diff --git a/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureFileSystemProvider.java b/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureFileSystemProvider.java
index 2b0254e2c274..425359ae4643 100644
--- a/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureFileSystemProvider.java
+++ b/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureFileSystemProvider.java
@@ -186,6 +186,8 @@ public String getScheme() {
      * <p>
      * Once closed, a file system with the same identifier may be reopened.
      *
+     * @param uri URI reference
+     * @param config A map of provider specific properties to configure the file system
      * @return a new file system.
      * @throws IllegalArgumentException If the pre-conditions for the uri parameter aren't met, or the env parameter
      * does not contain properties required by the provider, or a property value is invalid.
@@ -215,6 +217,7 @@ public FileSystem newFileSystem(URI uri, Map<String, ?> config) throws IOExcepti
      * Trying to retrieve a closed file system will throw a {@link FileSystemNotFoundException}. Once closed, a
      * file system with the same identifier may be reopened.
      *
+     * @param uri URI reference
      * @return the file system
      * @throws IllegalArgumentException If the pre-conditions for the uri parameter aren't met
      * @throws FileSystemNotFoundException If the file system already exists
@@ -233,6 +236,7 @@ public FileSystem getFileSystem(URI uri) {
      * Return a Path object by converting the given URI. The resulting Path is associated with a FileSystem that already
      * exists.
      *
+     * @param uri The URI to convert
      * @return The path identified by the URI.
      * @throws IllegalArgumentException If the URI scheme does not identify this provider or other preconditions on the
      * uri parameter do not hold
@@ -250,7 +254,10 @@ public Path getPath(URI uri) {
      * Unsupported. Use {@link #newInputStream(Path, OpenOption...)} or {@link #newOutputStream(Path, OpenOption...)}
      * instead.
      *
-     * @returns a new seekable byte channel
+     * @param path the Path
+     * @param set open options
+     * @param fileAttributes attributes
+     * @return a new seekable byte channel
      * @throws UnsupportedOperationException Operation is not supported.
      * @throws IllegalArgumentException if the set contains an invalid combination of options
      * @throws FileAlreadyExistsException  if a file of that name already exists and the CREATE_NEW option is specified
@@ -273,6 +280,8 @@ public SeekableByteChannel newByteChannel(Path path, Set<? extends OpenOption> s
      * <p>
      * Only {@link StandardOpenOption#READ} is supported. Any other option will throw.
      *
+     * @param path the path to the file to open
+     * @param options options specifying how the file is opened
      * @return a new input stream
      * @throws IllegalArgumentException if an invalid combination of options is specified
      * @throws UnsupportedOperationException if an unsupported option is specified
@@ -327,6 +336,8 @@ public InputStream newInputStream(Path path, OpenOption... options) throws IOExc
      * This can be a useful tool because writing happens asynchronously, and therefore an error from a previous write
      * may not otherwise be thrown unless the stream is flushed, closed, or written to again.
      *
+     * @param path the path to the file to open or create
+     * @param options options specifying how the file is opened
      * @return a new output stream
      * @throws IllegalArgumentException if an invalid combination of options is specified
      * @throws UnsupportedOperationException if an unsupported option is specified
@@ -416,6 +427,8 @@ public OutputStream newOutputStream(Path path, OpenOption... options) throws IOE
      * next method. Where an IOException is thrown, it results in the hasNext or next method throwing a
      * DirectoryIteratorException with the IOException as the cause.
      *
+     * @param path the path to the directory
+     * @param filter the directory stream filter
      * @return a new and open {@code DirectoryStream} object
      * @throws IllegalArgumentException If the path type is not an instance of {@link AzurePath}.
      * @throws NotDirectoryException if the file could not otherwise be opened because it is not a directory
@@ -497,6 +510,8 @@ public DirectoryStream<Path> newDirectoryStream(Path path, DirectoryStream.Filte
      * <a href="https://docs.microsoft.com/en-us/rest/api/storageservices/set-blob-properties">Azure Docs</a> for more
      * information.
      *
+     * @param path the directory to create
+     * @param fileAttributes an optional list of file attributes to set atomically when creating the directory
      * @throws IllegalArgumentException If the path type is not an instance of {@link AzurePath}.
      * @throws UnsupportedOperationException if the array contains an attribute that cannot be set atomically when
      * creating the directory
@@ -540,6 +555,7 @@ public void createDirectory(Path path, FileAttribute<?>... fileAttributes) throw
      * another process, and doing so will not immediately invalidate any channels open to that file--they will simply
      * start to fail. Root directories cannot be deleted even when empty.
      *
+     * @param path the path to the file to delete
      * @throws IllegalArgumentException If the path type is not an instance of {@link AzurePath}.
      * @throws NoSuchFileException if the file does not exist
      * @throws DirectoryNotEmptyException if the file is a directory and could not otherwise be deleted because the
@@ -594,6 +610,9 @@ public void delete(Path path) throws IOException {
      * This is in order to prevent the possibility of overwriting a non-empty virtual directory with a file. Still, as
      * mentioned above, this check is not atomic with the creation of the resultant directory.
      *
+     * @param source the path to the file to copy
+     * @param destination the path to the target file
+     * @param options specifying how the copy should be done
      * @throws UnsupportedOperationException if the array contains a copy option that is not supported
      * @throws FileAlreadyExistsException if the target file exists but cannot be replaced because the REPLACE_EXISTING
      * option is not specified
@@ -708,6 +727,9 @@ public void copy(Path source, Path destination, CopyOption... copyOptions) throw
     /**
      * Unsupported.
      *
+     * @param path path
+     * @param path1 path
+     * @param copyOptions options
      * @throws UnsupportedOperationException Operation is not supported.
      */
     @Override
@@ -718,6 +740,8 @@ public void move(Path path, Path path1, CopyOption... copyOptions) throws IOExce
     /**
      * Unsupported.
      *
+     * @param path path
+     * @param path1 path
      * @throws UnsupportedOperationException Operation is not supported.
      */
     @Override
@@ -728,6 +752,7 @@ public boolean isSameFile(Path path, Path path1) throws IOException {
     /**
      * Always returns false as hidden files are not supported.
      *
+     * @param path the path
      * @return false
      * @throws IOException If an I/O error occurs.
      * @throws SecurityException never
@@ -740,6 +765,7 @@ public boolean isHidden(Path path) throws IOException {
     /**
      * Unsupported.
      *
+     * @param path path
      * @return the file store where the file is stored.
      * @throws UnsupportedOperationException Operation is not supported.
      * @throws IOException If an I/O error occurs.
@@ -753,6 +779,8 @@ public FileStore getFileStore(Path path) throws IOException {
     /**
      * Unsupported.
      *
+     * @param path path
+     * @param accessModes accessMode
      * @throws UnsupportedOperationException Operation is not supported.
      * @throws NoSuchFileException if a file does not exist
      * @throws java.nio.file.AccessDeniedException the requested access would be denied or the access cannot be
@@ -773,18 +801,21 @@ public void checkAccess(Path path, AccessMode... accessModes) throws IOException
      * Reading or setting attributes on a virtual directory is not supported and will throw an {@link IOException}. See
      * {@link #createDirectory(Path, FileAttribute[])} for more information on virtual directories.
      *
+     * @param path the path to the file
+     * @param type the Class object corresponding to the file attribute view
+     * @param linkOptions ignored
      * @return a file attribute view of the specified type, or null if the attribute view type is not available
      */
     @Override
     @SuppressWarnings("unchecked")
-    public <V extends FileAttributeView> V getFileAttributeView(Path path, Class<V> aClass, LinkOption... linkOptions) {
+    public <V extends FileAttributeView> V getFileAttributeView(Path path, Class<V> type, LinkOption... linkOptions) {
         /*
         No resource validation is necessary here. That can happen at the time of making a network requests internal to
         the view object.
          */
-        if (aClass == BasicFileAttributeView.class || aClass == AzureBasicFileAttributeView.class) {
+        if (type == BasicFileAttributeView.class || type == AzureBasicFileAttributeView.class) {
             return (V) new AzureBasicFileAttributeView(path);
-        } else if (aClass == AzureBlobFileAttributeView.class) {
+        } else if (type == AzureBlobFileAttributeView.class) {
             return (V) new AzureBlobFileAttributeView(path);
         } else {
             return null;
@@ -799,6 +830,9 @@ public <V extends FileAttributeView> V getFileAttributeView(Path path, Class<V>
      * Reading attributes on a virtual directory is not supported and will throw an {@link IOException}. See
      * {@link #createDirectory(Path, FileAttribute[])} for more information on virtual directories.
      *
+     * @param path the path to the file
+     * @param type the Class of the file attributes required to read
+     * @param linkOptions ignored
      * @return the file attributes
      * @throws UnsupportedOperationException if an attributes of the given type are not supported
      * @throws IOException If an I/O error occurs.
@@ -806,12 +840,12 @@ public <V extends FileAttributeView> V getFileAttributeView(Path path, Class<V>
      */
     @Override
     @SuppressWarnings("unchecked")
-    public <A extends BasicFileAttributes> A readAttributes(Path path, Class<A> aClass, LinkOption... linkOptions)
+    public <A extends BasicFileAttributes> A readAttributes(Path path, Class<A> type, LinkOption... linkOptions)
         throws IOException {
         Class<? extends BasicFileAttributeView> view;
-        if (aClass == BasicFileAttributes.class || aClass == AzureBasicFileAttributes.class) {
+        if (type == BasicFileAttributes.class || type == AzureBasicFileAttributes.class) {
             view = AzureBasicFileAttributeView.class;
-        } else if (aClass == AzureBlobFileAttributes.class) {
+        } else if (type == AzureBlobFileAttributes.class) {
             view = AzureBlobFileAttributeView.class;
         } else {
             throw new UnsupportedOperationException();
@@ -832,6 +866,9 @@ public <A extends BasicFileAttributes> A readAttributes(Path path, Class<A> aCla
      * Reading attributes on a virtual directory is not supported and will throw an {@link IOException}. See
      * {@link #createDirectory(Path, FileAttribute[])} for more information on virtual directories.
      *
+     * @param path the path to the file
+     * @param attributes the attributes to read
+     * @param linkOptions ignored
      * @return a map of the attributes returned; may be empty. The map's keys are the attribute names, its values are
      * the attribute values
      * @throws UnsupportedOperationException if an attributes of the given type are not supported
@@ -840,8 +877,8 @@ public <A extends BasicFileAttributes> A readAttributes(Path path, Class<A> aCla
      * @throws SecurityException never
      */
     @Override
-    public Map<String, Object> readAttributes(Path path, String s, LinkOption... linkOptions) throws IOException {
-        if (s == null) {
+    public Map<String, Object> readAttributes(Path path, String attributes, LinkOption... linkOptions) throws IOException {
+        if (attributes == null) {
             throw LoggingUtility.logError(logger, new IllegalArgumentException("Attribute string cannot be null."));
         }
 
@@ -856,16 +893,16 @@ public Map<String, Object> readAttributes(Path path, String s, LinkOption... lin
         Map<String, Supplier<Object>> attributeSuppliers = null; // Initialized later as needed.
         String viewType;
         String attributeList;
-        String[] parts = s.split(":");
+        String[] parts = attributes.split(":");
 
         if (parts.length > 2) {
             throw LoggingUtility.logError(logger,
-                new IllegalArgumentException("Invalid format for attribute string: " + s));
+                new IllegalArgumentException("Invalid format for attribute string: " + attributes));
         }
 
         if (parts.length == 1) {
             viewType = "basic"; // Per jdk docs.
-            attributeList = s;
+            attributeList = attributes;
         } else {
             viewType = parts[0];
             attributeList = parts[1];
@@ -932,7 +969,7 @@ public Map<String, Object> readAttributes(Path path, String s, LinkOption... lin
         // Throw if nothing specified per jdk docs.
         if (results.isEmpty()) {
             throw LoggingUtility.logError(logger,
-                new IllegalArgumentException("No attributes were specified. Attributes: " + s));
+                new IllegalArgumentException("No attributes were specified. Attributes: " + attributes));
         }
 
         return results;
@@ -946,6 +983,10 @@ public Map<String, Object> readAttributes(Path path, String s, LinkOption... lin
      * Setting attributes on a virtual directory is not supported and will throw an {@link IOException}. See
      * {@link #createDirectory(Path, FileAttribute[])} for more information on virtual directories.
      *
+     * @param path the path to the file
+     * @param attributes the attribute to set
+     * @param value the attribute value
+     * @param linkOptions ignored
      * @throws UnsupportedOperationException if an attribute view is not available
      * @throws IllegalArgumentException if the attribute name is not specified, or is not recognized, or the attribute
      * value is of the correct type but has an inappropriate value
@@ -955,17 +996,17 @@ public Map<String, Object> readAttributes(Path path, String s, LinkOption... lin
      * @throws SecurityException never
      */
     @Override
-    public void setAttribute(Path path, String s, Object o, LinkOption... linkOptions) throws IOException {
+    public void setAttribute(Path path, String attributes, Object value, LinkOption... linkOptions) throws IOException {
         String viewType;
         String attributeName;
-        String[] parts = s.split(":");
+        String[] parts = attributes.split(":");
         if (parts.length > 2) {
             throw LoggingUtility.logError(logger,
-                new IllegalArgumentException("Invalid format for attribute string: " + s));
+                new IllegalArgumentException("Invalid format for attribute string: " + attributes));
         }
         if (parts.length == 1) {
             viewType = "basic"; // Per jdk docs.
-            attributeName = s;
+            attributeName = attributes;
         } else {
             viewType = parts[0];
             attributeName = parts[1];
@@ -994,7 +1035,7 @@ public void setAttribute(Path path, String s, Object o, LinkOption... linkOption
                         + ". Attribute: " + attributeName));
             }
             try {
-                attributeConsumers.get(attributeName).accept(o);
+                attributeConsumers.get(attributeName).accept(value);
             } catch (UncheckedIOException e) {
                 if (e.getMessage().equals(AzureBlobFileAttributeView.ATTR_CONSUMER_ERROR)) {
                     throw LoggingUtility.logError(logger, e.getCause());
diff --git a/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzurePath.java b/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzurePath.java
index 7cd0e2330b1e..8733ead2d7a2 100644
--- a/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzurePath.java
+++ b/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzurePath.java
@@ -203,15 +203,16 @@ public int getNameCount() {
      * The index parameter is the index of the name element to return. The element that is closest to the root in the
      * directory hierarchy has index 0. The element that is farthest from the root has index {@code count-1}.
      *
+     * @param the index of the element
      * @return the name element
      * @throws IllegalArgumentException if index is negative, index is greater than or equal to the number of elements,
      * or this path has zero name elements
      */
     @Override
-    public Path getName(int i) {
-        if (i < 0 || i >= this.getNameCount()) {
+    public Path getName(int index) {
+        if (index < 0 || index >= this.getNameCount()) {
             throw LoggingUtility.logError(logger, new IllegalArgumentException(String.format("Index %d is out of "
-                + "bounds", i)));
+                + "bounds", index)));
         }
         // If the path is empty, the only valid option is also an empty path.
         if (this.pathString.isEmpty()) {
@@ -221,7 +222,7 @@ public Path getName(int i) {
         if (this.pathString.isEmpty()) {
             return this;
         }
-        return this.parentFileSystem.getPath(this.splitToElements(this.withoutRoot())[i]);
+        return this.parentFileSystem.getPath(this.splitToElements(this.withoutRoot())[index]);
     }
 
     /**
@@ -232,6 +233,8 @@ public Path getName(int i) {
      * The returned Path object has the name elements that begin at beginIndex and extend to the element at index
      * {@code endIndex-1}.
      *
+     * @param begin the index of the first element, inclusive
+     * @param end the index of the last element, exclusive
      * @return a new Path object that is a subsequence of the name elements in this Path
      */
     @Override
@@ -265,6 +268,7 @@ public Path subpath(int begin, int end) {
      * In this implementation, a root component starts with another root component if the two root components are
      * equivalent strings. In other words, if the files are stored in the same container.
      *
+     * @param path the given path
      * @return true if this path starts with the given path; otherwise false
      */
     @Override
@@ -296,12 +300,13 @@ public boolean startsWith(Path path) {
      * Tests if this path starts with a Path, constructed by converting the given path string, in exactly the manner
      * specified by the startsWith(Path) method.
      *
+     * @param path the given path string
      * @return true if this path starts with the given path; otherwise false
      * @throws InvalidPathException If the path string cannot be converted to a Path.
      */
     @Override
-    public boolean startsWith(String s) {
-        return this.startsWith(this.parentFileSystem.getPath(s));
+    public boolean startsWith(String path) {
+        return this.startsWith(this.parentFileSystem.getPath(path));
     }
 
     /**
@@ -321,6 +326,7 @@ public boolean startsWith(String s) {
      * In this implementation, a root component ends with another root component if the two root components are
      * equivalent strings. In other words, if the files are stored in the same container.
      *
+     * @param path the given path
      * @return true if this path ends with the given path; otherwise false
      */
     @Override
@@ -360,12 +366,13 @@ public boolean endsWith(Path path) {
      * Tests if this path ends with a Path, constructed by converting the given path string, in exactly the manner
      * specified by the endsWith(Path) method.
      *
+     * @param path the given path string
      * @return true if this path starts with the given path; otherwise false
      * @throws InvalidPathException If the path string cannot be converted to a Path.
      */
     @Override
-    public boolean endsWith(String s) {
-        return this.endsWith(this.parentFileSystem.getPath(s));
+    public boolean endsWith(String path) {
+        return this.endsWith(this.parentFileSystem.getPath(path));
     }
 
     /**
@@ -429,6 +436,7 @@ public Path normalize() {
      * path. Where the given path has a root component then resolution is highly implementation dependent and therefore
      * unspecified.
      *
+     * @param path the path to resolve against this path
      * @return the resulting path
      */
     @Override
@@ -446,12 +454,13 @@ public Path resolve(Path path) {
      * Converts a given path string to a Path and resolves it against this Path in exactly the manner specified by the
      * {@link #resolve(Path) resolve} method.
      *
+     * @param path the path string to resolve against this path
      * @return the resulting path
      * @throws InvalidPathException if the path string cannot be converted to a Path.
      */
     @Override
-    public Path resolve(String s) {
-        return this.resolve(this.parentFileSystem.getPath(s));
+    public Path resolve(String path) {
+        return this.resolve(this.parentFileSystem.getPath(path));
     }
 
     /**
@@ -461,6 +470,7 @@ public Path resolve(String s) {
      * path does not have a parent path, or other is absolute, then this method returns other. If other is an empty path
      * then this method returns this path's parent, or where this path doesn't have a parent, the empty path.
      *
+     * @param path the path to resolve against this path's parent
      * @return the resulting path
      */
     @Override
@@ -477,12 +487,13 @@ public Path resolveSibling(Path path) {
      * Converts a given path string to a Path and resolves it against this path's parent path in exactly the manner
      * specified by the resolveSibling method.
      *
+     * @param path the path string to resolve against this path's parent
      * @return the resulting path
      * @throws InvalidPathException if the path string cannot be converted to a Path.
      */
     @Override
-    public Path resolveSibling(String s) {
-        return this.resolveSibling(this.parentFileSystem.getPath(s));
+    public Path resolveSibling(String path) {
+        return this.resolveSibling(this.parentFileSystem.getPath(path));
     }
 
     /**
@@ -497,6 +508,7 @@ public Path resolveSibling(String s) {
      * For any two normalized paths p and q, where q does not have a root component,
      *     {@code p.relativize(p.resolve(q)).equals(q)}
      *
+     * @param path the path to relativize against this path
      * @return the resulting relative path, or an empty path if both paths are equal
      * @throws IllegalArgumentException if other is not a Path that can be relativized against this path
      */
@@ -568,6 +580,7 @@ public Path toAbsolutePath() {
     /**
      * Unsupported.
      * <p>
+     * @param linkOptions options
      * @return the real path
      * @throws UnsupportedOperationException operation not suported.
      */
@@ -590,6 +603,9 @@ public File toFile() {
     /**
      * Unsupported.
      * <p>
+     * @param watchService watchService
+     * @param kinds kinds
+     * @param modifiers modifiers
      * @return the watch key
      * @throws UnsupportedOperationException operation not suported.
      */
@@ -602,6 +618,8 @@ public WatchKey register(WatchService watchService, WatchEvent.Kind<?>[] kinds,
     /**
      * Unsupported.
      * <p>
+     * @param watchService watchService
+     * @param kinds kinds
      * @return the watch key
      * @throws UnsupportedOperationException operation not suported.
      */

From 2bc6323214b26128c52b6b4b4273edd2baa1acff Mon Sep 17 00:00:00 2001
From: Rick Ley <frley@microsoft.com>
Date: Tue, 14 Jul 2020 15:41:46 -0700
Subject: [PATCH 4/5] Small fixes

---
 .../com/azure/storage/blob/nio/AzureFileSystemProvider.java     | 2 +-
 .../src/main/java/com/azure/storage/blob/nio/AzurePath.java     | 2 +-
 .../azure/storage/blob/nio/AzureFileSystemProviderTest.groovy   | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureFileSystemProvider.java b/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureFileSystemProvider.java
index 425359ae4643..14ea76aeb430 100644
--- a/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureFileSystemProvider.java
+++ b/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureFileSystemProvider.java
@@ -612,7 +612,7 @@ public void delete(Path path) throws IOException {
      *
      * @param source the path to the file to copy
      * @param destination the path to the target file
-     * @param options specifying how the copy should be done
+     * @param copyOptions specifying how the copy should be done
      * @throws UnsupportedOperationException if the array contains a copy option that is not supported
      * @throws FileAlreadyExistsException if the target file exists but cannot be replaced because the REPLACE_EXISTING
      * option is not specified
diff --git a/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzurePath.java b/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzurePath.java
index 8733ead2d7a2..665c76d217de 100644
--- a/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzurePath.java
+++ b/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzurePath.java
@@ -203,7 +203,7 @@ public int getNameCount() {
      * The index parameter is the index of the name element to return. The element that is closest to the root in the
      * directory hierarchy has index 0. The element that is farthest from the root has index {@code count-1}.
      *
-     * @param the index of the element
+     * @param index the index of the element
      * @return the name element
      * @throws IllegalArgumentException if index is negative, index is greater than or equal to the number of elements,
      * or this path has zero name elements
diff --git a/sdk/storage/azure-storage-blob-nio/src/test/java/com/azure/storage/blob/nio/AzureFileSystemProviderTest.groovy b/sdk/storage/azure-storage-blob-nio/src/test/java/com/azure/storage/blob/nio/AzureFileSystemProviderTest.groovy
index 59b5c9737b86..6a1849737905 100644
--- a/sdk/storage/azure-storage-blob-nio/src/test/java/com/azure/storage/blob/nio/AzureFileSystemProviderTest.groovy
+++ b/sdk/storage/azure-storage-blob-nio/src/test/java/com/azure/storage/blob/nio/AzureFileSystemProviderTest.groovy
@@ -1064,7 +1064,7 @@ class AzureFileSystemProviderTest extends APISpec {
         "*"                                              || ["lastModifiedTime", "creationTime", "isRegularFile", "isDirectory", "isSymbolicLink", "isOther", "size"]
         "basic:*"                                        || ["lastModifiedTime", "creationTime", "isRegularFile", "isDirectory", "isSymbolicLink", "isOther", "size"]
         "azureBasic:*"                                   || ["lastModifiedTime", "creationTime", "isRegularFile", "isDirectory", "isSymbolicLink", "isOther", "size"]
-        "azureBlob:*"                                    || ["lastModifiedTime", "creationTime", "eTag", "blobHttpHeaders", "blobType", "copyId", "copyStatus", "copySource", "copyProgress", "copyCompletionTime", "copyStatusDescription", "isServerEncrypted", "accessTier", "isAccessTierInferred", "archiveStatus", "accessTierChangeTime", "metadata", "committedBlockCount", "isRegularFile", "isDirectory", "isSymbolicLink", "isOther", "size"]
+        "azureBlob:*"                                    || ["lastModifiedTime", "creationTime", "eTag", "blobHttpHeaders", "blobType", "copyId", "copyStatus", "copySource", "copyProgress", "copyCompletionTime", "copyStatusDescription", "isServerEncrypted", "accessTier", "isAccessTierInferred", "archiveStatus", "accessTierChangeTime", "metadata", "isRegularFile", "isDirectory", "isSymbolicLink", "isOther", "size"]
         "lastModifiedTime,creationTime"                  || ["lastModifiedTime", "creationTime"]
         "basic:isRegularFile,isDirectory"                || ["isRegularFile", "isDirectory"]
         "azureBasic:size"                                || ["size"]

From 2d65dd5c0b95427553ad82009e9f0b98de3907e3 Mon Sep 17 00:00:00 2001
From: Rick Ley <frley@microsoft.com>
Date: Tue, 14 Jul 2020 16:53:47 -0700
Subject: [PATCH 5/5] CI

---
 sdk/storage/azure-storage-blob-nio/README.md  | 22 +++++++++----------
 .../storage/blob/nio/AzureFileSystem.java     |  2 +-
 .../blob/nio/AzureFileSystemProvider.java     |  5 +++--
 .../com/azure/storage/blob/nio/AzurePath.java |  3 ++-
 4 files changed, 17 insertions(+), 15 deletions(-)

diff --git a/sdk/storage/azure-storage-blob-nio/README.md b/sdk/storage/azure-storage-blob-nio/README.md
index 7b5513b7d935..e8f77faadb0a 100644
--- a/sdk/storage/azure-storage-blob-nio/README.md
+++ b/sdk/storage/azure-storage-blob-nio/README.md
@@ -146,7 +146,7 @@ Create a `FileSystem` using the [`shared key`](#get-credentials) retrieved above
 Note that you can further configure the file system using constants available in `AzureFileSystem`.
 Please see the docs for `AzureFileSystemProvider` for a full explanation of initializing and configuring a filesystem
 
-<!-- embedme ./src/samples/java/com/azure/storage/blob/nio/ReadmeSamples.java#L39-L42 -->
+<!-- embedme ./src/samples/java/com/azure/storage/blob/nio/ReadmeSamples.java#L39-L43 -->
 ```java
 Map<String, Object> config = new HashMap<>();
 String[] stores = {"<your_container_name", "another_container_name"}; // Any iterable is acceptable
@@ -159,7 +159,7 @@ FileSystem myFs = FileSystems.newFileSystem(new URI("azb://?account=<your_accoun
 
 Create a directory using the `Files` api
 
-<!-- embedme ./src/samples/java/com/azure/storage/blob/nio/ReadmeSamples.java#L46-L47 -->
+<!-- embedme ./src/samples/java/com/azure/storage/blob/nio/ReadmeSamples.java#L47-L48 -->
 ```java
 Path dirPath = myFs.getPath("dir");
 Files.createDirectory(dirPath);
@@ -169,7 +169,7 @@ Files.createDirectory(dirPath);
 
 Iterate over a directory using a `DirectoryStream`
 
-<!-- embedme ./src/samples/java/com/azure/storage/blob/nio/ReadmeSamples.java#L51-L53 -->
+<!-- embedme ./src/samples/java/com/azure/storage/blob/nio/ReadmeSamples.java#L52-L54 -->
 ```java
 for (Path p : Files.newDirectoryStream(dirPath)) {
     System.out.println(p.toString());
@@ -180,7 +180,7 @@ for (Path p : Files.newDirectoryStream(dirPath)) {
 
 Read the contents of a file using an `InputStream`. Skipping, marking, and resetting are all supported.
 
-<!-- embedme ./src/samples/java/com/azure/storage/blob/nio/ReadmeSamples.java#L57-L60 -->
+<!-- embedme ./src/samples/java/com/azure/storage/blob/nio/ReadmeSamples.java#L58-L61 -->
 ```java
 Path filePath = myFs.getPath("file");
 InputStream is = Files.newInputStream(filePath);
@@ -193,7 +193,7 @@ is.close();
 Write to a file. Only writing whole files is supported. Random IO is not supported. The stream must be closed in order 
 to guarantee that the data is available to be read.
 
-<!-- embedme ./src/samples/java/com/azure/storage/blob/nio/ReadmeSamples.java#L64-L66 -->
+<!-- embedme ./src/samples/java/com/azure/storage/blob/nio/ReadmeSamples.java#L65-L67 -->
 ```java
 OutputStream os = Files.newOutputStream(filePath);
 os.write(0);
@@ -202,7 +202,7 @@ os.close();
 
 ### Copy a file
 
-<!-- embedme ./src/samples/java/com/azure/storage/blob/nio/ReadmeSamples.java#L70-L71 -->
+<!-- embedme ./src/samples/java/com/azure/storage/blob/nio/ReadmeSamples.java#L71-L72 -->
 ```java
 Path destinationPath = myFs.getPath("destinationFile");
 Files.copy(filePath, destinationPath, StandardCopyOption.COPY_ATTRIBUTES);
@@ -210,7 +210,7 @@ Files.copy(filePath, destinationPath, StandardCopyOption.COPY_ATTRIBUTES);
 
 ### Delete a file
 
-<!-- embedme ./src/samples/java/com/azure/storage/blob/nio/ReadmeSamples.java#L75-L75 -->
+<!-- embedme ./src/samples/java/com/azure/storage/blob/nio/ReadmeSamples.java#L76-L76 -->
 ```java
 Files.delete(filePath);
 ```
@@ -219,7 +219,7 @@ Files.delete(filePath);
 
 Read attributes of a file through the `AzureBlobFileAttributes`.
 
-<!-- embedme ./src/samples/java/com/azure/storage/blob/nio/ReadmeSamples.java#L79-L80 -->
+<!-- embedme ./src/samples/java/com/azure/storage/blob/nio/ReadmeSamples.java#L80-L81 -->
 ```java
 AzureBlobFileAttributes attr = Files.readAttributes(filePath, AzureBlobFileAttributes.class);
 BlobHttpHeaders headers = attr.blobHttpHeaders();
@@ -229,7 +229,7 @@ Or read attributes dynamically by specifying a string of desired attributes. Thi
 to retrieve any attribute will always retrieve all of them as an atomic bulk operation. You may specify "*" instead of a 
 list of specific attributes to have all attributes returned in the map.
 
-<!-- embedme ./src/samples/java/com/azure/storage/blob/nio/ReadmeSamples.java#L84-L84 -->
+<!-- embedme ./src/samples/java/com/azure/storage/blob/nio/ReadmeSamples.java#L85-L85 -->
 ```java
 Map<String, Object> attributes = Files.readAttributes(filePath, "azureBlob:metadata,headers");
 ```
@@ -238,7 +238,7 @@ Map<String, Object> attributes = Files.readAttributes(filePath, "azureBlob:metad
 
 Set attributes of a file through the `AzureBlobFileAttributeView`.
 
-<!-- embedme ./src/samples/java/com/azure/storage/blob/nio/ReadmeSamples.java#L88-L89 -->
+<!-- embedme ./src/samples/java/com/azure/storage/blob/nio/ReadmeSamples.java#L89-L90 -->
 ```java
 AzureBlobFileAttributeView view = Files.getFileAttributeView(filePath, AzureBlobFileAttributeView.class);
 view.setMetadata(Collections.EMPTY_MAP);
@@ -246,7 +246,7 @@ view.setMetadata(Collections.EMPTY_MAP);
 
 Or set an attribute dynamically by specifying the attribute as a string.
 
-<!-- embedme ./src/samples/java/com/azure/storage/blob/nio/ReadmeSamples.java#L93-L93 -->
+<!-- embedme ./src/samples/java/com/azure/storage/blob/nio/ReadmeSamples.java#L94-L94 -->
 ```java
 Files.setAttribute(filePath, "azureBlob:blobHttpHeaders", new BlobHttpHeaders());
 ```
diff --git a/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureFileSystem.java b/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureFileSystem.java
index ce5a30893ca5..6e661d75ec75 100644
--- a/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureFileSystem.java
+++ b/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureFileSystem.java
@@ -267,7 +267,7 @@ public String getSeparator() {
      * deleted or otherwise becomes unavailable, its root directory will still be returned but operations to it will
      * fail.
      *
-     * @return  an object to iterate over the paths of the root directories
+     * @return an object to iterate over the paths of the root directories
      */
     @Override
     public Iterable<Path> getRootDirectories() {
diff --git a/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureFileSystemProvider.java b/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureFileSystemProvider.java
index 14ea76aeb430..8b3211aa9966 100644
--- a/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureFileSystemProvider.java
+++ b/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzureFileSystemProvider.java
@@ -260,7 +260,7 @@ public Path getPath(URI uri) {
      * @return a new seekable byte channel
      * @throws UnsupportedOperationException Operation is not supported.
      * @throws IllegalArgumentException if the set contains an invalid combination of options
-     * @throws FileAlreadyExistsException  if a file of that name already exists and the CREATE_NEW option is specified
+     * @throws FileAlreadyExistsException if a file of that name already exists and the CREATE_NEW option is specified
      * (optional specific exception)
      * @throws IOException If an I/O error occurs.
      * @throws SecurityException never
@@ -877,7 +877,8 @@ public <A extends BasicFileAttributes> A readAttributes(Path path, Class<A> type
      * @throws SecurityException never
      */
     @Override
-    public Map<String, Object> readAttributes(Path path, String attributes, LinkOption... linkOptions) throws IOException {
+    public Map<String, Object> readAttributes(Path path, String attributes, LinkOption... linkOptions)
+        throws IOException {
         if (attributes == null) {
             throw LoggingUtility.logError(logger, new IllegalArgumentException("Attribute string cannot be null."));
         }
diff --git a/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzurePath.java b/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzurePath.java
index 665c76d217de..6ba74a99aafc 100644
--- a/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzurePath.java
+++ b/sdk/storage/azure-storage-blob-nio/src/main/java/com/azure/storage/blob/nio/AzurePath.java
@@ -503,7 +503,8 @@ public Path resolveSibling(String path) {
      * against this path, yields a path that locates the same file as the given path.
      * <p>
      * A relative path cannot be constructed if only one of the paths have a root component. If both paths have a root
-     * component, it is still possible to relativize one against the other. If this path and the given path are equal then an empty path is returned.
+     * component, it is still possible to relativize one against the other. If this path and the given path are equal
+     * then an empty path is returned.
      * <p>
      * For any two normalized paths p and q, where q does not have a root component,
      *     {@code p.relativize(p.resolve(q)).equals(q)}