From ac92dde6a497db15346fe199bb82bb6ae74c588e Mon Sep 17 00:00:00 2001 From: Connie Yau Date: Tue, 18 Jun 2024 12:44:29 -0700 Subject: [PATCH 1/4] Add azure-json dependency. Remove opens to jackson. --- sdk/communication/azure-communication-common/pom.xml | 5 +++++ .../src/main/java/module-info.java | 4 +--- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/sdk/communication/azure-communication-common/pom.xml b/sdk/communication/azure-communication-common/pom.xml index 268c3f0718a2..68d75235aaf2 100644 --- a/sdk/communication/azure-communication-common/pom.xml +++ b/sdk/communication/azure-communication-common/pom.xml @@ -54,6 +54,11 @@ 1.15.1 compile + + com.azure + azure-json + 1.1.0 + com.nimbusds nimbus-jose-jwt diff --git a/sdk/communication/azure-communication-common/src/main/java/module-info.java b/sdk/communication/azure-communication-common/src/main/java/module-info.java index 5e8f0d4b6703..cb01e8fb9030 100644 --- a/sdk/communication/azure-communication-common/src/main/java/module-info.java +++ b/sdk/communication/azure-communication-common/src/main/java/module-info.java @@ -4,13 +4,11 @@ module com.azure.communication.common { requires transitive com.azure.core; + requires com.azure.json; // public API surface area exports com.azure.communication.common; - opens com.azure.communication.common - to com.fasterxml.jackson.databind; - exports com.azure.communication.common.implementation to com.azure.communication.email, com.azure.communication.sms, From 00364bc78c5b7e071658f6efa43469a7e9e91856 Mon Sep 17 00:00:00 2001 From: Connie Yau Date: Wed, 3 Jul 2024 12:14:31 -0700 Subject: [PATCH 2/4] Update module-info.java --- .../azure-communication-common/src/main/java/module-info.java | 1 - 1 file changed, 1 deletion(-) diff --git a/sdk/communication/azure-communication-common/src/main/java/module-info.java b/sdk/communication/azure-communication-common/src/main/java/module-info.java index cb01e8fb9030..72c4e7b1bd9b 100644 --- a/sdk/communication/azure-communication-common/src/main/java/module-info.java +++ b/sdk/communication/azure-communication-common/src/main/java/module-info.java @@ -4,7 +4,6 @@ module com.azure.communication.common { requires transitive com.azure.core; - requires com.azure.json; // public API surface area exports com.azure.communication.common; From cfbb4ce68dcfa468ceda68247ec4b17df9716a71 Mon Sep 17 00:00:00 2001 From: Connie Yau Date: Wed, 3 Jul 2024 12:14:53 -0700 Subject: [PATCH 3/4] Update pom.xml --- sdk/communication/azure-communication-common/pom.xml | 5 ----- 1 file changed, 5 deletions(-) diff --git a/sdk/communication/azure-communication-common/pom.xml b/sdk/communication/azure-communication-common/pom.xml index 68d75235aaf2..268c3f0718a2 100644 --- a/sdk/communication/azure-communication-common/pom.xml +++ b/sdk/communication/azure-communication-common/pom.xml @@ -54,11 +54,6 @@ 1.15.1 compile - - com.azure - azure-json - 1.1.0 - com.nimbusds nimbus-jose-jwt From c9c09b75bab261e58116877bf634281328e9279e Mon Sep 17 00:00:00 2001 From: Connie Yau Date: Wed, 3 Jul 2024 12:20:37 -0700 Subject: [PATCH 4/4] Update module-info.java --- .../azure-communication-common/src/main/java/module-info.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sdk/communication/azure-communication-common/src/main/java/module-info.java b/sdk/communication/azure-communication-common/src/main/java/module-info.java index 72c4e7b1bd9b..0a841010e53e 100644 --- a/sdk/communication/azure-communication-common/src/main/java/module-info.java +++ b/sdk/communication/azure-communication-common/src/main/java/module-info.java @@ -7,6 +7,8 @@ // public API surface area exports com.azure.communication.common; + opens com.azure.communication.common to + com.azure.core; exports com.azure.communication.common.implementation to com.azure.communication.email,