diff --git a/sdk/communication/azure-communication-callautomation/src/main/java/com/azure/communication/callautomation/CallRecordingAsync.java b/sdk/communication/azure-communication-callautomation/src/main/java/com/azure/communication/callautomation/CallRecordingAsync.java index f2c87037b337..515fcc43c983 100644 --- a/sdk/communication/azure-communication-callautomation/src/main/java/com/azure/communication/callautomation/CallRecordingAsync.java +++ b/sdk/communication/azure-communication-callautomation/src/main/java/com/azure/communication/callautomation/CallRecordingAsync.java @@ -178,8 +178,8 @@ private StartCallRecordingRequestInternal getStartCallRecordingRequest(StartReco request.setExternalStorage(recordingStorageInternal); } } - if (options.getPauseOnStart() != null) { - request.setPauseOnStart(options.getPauseOnStart()); + if (options.isPauseOnStart() != null) { + request.setPauseOnStart(options.isPauseOnStart()); } return request; diff --git a/sdk/communication/azure-communication-callautomation/src/main/java/com/azure/communication/callautomation/models/RecordingStateResult.java b/sdk/communication/azure-communication-callautomation/src/main/java/com/azure/communication/callautomation/models/RecordingStateResult.java index 0f6da16fb54b..55467ee72121 100644 --- a/sdk/communication/azure-communication-callautomation/src/main/java/com/azure/communication/callautomation/models/RecordingStateResult.java +++ b/sdk/communication/azure-communication-callautomation/src/main/java/com/azure/communication/callautomation/models/RecordingStateResult.java @@ -18,6 +18,8 @@ public final class RecordingStateResult { */ private final String recordingId; + private final RecordingKind recordingKind; + private final RecordingState recordingState; /** @@ -29,6 +31,15 @@ public String getRecordingId() { return this.recordingId; } + /** + * Get the RecordingKind property: The recording kind status of the recording. + * + * @return the recordingKind value. + */ + public RecordingKind getRecordingKind() { + return this.recordingKind; + } + /** * Get the RecordingState property: The recording status of the recording. * @@ -44,6 +55,7 @@ public RecordingState getRecordingState() { */ public RecordingStateResult() { this.recordingId = null; + this.recordingKind = null; this.recordingState = null; } @@ -54,6 +66,7 @@ public RecordingStateResult() { */ RecordingStateResult(RecordingStateResponseInternal recordingStateResponseInternal) { this.recordingId = recordingStateResponseInternal.getRecordingId(); + this.recordingKind = RecordingKind.fromString(recordingStateResponseInternal.getRecordingKind().toString()); this.recordingState = RecordingState.fromString(recordingStateResponseInternal.getRecordingState().toString()); } } diff --git a/sdk/communication/azure-communication-callautomation/src/main/java/com/azure/communication/callautomation/models/StartRecordingOptions.java b/sdk/communication/azure-communication-callautomation/src/main/java/com/azure/communication/callautomation/models/StartRecordingOptions.java index ee2e83c488f1..7b7f758f2c03 100644 --- a/sdk/communication/azure-communication-callautomation/src/main/java/com/azure/communication/callautomation/models/StartRecordingOptions.java +++ b/sdk/communication/azure-communication-callautomation/src/main/java/com/azure/communication/callautomation/models/StartRecordingOptions.java @@ -139,7 +139,7 @@ public StartRecordingOptions setRecordingFormat(RecordingFormat recordingFormat) * * @return pause on start. */ - public Boolean getPauseOnStart() { + public Boolean isPauseOnStart() { return pauseOnStart; } diff --git a/sdk/communication/azure-communication-callautomation/src/test/java/com/azure/communication/callautomation/CallRecordingUnitTestBase.java b/sdk/communication/azure-communication-callautomation/src/test/java/com/azure/communication/callautomation/CallRecordingUnitTestBase.java index 82359566df32..f3b1048ba907 100644 --- a/sdk/communication/azure-communication-callautomation/src/test/java/com/azure/communication/callautomation/CallRecordingUnitTestBase.java +++ b/sdk/communication/azure-communication-callautomation/src/test/java/com/azure/communication/callautomation/CallRecordingUnitTestBase.java @@ -4,10 +4,11 @@ package com.azure.communication.callautomation; import com.azure.communication.callautomation.implementation.models.RecordingStateInternal; +import com.azure.communication.callautomation.implementation.models.RecordingKind; import com.azure.communication.callautomation.implementation.models.RecordingStateResponseInternal; + import com.azure.json.JsonProviders; import com.azure.json.JsonWriter; - import java.io.ByteArrayOutputStream; import java.io.IOException; import java.util.AbstractMap; @@ -18,9 +19,11 @@ public class CallRecordingUnitTestBase { static final String SERVER_CALL_ID = "aHR0cHM6Ly9jb252LXVzd2UtMDguY29udi5za3lwZS5jb20vY29udi8tby1FWjVpMHJrS3RFTDBNd0FST1J3P2k9ODgmZT02Mzc1Nzc0MTY4MDc4MjQyOTM"; static final String RECORDING_ID = "recordingId"; + private final RecordingStateResponseInternal recordingState = new RecordingStateResponseInternal().setRecordingId(RECORDING_ID); - private final String recordingActive = serializeObject(recordingState.setRecordingState(RecordingStateInternal.ACTIVE)); - private final String recordingInactive = serializeObject(recordingState.setRecordingState(RecordingStateInternal.INACTIVE)); + + private final String recordingActive = generateGetParticipantResponse(RecordingStateInternal.ACTIVE, RecordingKind.TEAMS); + private final String recordingInactive = generateGetParticipantResponse(RecordingStateInternal.INACTIVE, RecordingKind.TEAMS); ArrayList> recordingOperationsResponses = new ArrayList<>(Arrays.asList( new AbstractMap.SimpleEntry<>(recordingActive, 200), //startRecording @@ -42,4 +45,14 @@ private String serializeObject(RecordingStateResponseInternal o) { throw new RuntimeException(e); } } + + private String generateGetParticipantResponse(RecordingStateInternal recordingState, RecordingKind recordingKind) { + + RecordingStateResponseInternal response = new RecordingStateResponseInternal(); + response.setRecordingState(recordingState); + response.setRecordingKind(recordingKind); + response.setRecordingId(RECORDING_ID); + + return serializeObject(response); + } }