diff --git a/eng/versioning/external_dependencies.txt b/eng/versioning/external_dependencies.txt index 240cb6336f95..0bd425e8ff0e 100644 --- a/eng/versioning/external_dependencies.txt +++ b/eng/versioning/external_dependencies.txt @@ -43,7 +43,6 @@ commons-net:commons-net;3.9.0 io.cloudevents:cloudevents-api;2.2.0 io.cloudevents:cloudevents-core;2.2.0 io.fabric8:kubernetes-client;6.12.1 -io.netty:netty-bom;4.1.130.Final io.netty:netty-buffer;4.1.130.Final io.netty:netty-common;4.1.130.Final io.netty:netty-codec;4.1.130.Final @@ -58,7 +57,6 @@ io.netty:netty-transport;4.1.130.Final io.netty:netty-transport-native-epoll;4.1.130.Final io.netty:netty-transport-native-unix-common;4.1.130.Final io.netty:netty-transport-native-kqueue;4.1.130.Final -io.projectreactor:reactor-bom;2024.0.9 io.projectreactor.netty:reactor-netty-http;1.2.13 io.projectreactor:reactor-core;3.7.14 io.vertx:vertx-codegen;4.5.23 diff --git a/sdk/spring/scripts/compatibility_insert_dependencymanagement.py b/sdk/spring/scripts/compatibility_insert_dependencymanagement.py index f2fe93c6790f..5c9e15487d25 100644 --- a/sdk/spring/scripts/compatibility_insert_dependencymanagement.py +++ b/sdk/spring/scripts/compatibility_insert_dependencymanagement.py @@ -156,14 +156,26 @@ def add_dependency_management_for_file(file_path, spring_boot_dependencies_versi # dependencyManagement already exists, insert new dependencies inside it log.info("Found existing dependencyManagement in " + file_path + ". Inserting new dependencies.") dependencies_in_dm_start = pom_file_content.find('', dependency_management_start) - if dependencies_in_dm_start == -1: - log.warn("No dependencies section found in dependencyManagement for " + file_path + ". Skipping.") - return - # Find the position to insert (after opening tag) - insert_position = dependencies_in_dm_start + len('') - insert_content = get_dependency_content_for_existing_management() - dependency_content = pom_file_content[:insert_position] + insert_content + pom_file_content[insert_position:] + if dependencies_in_dm_start == -1: + # No dependencies section in dependencyManagement, create one + log.info("No dependencies section found in dependencyManagement for " + file_path + ". Creating new dependencies section.") + dependency_management_end = pom_file_content.find('', dependency_management_start) + if dependency_management_end == -1: + log.warn("No closing dependencyManagement tag found for " + file_path + ". Skipping.") + return + insert_position = dependency_management_end + insert_content = " \n{} \n".format(get_dependency_content_for_existing_management()) + dependency_content = pom_file_content[:insert_position] + insert_content + pom_file_content[insert_position:] + else: + # Find the position to insert (before closing tag) + dependencies_in_dm_end = pom_file_content.find('', dependencies_in_dm_start) + if dependencies_in_dm_end == -1: + log.warn("No closing dependencies tag found in dependencyManagement for " + file_path + ". Skipping.") + return + insert_position = dependencies_in_dm_end + insert_content = get_dependency_content_for_existing_management() + dependency_content = pom_file_content[:insert_position] + insert_content + pom_file_content[insert_position:] else: # No dependencyManagement exists, create new one log.info("No existing dependencyManagement in " + file_path + ". Creating new one.") @@ -211,8 +223,7 @@ def update_spring_boot_starter_parent_for_file(file_path, spring_boot_dependenci def get_dependencies_content(): """Returns the dependency entries without any wrapping tags.""" - return """ - + return """ org.springframework.boot spring-boot-dependencies ${spring.boot.version} @@ -226,7 +237,7 @@ def get_dependencies_content(): pom import -""" + """ def get_dependency_management_content(): @@ -254,8 +265,7 @@ def get_properties_contend_with_tag(spring_boot_dependencies_version, spring_clo def get_properties_contend(spring_boot_dependencies_version, spring_cloud_dependencies_version): - return """ - {} + return """ {} {} """.format(spring_boot_dependencies_version, spring_cloud_dependencies_version) diff --git a/sdk/spring/spring-cloud-azure-integration-tests/pom.xml b/sdk/spring/spring-cloud-azure-integration-tests/pom.xml index 98a46fb34f03..ac77323aca71 100644 --- a/sdk/spring/spring-cloud-azure-integration-tests/pom.xml +++ b/sdk/spring/spring-cloud-azure-integration-tests/pom.xml @@ -38,25 +38,6 @@ true - - - - io.projectreactor - reactor-bom - 2024.0.9 - pom - import - - - io.netty - netty-bom - 4.1.130.Final - pom - import - - - - com.azure.spring diff --git a/sdk/spring/spring-cloud-azure-integration-tests/src/test/java/com/azure/spring/cloud/integration/tests/servicebus/binder/TestServiceBusMultiBinders.java b/sdk/spring/spring-cloud-azure-integration-tests/src/test/java/com/azure/spring/cloud/integration/tests/servicebus/binder/TestServiceBusMultiBinders.java index 5ede74cf628e..66e75701c95d 100644 --- a/sdk/spring/spring-cloud-azure-integration-tests/src/test/java/com/azure/spring/cloud/integration/tests/servicebus/binder/TestServiceBusMultiBinders.java +++ b/sdk/spring/spring-cloud-azure-integration-tests/src/test/java/com/azure/spring/cloud/integration/tests/servicebus/binder/TestServiceBusMultiBinders.java @@ -95,12 +95,14 @@ protected void exchangeMessageAndVerify(String activeProfile, Sinks.Many> manyTopic) throws InterruptedException { GenericMessage genericMessage = new GenericMessage<>(message); + Thread.sleep(2000); + LOGGER.info("Send a message:" + message + " to the queue."); manyQueue.emitNext(genericMessage, Sinks.EmitFailureHandler.FAIL_FAST); LOGGER.info("Send a message:" + message + " to the topic."); manyTopic.emitNext(genericMessage, Sinks.EmitFailureHandler.FAIL_FAST); - assertThat(LATCH.get(activeProfile).await(30, TimeUnit.SECONDS)).isTrue(); + assertThat(LATCH.get(activeProfile).await(100, TimeUnit.SECONDS)).isTrue(); } } diff --git a/sdk/spring/spring-cloud-azure-integration-tests/src/test/java/com/azure/spring/cloud/integration/tests/servicebus/binder/TestServiceBusSingleBinder.java b/sdk/spring/spring-cloud-azure-integration-tests/src/test/java/com/azure/spring/cloud/integration/tests/servicebus/binder/TestServiceBusSingleBinder.java index 585c2d697953..a9f60f68c002 100644 --- a/sdk/spring/spring-cloud-azure-integration-tests/src/test/java/com/azure/spring/cloud/integration/tests/servicebus/binder/TestServiceBusSingleBinder.java +++ b/sdk/spring/spring-cloud-azure-integration-tests/src/test/java/com/azure/spring/cloud/integration/tests/servicebus/binder/TestServiceBusSingleBinder.java @@ -95,11 +95,13 @@ protected void exchangeMessageAndVerify(String activeProfile, Sinks.Many> manyTopic) throws InterruptedException { GenericMessage genericMessage = new GenericMessage<>(MESSAGE); + Thread.sleep(2000); + LOGGER.info("Send a message:" + MESSAGE + " to the queue."); manyQueue.emitNext(genericMessage, Sinks.EmitFailureHandler.FAIL_FAST); LOGGER.info("Send a message:" + MESSAGE + " to the topic."); manyTopic.emitNext(genericMessage, Sinks.EmitFailureHandler.FAIL_FAST); - assertThat(TestServiceBusSingleBinder.LATCH.get(activeProfile).await(30, TimeUnit.SECONDS)).isTrue(); + assertThat(TestServiceBusSingleBinder.LATCH.get(activeProfile).await(100, TimeUnit.SECONDS)).isTrue(); } }