diff --git a/sdk/cosmos/azure-cosmos/CHANGELOG.md b/sdk/cosmos/azure-cosmos/CHANGELOG.md index c888f9729b1e..818e49226a40 100644 --- a/sdk/cosmos/azure-cosmos/CHANGELOG.md +++ b/sdk/cosmos/azure-cosmos/CHANGELOG.md @@ -7,6 +7,7 @@ #### Breaking Changes #### Bugs Fixed +Fixing an NPE caused due to boxed Boolean conversion. - See [PR 48656](https://github.com/Azure/azure-sdk-for-java/pull/48656/) #### Other Changes diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/DatabaseAccount.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/DatabaseAccount.java index 8338b3eb40b5..50b6ed53dfcd 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/DatabaseAccount.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/DatabaseAccount.java @@ -302,19 +302,19 @@ public Boolean isPerPartitionFailoverBehaviorEnabled() { /** * Returns true if the account supports N region synchronous commit, - * false if enableNRegionSynchronousCommit evaluates to null or false. + * false otherwise *
- * If enableNRegionSynchronousCommit property does not exist in account metadata JSON payload, null is returned.
+ * If enableNRegionSynchronousCommit property does not exist in account metadata JSON payload, false is returned
*
* @return true if the account supports N region synchronous commit, false otherwise.
*/
- public Boolean isNRegionSynchronousCommitEnabled() {
+ public boolean isNRegionSynchronousCommitEnabled() {
if (super.has(Constants.Properties.ENABLE_N_REGION_SYNCHRONOUS_COMMIT)) {
return ObjectUtils.defaultIfNull(super.getBoolean(Constants.Properties.ENABLE_N_REGION_SYNCHRONOUS_COMMIT), false);
}
- return null;
+ return false;
}
public void setIsPerPartitionFailoverBehaviorEnabled(boolean value) {
diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/DocumentServiceRequestContext.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/DocumentServiceRequestContext.java
index d49d4d24b3f4..d33297065d16 100644
--- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/DocumentServiceRequestContext.java
+++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/DocumentServiceRequestContext.java
@@ -275,7 +275,7 @@ public boolean getNRegionSynchronousCommitEnabled() {
return nRegionSynchronousCommitEnabled;
}
- public void setNRegionSynchronousCommitEnabled(Boolean nRegionSynchronousCommitEnabled) {
+ public void setNRegionSynchronousCommitEnabled(boolean nRegionSynchronousCommitEnabled) {
this.nRegionSynchronousCommitEnabled = nRegionSynchronousCommitEnabled;
}
diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/GlobalEndpointManager.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/GlobalEndpointManager.java
index 57076de28d52..a580582c07a9 100644
--- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/GlobalEndpointManager.java
+++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/GlobalEndpointManager.java
@@ -438,11 +438,11 @@ public void setPerPartitionAutomaticFailoverConfigModifier(Consumer