App Config SDK/Provider Pylint Updates (#45050)

* simple pylint fixes

* provider mypy updates

* more pylint updates

* fixes

* more fixes

* Update assets.json

* Fixing sample text

* adding missing import

Author: mrm9084

sdk/appconfiguration/azure-appconfiguration-provider/samples/aad_sample.py

@@ -3,10 +3,9 @@
 # Licensed under the MIT License. See License.txt in the project root for
 # license information.
 # -------------------------------------------------------------------------
-
-from azure.appconfiguration.provider import load, SettingSelector
 import os
 from sample_utilities import get_authority, get_credential, get_client_modifications
+from azure.appconfiguration.provider import load, SettingSelector
 
 endpoint = os.environ.get("APPCONFIGURATION_ENDPOINT_STRING")
 authority = get_authority(endpoint)

sdk/appconfiguration/azure-appconfiguration-provider/samples/async_aad_sample.py

@@ -3,12 +3,11 @@
 # Licensed under the MIT License. See License.txt in the project root for
 # license information.
 # -------------------------------------------------------------------------
-
+import os
 import asyncio
+from sample_utilities import get_authority, get_credential, get_client_modifications
 from azure.appconfiguration.provider.aio import load
 from azure.appconfiguration.provider import SettingSelector
-import os
-from sample_utilities import get_authority, get_credential, get_client_modifications
 
 
 async def main():

sdk/appconfiguration/azure-appconfiguration-provider/samples/async_connection_string_sample.py

@@ -3,11 +3,11 @@
 # Licensed under the MIT License. See License.txt in the project root for
 # license information.
 # -------------------------------------------------------------------------
+import os
 import asyncio
+from sample_utilities import get_client_modifications
 from azure.appconfiguration.provider.aio import load
 from azure.appconfiguration.provider import SettingSelector
-from sample_utilities import get_client_modifications
-import os
 
 
 async def main():

sdk/appconfiguration/azure-appconfiguration-provider/samples/async_key_vault_reference_provided_clients_sample.py

@@ -3,12 +3,11 @@
 # Licensed under the MIT License. See License.txt in the project root for
 # license information.
 # -------------------------------------------------------------------------
-
+import os
 import asyncio
+from sample_utilities import get_authority, get_credential, get_client_modifications
 from azure.appconfiguration.provider.aio import load
 from azure.appconfiguration.provider import SettingSelector
-import os
-from sample_utilities import get_authority, get_credential, get_client_modifications
 
 
 async def main():

sdk/appconfiguration/azure-appconfiguration-provider/samples/async_key_vault_reference_sample.py

@@ -3,12 +3,11 @@
 # Licensed under the MIT License. See License.txt in the project root for
 # license information.
 # -------------------------------------------------------------------------
-
+import os
 import asyncio
+from sample_utilities import get_authority, get_credential, get_client_modifications
 from azure.appconfiguration.provider.aio import load
 from azure.appconfiguration.provider import SettingSelector
-import os
-from sample_utilities import get_authority, get_credential, get_client_modifications
 
 
 async def main():

sdk/appconfiguration/azure-appconfiguration-provider/samples/async_snapshot_sample.py

@@ -3,19 +3,18 @@
 # Licensed under the MIT License. See License.txt in the project root for
 # license information.
 # -------------------------------------------------------------------------
-
+import os
+import uuid
 import asyncio
-from azure.appconfiguration.provider.aio import load
-from azure.appconfiguration.provider import SettingSelector
 from azure.appconfiguration.aio import AzureAppConfigurationClient  # type:ignore
 from azure.appconfiguration import (  # type:ignore
     ConfigurationSettingsFilter,
     ConfigurationSetting,
     FeatureFlagConfigurationSetting,
 )
 from azure.identity.aio import DefaultAzureCredential
-import os
-import uuid
+from azure.appconfiguration.provider.aio import load
+from azure.appconfiguration.provider import SettingSelector
 
 
 async def main():

sdk/appconfiguration/azure-appconfiguration-provider/samples/connection_string_sample.py

@@ -3,10 +3,9 @@
 # Licensed under the MIT License. See License.txt in the project root for
 # license information.
 # -------------------------------------------------------------------------
-
-from azure.appconfiguration.provider import load, SettingSelector
-from sample_utilities import get_client_modifications
 import os
+from sample_utilities import get_client_modifications
+from azure.appconfiguration.provider import load, SettingSelector
 
 kwargs = get_client_modifications()
 connection_string = os.environ["APPCONFIGURATION_CONNECTION_STRING"]

sdk/appconfiguration/azure-appconfiguration-provider/samples/key_vault_reference_customized_clients_sample.py

@@ -3,10 +3,9 @@
 # Licensed under the MIT License. See License.txt in the project root for
 # license information.
 # -------------------------------------------------------------------------
-
-from azure.appconfiguration.provider import load, SettingSelector
 import os
 from sample_utilities import get_authority, get_credential, get_client_modifications
+from azure.appconfiguration.provider import load, SettingSelector
 
 endpoint = os.environ["APPCONFIGURATION_ENDPOINT_STRING"]
 key_vault_uri = os.environ["KEYVAULT_URL"]

sdk/appconfiguration/azure-appconfiguration-provider/samples/key_vault_reference_sample.py

@@ -3,10 +3,9 @@
 # Licensed under the MIT License. See License.txt in the project root for
 # license information.
 # -------------------------------------------------------------------------
-
-from azure.appconfiguration.provider import load, SettingSelector
 import os
 from sample_utilities import get_authority, get_audience, get_credential, get_client_modifications
+from azure.appconfiguration.provider import load, SettingSelector
 
 endpoint = os.environ["APPCONFIGURATION_ENDPOINT_STRING"]
 authority = get_authority(endpoint)

sdk/appconfiguration/azure-appconfiguration-provider/samples/refresh_sample.py

@@ -3,14 +3,14 @@
 # Licensed under the MIT License. See License.txt in the project root for
 # license information.
 # -------------------------------------------------------------------------
-from azure.appconfiguration.provider import load, WatchKey
+import os
+import time
+from sample_utilities import get_client_modifications
 from azure.appconfiguration import (  # type:ignore
     AzureAppConfigurationClient,
     ConfigurationSetting,
 )
-from sample_utilities import get_client_modifications
-import os
-import time
+from azure.appconfiguration.provider import load, WatchKey
 
 kwargs = get_client_modifications()
 connection_string = os.environ.get("APPCONFIGURATION_CONNECTION_STRING")
@@ -23,11 +23,12 @@
 client.set_configuration_setting(configuration_setting=configuration_setting)
 
 
-def my_callback_on_fail(error):
+def my_callback_on_fail(_):
     print("Refresh failed!")
 
 
-# Connecting to Azure App Configuration using connection string, and refreshing when the configuration setting message changes
+# Connecting to Azure App Configuration using connection string, and refreshing when the configuration setting message
+# changes
 config = load(
     connection_string=connection_string,
     refresh_on=[WatchKey("message")],