From 19ddd7cb52faf628c104d2f2df42b854120c27ac Mon Sep 17 00:00:00 2001 From: Sima Zhu Date: Tue, 13 Oct 2020 10:56:28 -0700 Subject: [PATCH 1/5] Only check the touched markdown files in PR for the Verify link step --- eng/pipelines/templates/jobs/archetype-sdk-client.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/eng/pipelines/templates/jobs/archetype-sdk-client.yml b/eng/pipelines/templates/jobs/archetype-sdk-client.yml index df02746699e2..c3eefb1c5496 100644 --- a/eng/pipelines/templates/jobs/archetype-sdk-client.yml +++ b/eng/pipelines/templates/jobs/archetype-sdk-client.yml @@ -77,7 +77,8 @@ jobs: steps: - template: ../../../common/pipelines/templates/steps/verify-links.yml parameters: - Directory: "sdk/${{ parameters.ServiceDirectory }}" + Directory: '' + Urls: (git diff origin/master HEAD --name-only -- *.md) CheckLinkGuidance: $true - template: ../steps/analyze.yml From f3a2c459ba90adc64da20410636f8693f38b9c23 Mon Sep 17 00:00:00 2001 From: Sima Zhu Date: Wed, 14 Oct 2020 15:28:40 -0700 Subject: [PATCH 2/5] Change to base branch insteasd of master --- eng/pipelines/templates/jobs/archetype-sdk-client.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eng/pipelines/templates/jobs/archetype-sdk-client.yml b/eng/pipelines/templates/jobs/archetype-sdk-client.yml index c3eefb1c5496..a870abc28321 100644 --- a/eng/pipelines/templates/jobs/archetype-sdk-client.yml +++ b/eng/pipelines/templates/jobs/archetype-sdk-client.yml @@ -78,7 +78,7 @@ jobs: - template: ../../../common/pipelines/templates/steps/verify-links.yml parameters: Directory: '' - Urls: (git diff origin/master HEAD --name-only -- *.md) + Urls: (git diff origin/${env:SYSTEM_PULLREQUEST_TARGETBRANCH} HEAD --name-only -- *.md) CheckLinkGuidance: $true - template: ../steps/analyze.yml From 6b844194011703f9045bbbd363937c6cf0af7f9e Mon Sep 17 00:00:00 2001 From: Sima Zhu Date: Thu, 15 Oct 2020 09:43:46 -0700 Subject: [PATCH 3/5] add pr condition --- eng/pipelines/templates/jobs/archetype-sdk-client.yml | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/eng/pipelines/templates/jobs/archetype-sdk-client.yml b/eng/pipelines/templates/jobs/archetype-sdk-client.yml index a870abc28321..0a6158e8fff7 100644 --- a/eng/pipelines/templates/jobs/archetype-sdk-client.yml +++ b/eng/pipelines/templates/jobs/archetype-sdk-client.yml @@ -75,11 +75,12 @@ jobs: vmImage: 'ubuntu-18.04' steps: - - template: ../../../common/pipelines/templates/steps/verify-links.yml - parameters: - Directory: '' - Urls: (git diff origin/${env:SYSTEM_PULLREQUEST_TARGETBRANCH} HEAD --name-only -- *.md) - CheckLinkGuidance: $true + - ${{ if eq(variables['Build.Reason'], 'PullRequest') }}: + template: /eng/common/pipelines/templates/steps/verify-links.yml + parameters: + Directory: '' + Urls: (git diff origin/${env:SYSTEM_PULLREQUEST_TARGETBRANCH} HEAD --name-only -- *.md) + CheckLinkGuidance: $true - template: ../steps/analyze.yml parameters: From a49ad17eded17d598f7319c8be9849fd11751a36 Mon Sep 17 00:00:00 2001 From: Sima Zhu <48036328+sima-zhu@users.noreply.github.com> Date: Thu, 15 Oct 2020 10:54:33 -0700 Subject: [PATCH 4/5] Update archetype-sdk-client.yml --- eng/pipelines/templates/jobs/archetype-sdk-client.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eng/pipelines/templates/jobs/archetype-sdk-client.yml b/eng/pipelines/templates/jobs/archetype-sdk-client.yml index 0a6158e8fff7..35b099a4d47a 100644 --- a/eng/pipelines/templates/jobs/archetype-sdk-client.yml +++ b/eng/pipelines/templates/jobs/archetype-sdk-client.yml @@ -76,7 +76,7 @@ jobs: steps: - ${{ if eq(variables['Build.Reason'], 'PullRequest') }}: - template: /eng/common/pipelines/templates/steps/verify-links.yml + - template: /eng/common/pipelines/templates/steps/verify-links.yml parameters: Directory: '' Urls: (git diff origin/${env:SYSTEM_PULLREQUEST_TARGETBRANCH} HEAD --name-only -- *.md) From 2f0604187e51cf02a5efb8aace2c48df0d4a1bd2 Mon Sep 17 00:00:00 2001 From: Sima Zhu Date: Fri, 16 Oct 2020 11:04:08 -0700 Subject: [PATCH 5/5] remove the read me --- eng/pipelines/templates/jobs/archetype-sdk-client.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eng/pipelines/templates/jobs/archetype-sdk-client.yml b/eng/pipelines/templates/jobs/archetype-sdk-client.yml index 35b099a4d47a..d3ff076f4e24 100644 --- a/eng/pipelines/templates/jobs/archetype-sdk-client.yml +++ b/eng/pipelines/templates/jobs/archetype-sdk-client.yml @@ -79,7 +79,7 @@ jobs: - template: /eng/common/pipelines/templates/steps/verify-links.yml parameters: Directory: '' - Urls: (git diff origin/${env:SYSTEM_PULLREQUEST_TARGETBRANCH} HEAD --name-only -- *.md) + Urls: (git diff origin/${env:SYSTEM_PULLREQUEST_TARGETBRANCH} HEAD --name-only -- '*.md') CheckLinkGuidance: $true - template: ../steps/analyze.yml