From 8d59081773514b30172c542418779a9c2141e73f Mon Sep 17 00:00:00 2001 From: Steven Jin Date: Tue, 9 Aug 2022 09:22:18 -0700 Subject: [PATCH 1/3] Dont default to RequestsTransport --- .../azure/keyvault/administration/_internal/client_base.py | 3 +-- .../azure/keyvault/certificates/_client.py | 2 +- .../azure/keyvault/certificates/_shared/client_base.py | 3 +-- .../azure-keyvault-keys/azure/keyvault/keys/_client.py | 2 +- .../azure/keyvault/keys/_shared/client_base.py | 3 +-- .../azure-keyvault-keys/azure/keyvault/keys/crypto/_client.py | 2 +- .../azure-keyvault-secrets/azure/keyvault/secrets/_client.py | 2 +- .../azure/keyvault/secrets/_shared/client_base.py | 3 +-- 8 files changed, 8 insertions(+), 12 deletions(-) diff --git a/sdk/keyvault/azure-keyvault-administration/azure/keyvault/administration/_internal/client_base.py b/sdk/keyvault/azure-keyvault-administration/azure/keyvault/administration/_internal/client_base.py index d2cbef54b0e4..eaaf17b2306e 100644 --- a/sdk/keyvault/azure-keyvault-administration/azure/keyvault/administration/_internal/client_base.py +++ b/sdk/keyvault/azure-keyvault-administration/azure/keyvault/administration/_internal/client_base.py @@ -8,7 +8,6 @@ from six import with_metaclass from azure.core import CaseInsensitiveEnumMeta -from azure.core.pipeline.transport import RequestsTransport from azure.core.pipeline.policies import HttpLoggingPolicy from . import ChallengeAuthPolicy @@ -55,7 +54,7 @@ def __init__(self, vault_url, credential, **kwargs): return pipeline = kwargs.pop("pipeline", None) - transport = kwargs.pop("transport", RequestsTransport(**kwargs)) + transport = kwargs.pop("transport", None) http_logging_policy = HttpLoggingPolicy(**kwargs) http_logging_policy.allowed_header_names.update( {"x-ms-keyvault-network-info", "x-ms-keyvault-region", "x-ms-keyvault-service-version"} diff --git a/sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/_client.py b/sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/_client.py index 1afba2145a14..5336a33973d9 100644 --- a/sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/_client.py +++ b/sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/_client.py @@ -46,7 +46,7 @@ class CertificateClient(KeyVaultClientBase): :mod:`azure.identity` :keyword api_version: version of the Key Vault API to use. Defaults to the most recent. :paramtype api_version: ~azure.keyvault.certificates.ApiVersion - :keyword transport: transport to use. Defaults to :class:`~azure.core.pipeline.transport.RequestsTransport`. + :keyword transport: transport to use. :paramtype transport: ~azure.core.pipeline.transport.HttpTransport Example: diff --git a/sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/_shared/client_base.py b/sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/_shared/client_base.py index e03e81b083b1..1c00aca19d6a 100644 --- a/sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/_shared/client_base.py +++ b/sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/_shared/client_base.py @@ -8,7 +8,6 @@ from six import with_metaclass from azure.core import CaseInsensitiveEnumMeta -from azure.core.pipeline.transport import RequestsTransport from azure.core.pipeline.policies import HttpLoggingPolicy from . import ChallengeAuthPolicy @@ -59,7 +58,7 @@ def __init__(self, vault_url, credential, **kwargs): return pipeline = kwargs.pop("pipeline", None) - transport = kwargs.pop("transport", RequestsTransport(**kwargs)) + transport = kwargs.pop("transport", None) http_logging_policy = HttpLoggingPolicy(**kwargs) http_logging_policy.allowed_header_names.update( {"x-ms-keyvault-network-info", "x-ms-keyvault-region", "x-ms-keyvault-service-version"} diff --git a/sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/_client.py b/sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/_client.py index 5064baa0f239..3ae210c77341 100644 --- a/sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/_client.py +++ b/sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/_client.py @@ -39,7 +39,7 @@ class KeyClient(KeyVaultClientBase): :keyword api_version: version of the Key Vault API to use. Defaults to the most recent. :paramtype api_version: ~azure.keyvault.keys.ApiVersion - :keyword transport: transport to use. Defaults to :class:`~azure.core.pipeline.transport.RequestsTransport`. + :keyword transport: transport to use. :paramtype transport: ~azure.core.pipeline.transport.HttpTransport Example: diff --git a/sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/_shared/client_base.py b/sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/_shared/client_base.py index e03e81b083b1..1c00aca19d6a 100644 --- a/sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/_shared/client_base.py +++ b/sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/_shared/client_base.py @@ -8,7 +8,6 @@ from six import with_metaclass from azure.core import CaseInsensitiveEnumMeta -from azure.core.pipeline.transport import RequestsTransport from azure.core.pipeline.policies import HttpLoggingPolicy from . import ChallengeAuthPolicy @@ -59,7 +58,7 @@ def __init__(self, vault_url, credential, **kwargs): return pipeline = kwargs.pop("pipeline", None) - transport = kwargs.pop("transport", RequestsTransport(**kwargs)) + transport = kwargs.pop("transport", None) http_logging_policy = HttpLoggingPolicy(**kwargs) http_logging_policy.allowed_header_names.update( {"x-ms-keyvault-network-info", "x-ms-keyvault-region", "x-ms-keyvault-service-version"} diff --git a/sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/crypto/_client.py b/sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/crypto/_client.py index 6bee73abc951..52e810c38ccf 100644 --- a/sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/crypto/_client.py +++ b/sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/crypto/_client.py @@ -93,7 +93,7 @@ class CryptographyClient(KeyVaultClientBase): :mod:`azure.identity` :keyword api_version: version of the Key Vault API to use. Defaults to the most recent. :paramtype api_version: ~azure.keyvault.keys.ApiVersion - :keyword transport: transport to use. Defaults to :class:`~azure.core.pipeline.transport.RequestsTransport`. + :keyword transport: transport to use. :paramtype transport: ~azure.core.pipeline.transport.HttpTransport .. literalinclude:: ../tests/test_examples_crypto.py diff --git a/sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_client.py b/sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_client.py index ed3790c0a715..96aba1889aac 100644 --- a/sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_client.py +++ b/sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_client.py @@ -31,7 +31,7 @@ class SecretClient(KeyVaultClientBase): :mod:`azure.identity` :keyword api_version: version of the Key Vault API to use. Defaults to the most recent. :paramtype api_version: ~azure.keyvault.secrets.ApiVersion - :keyword transport: transport to use. Defaults to :class:`~azure.core.pipeline.transport.RequestsTransport`. + :keyword transport: transport to use. :paramtype transport: ~azure.core.pipeline.transport.HttpTransport Example: diff --git a/sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_shared/client_base.py b/sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_shared/client_base.py index e03e81b083b1..1c00aca19d6a 100644 --- a/sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_shared/client_base.py +++ b/sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_shared/client_base.py @@ -8,7 +8,6 @@ from six import with_metaclass from azure.core import CaseInsensitiveEnumMeta -from azure.core.pipeline.transport import RequestsTransport from azure.core.pipeline.policies import HttpLoggingPolicy from . import ChallengeAuthPolicy @@ -59,7 +58,7 @@ def __init__(self, vault_url, credential, **kwargs): return pipeline = kwargs.pop("pipeline", None) - transport = kwargs.pop("transport", RequestsTransport(**kwargs)) + transport = kwargs.pop("transport", None) http_logging_policy = HttpLoggingPolicy(**kwargs) http_logging_policy.allowed_header_names.update( {"x-ms-keyvault-network-info", "x-ms-keyvault-region", "x-ms-keyvault-service-version"} From 443c238f42d1c101fcac772ed81ab28e050c1d3e Mon Sep 17 00:00:00 2001 From: Steven Jin Date: Tue, 9 Aug 2022 11:11:04 -0700 Subject: [PATCH 2/3] trailing whitespace --- .../azure-keyvault-secrets/azure/keyvault/secrets/_client.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_client.py b/sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_client.py index 96aba1889aac..0afae1b38c4a 100644 --- a/sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_client.py +++ b/sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_client.py @@ -31,7 +31,7 @@ class SecretClient(KeyVaultClientBase): :mod:`azure.identity` :keyword api_version: version of the Key Vault API to use. Defaults to the most recent. :paramtype api_version: ~azure.keyvault.secrets.ApiVersion - :keyword transport: transport to use. + :keyword transport: transport to use. :paramtype transport: ~azure.core.pipeline.transport.HttpTransport Example: From 647431ba30c4846b2f9e62225631ddcb0e5b464a Mon Sep 17 00:00:00 2001 From: Steven Jin Date: Thu, 18 Aug 2022 13:11:45 -0700 Subject: [PATCH 3/3] remove all transport and pipeline references --- .../administration/_internal/async_client_base.py | 8 -------- .../keyvault/administration/_internal/client_base.py | 4 ---- .../azure/keyvault/certificates/_client.py | 2 -- .../keyvault/certificates/_shared/async_client_base.py | 9 --------- .../azure/keyvault/certificates/_shared/client_base.py | 4 ---- .../azure/keyvault/certificates/aio/_client.py | 3 --- .../azure-keyvault-keys/azure/keyvault/keys/_client.py | 2 -- .../azure/keyvault/keys/_shared/async_client_base.py | 9 --------- .../azure/keyvault/keys/_shared/client_base.py | 4 ---- .../azure/keyvault/keys/aio/_client.py | 3 --- .../azure/keyvault/keys/crypto/_client.py | 2 -- .../azure/keyvault/keys/crypto/aio/_client.py | 2 -- .../azure/keyvault/secrets/_client.py | 2 -- .../azure/keyvault/secrets/_shared/async_client_base.py | 9 --------- .../azure/keyvault/secrets/_shared/client_base.py | 4 ---- .../azure/keyvault/secrets/aio/_client.py | 3 --- 16 files changed, 70 deletions(-) diff --git a/sdk/keyvault/azure-keyvault-administration/azure/keyvault/administration/_internal/async_client_base.py b/sdk/keyvault/azure-keyvault-administration/azure/keyvault/administration/_internal/async_client_base.py index 7abdc777cee1..c91c8f129bba 100644 --- a/sdk/keyvault/azure-keyvault-administration/azure/keyvault/administration/_internal/async_client_base.py +++ b/sdk/keyvault/azure-keyvault-administration/azure/keyvault/administration/_internal/async_client_base.py @@ -40,8 +40,6 @@ def __init__(self, vault_url: str, credential: "AsyncTokenCredential", **kwargs: self._models = models or _KeyVaultClient.models(api_version=api_version) return - pipeline = kwargs.pop("pipeline", None) - transport = kwargs.pop("transport", None) http_logging_policy = HttpLoggingPolicy(**kwargs) http_logging_policy.allowed_header_names.update( { @@ -51,14 +49,8 @@ def __init__(self, vault_url: str, credential: "AsyncTokenCredential", **kwargs: } ) - if not transport and not pipeline: - from azure.core.pipeline.transport import AioHttpTransport - transport = AioHttpTransport(**kwargs) - self._client = _KeyVaultClient( api_version=api_version, - pipeline=pipeline, - transport=transport, authentication_policy=AsyncChallengeAuthPolicy(credential), sdk_moniker=SDK_MONIKER, http_logging_policy=http_logging_policy, diff --git a/sdk/keyvault/azure-keyvault-administration/azure/keyvault/administration/_internal/client_base.py b/sdk/keyvault/azure-keyvault-administration/azure/keyvault/administration/_internal/client_base.py index eaaf17b2306e..014ab82c0197 100644 --- a/sdk/keyvault/azure-keyvault-administration/azure/keyvault/administration/_internal/client_base.py +++ b/sdk/keyvault/azure-keyvault-administration/azure/keyvault/administration/_internal/client_base.py @@ -53,8 +53,6 @@ def __init__(self, vault_url, credential, **kwargs): self._models = models or _KeyVaultClient.models(api_version=api_version) return - pipeline = kwargs.pop("pipeline", None) - transport = kwargs.pop("transport", None) http_logging_policy = HttpLoggingPolicy(**kwargs) http_logging_policy.allowed_header_names.update( {"x-ms-keyvault-network-info", "x-ms-keyvault-region", "x-ms-keyvault-service-version"} @@ -62,8 +60,6 @@ def __init__(self, vault_url, credential, **kwargs): self._client = _KeyVaultClient( api_version=api_version, - pipeline=pipeline, - transport=transport, authentication_policy=ChallengeAuthPolicy(credential), sdk_moniker=SDK_MONIKER, http_logging_policy=http_logging_policy, diff --git a/sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/_client.py b/sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/_client.py index 5336a33973d9..6820879912c8 100644 --- a/sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/_client.py +++ b/sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/_client.py @@ -46,8 +46,6 @@ class CertificateClient(KeyVaultClientBase): :mod:`azure.identity` :keyword api_version: version of the Key Vault API to use. Defaults to the most recent. :paramtype api_version: ~azure.keyvault.certificates.ApiVersion - :keyword transport: transport to use. - :paramtype transport: ~azure.core.pipeline.transport.HttpTransport Example: .. literalinclude:: ../tests/test_examples_certificates.py diff --git a/sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/_shared/async_client_base.py b/sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/_shared/async_client_base.py index 5ca9701a0fac..2cf92dfada67 100644 --- a/sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/_shared/async_client_base.py +++ b/sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/_shared/async_client_base.py @@ -41,22 +41,13 @@ def __init__(self, vault_url: str, credential: "AsyncTokenCredential", **kwargs: self._models = models or _KeyVaultClient.models(api_version=self.api_version) return - pipeline = kwargs.pop("pipeline", None) - transport = kwargs.pop("transport", None) http_logging_policy = HttpLoggingPolicy(**kwargs) http_logging_policy.allowed_header_names.update( {"x-ms-keyvault-network-info", "x-ms-keyvault-region", "x-ms-keyvault-service-version"} ) - if not transport and not pipeline: - from azure.core.pipeline.transport import AioHttpTransport - - transport = AioHttpTransport(**kwargs) - self._client = _KeyVaultClient( api_version=self.api_version, - pipeline=pipeline, - transport=transport, authentication_policy=AsyncChallengeAuthPolicy(credential), sdk_moniker=SDK_MONIKER, http_logging_policy=http_logging_policy, diff --git a/sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/_shared/client_base.py b/sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/_shared/client_base.py index 1c00aca19d6a..e870b4d56cbd 100644 --- a/sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/_shared/client_base.py +++ b/sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/_shared/client_base.py @@ -57,8 +57,6 @@ def __init__(self, vault_url, credential, **kwargs): self._models = models or _KeyVaultClient.models(api_version=self.api_version) return - pipeline = kwargs.pop("pipeline", None) - transport = kwargs.pop("transport", None) http_logging_policy = HttpLoggingPolicy(**kwargs) http_logging_policy.allowed_header_names.update( {"x-ms-keyvault-network-info", "x-ms-keyvault-region", "x-ms-keyvault-service-version"} @@ -66,8 +64,6 @@ def __init__(self, vault_url, credential, **kwargs): self._client = _KeyVaultClient( api_version=self.api_version, - pipeline=pipeline, - transport=transport, authentication_policy=ChallengeAuthPolicy(credential), sdk_moniker=SDK_MONIKER, http_logging_policy=http_logging_policy, diff --git a/sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/aio/_client.py b/sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/aio/_client.py index b4742cf98ac1..40c8d751e2a1 100644 --- a/sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/aio/_client.py +++ b/sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/aio/_client.py @@ -37,9 +37,6 @@ class CertificateClient(AsyncKeyVaultClientBase): :mod:`azure.identity.aio` :keyword api_version: version of the Key Vault API to use. Defaults to the most recent. :paramtype api_version: ~azure.keyvault.certificates.ApiVersion - :keyword transport: transport to use. Defaults to - :class:`~azure.core.pipeline.transport.AioHttpTransport`. - :paramtype transport: ~azure.core.pipeline.transport.AsyncHttpTransport Example: .. literalinclude:: ../tests/test_examples_certificates_async.py diff --git a/sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/_client.py b/sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/_client.py index 3ae210c77341..04e96630e611 100644 --- a/sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/_client.py +++ b/sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/_client.py @@ -39,8 +39,6 @@ class KeyClient(KeyVaultClientBase): :keyword api_version: version of the Key Vault API to use. Defaults to the most recent. :paramtype api_version: ~azure.keyvault.keys.ApiVersion - :keyword transport: transport to use. - :paramtype transport: ~azure.core.pipeline.transport.HttpTransport Example: .. literalinclude:: ../tests/test_samples_keys.py diff --git a/sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/_shared/async_client_base.py b/sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/_shared/async_client_base.py index 5ca9701a0fac..2cf92dfada67 100644 --- a/sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/_shared/async_client_base.py +++ b/sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/_shared/async_client_base.py @@ -41,22 +41,13 @@ def __init__(self, vault_url: str, credential: "AsyncTokenCredential", **kwargs: self._models = models or _KeyVaultClient.models(api_version=self.api_version) return - pipeline = kwargs.pop("pipeline", None) - transport = kwargs.pop("transport", None) http_logging_policy = HttpLoggingPolicy(**kwargs) http_logging_policy.allowed_header_names.update( {"x-ms-keyvault-network-info", "x-ms-keyvault-region", "x-ms-keyvault-service-version"} ) - if not transport and not pipeline: - from azure.core.pipeline.transport import AioHttpTransport - - transport = AioHttpTransport(**kwargs) - self._client = _KeyVaultClient( api_version=self.api_version, - pipeline=pipeline, - transport=transport, authentication_policy=AsyncChallengeAuthPolicy(credential), sdk_moniker=SDK_MONIKER, http_logging_policy=http_logging_policy, diff --git a/sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/_shared/client_base.py b/sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/_shared/client_base.py index 1c00aca19d6a..e870b4d56cbd 100644 --- a/sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/_shared/client_base.py +++ b/sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/_shared/client_base.py @@ -57,8 +57,6 @@ def __init__(self, vault_url, credential, **kwargs): self._models = models or _KeyVaultClient.models(api_version=self.api_version) return - pipeline = kwargs.pop("pipeline", None) - transport = kwargs.pop("transport", None) http_logging_policy = HttpLoggingPolicy(**kwargs) http_logging_policy.allowed_header_names.update( {"x-ms-keyvault-network-info", "x-ms-keyvault-region", "x-ms-keyvault-service-version"} @@ -66,8 +64,6 @@ def __init__(self, vault_url, credential, **kwargs): self._client = _KeyVaultClient( api_version=self.api_version, - pipeline=pipeline, - transport=transport, authentication_policy=ChallengeAuthPolicy(credential), sdk_moniker=SDK_MONIKER, http_logging_policy=http_logging_policy, diff --git a/sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/aio/_client.py b/sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/aio/_client.py index d1d6a44ec7a4..077e29ee62d7 100644 --- a/sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/aio/_client.py +++ b/sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/aio/_client.py @@ -38,9 +38,6 @@ class KeyClient(AsyncKeyVaultClientBase): :keyword api_version: version of the Key Vault API to use. Defaults to the most recent. :paramtype api_version: ~azure.keyvault.keys.ApiVersion - :keyword transport: transport to use. Defaults to - :class:`~azure.core.pipeline.transport.AioHttpTransport`. - :paramtype transport: ~azure.core.pipeline.transport.AsyncHttpTransport Example: .. literalinclude:: ../tests/test_samples_keys_async.py diff --git a/sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/crypto/_client.py b/sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/crypto/_client.py index 52e810c38ccf..e32e98308883 100644 --- a/sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/crypto/_client.py +++ b/sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/crypto/_client.py @@ -93,8 +93,6 @@ class CryptographyClient(KeyVaultClientBase): :mod:`azure.identity` :keyword api_version: version of the Key Vault API to use. Defaults to the most recent. :paramtype api_version: ~azure.keyvault.keys.ApiVersion - :keyword transport: transport to use. - :paramtype transport: ~azure.core.pipeline.transport.HttpTransport .. literalinclude:: ../tests/test_examples_crypto.py :start-after: [START create_client] diff --git a/sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/crypto/aio/_client.py b/sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/crypto/aio/_client.py index 3857bd3ea751..c914e0599068 100644 --- a/sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/crypto/aio/_client.py +++ b/sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/crypto/aio/_client.py @@ -43,8 +43,6 @@ class CryptographyClient(AsyncKeyVaultClientBase): :mod:`azure.identity.aio` :keyword api_version: version of the Key Vault API to use. Defaults to the most recent. :paramtype api_version: ~azure.keyvault.keys.ApiVersion - :keyword transport: transport to use. Defaults to :class:`~azure.core.pipeline.transport.AioHttpTransport`. - :paramtype transport: ~azure.core.pipeline.transport.AsyncHttpTransport .. literalinclude:: ../tests/test_examples_crypto_async.py :start-after: [START create_client] diff --git a/sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_client.py b/sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_client.py index 0afae1b38c4a..8d10b986f91c 100644 --- a/sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_client.py +++ b/sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_client.py @@ -31,8 +31,6 @@ class SecretClient(KeyVaultClientBase): :mod:`azure.identity` :keyword api_version: version of the Key Vault API to use. Defaults to the most recent. :paramtype api_version: ~azure.keyvault.secrets.ApiVersion - :keyword transport: transport to use. - :paramtype transport: ~azure.core.pipeline.transport.HttpTransport Example: .. literalinclude:: ../tests/test_samples_secrets.py diff --git a/sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_shared/async_client_base.py b/sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_shared/async_client_base.py index 5ca9701a0fac..2cf92dfada67 100644 --- a/sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_shared/async_client_base.py +++ b/sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_shared/async_client_base.py @@ -41,22 +41,13 @@ def __init__(self, vault_url: str, credential: "AsyncTokenCredential", **kwargs: self._models = models or _KeyVaultClient.models(api_version=self.api_version) return - pipeline = kwargs.pop("pipeline", None) - transport = kwargs.pop("transport", None) http_logging_policy = HttpLoggingPolicy(**kwargs) http_logging_policy.allowed_header_names.update( {"x-ms-keyvault-network-info", "x-ms-keyvault-region", "x-ms-keyvault-service-version"} ) - if not transport and not pipeline: - from azure.core.pipeline.transport import AioHttpTransport - - transport = AioHttpTransport(**kwargs) - self._client = _KeyVaultClient( api_version=self.api_version, - pipeline=pipeline, - transport=transport, authentication_policy=AsyncChallengeAuthPolicy(credential), sdk_moniker=SDK_MONIKER, http_logging_policy=http_logging_policy, diff --git a/sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_shared/client_base.py b/sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_shared/client_base.py index 1c00aca19d6a..e870b4d56cbd 100644 --- a/sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_shared/client_base.py +++ b/sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_shared/client_base.py @@ -57,8 +57,6 @@ def __init__(self, vault_url, credential, **kwargs): self._models = models or _KeyVaultClient.models(api_version=self.api_version) return - pipeline = kwargs.pop("pipeline", None) - transport = kwargs.pop("transport", None) http_logging_policy = HttpLoggingPolicy(**kwargs) http_logging_policy.allowed_header_names.update( {"x-ms-keyvault-network-info", "x-ms-keyvault-region", "x-ms-keyvault-service-version"} @@ -66,8 +64,6 @@ def __init__(self, vault_url, credential, **kwargs): self._client = _KeyVaultClient( api_version=self.api_version, - pipeline=pipeline, - transport=transport, authentication_policy=ChallengeAuthPolicy(credential), sdk_moniker=SDK_MONIKER, http_logging_policy=http_logging_policy, diff --git a/sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/aio/_client.py b/sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/aio/_client.py index 7f71232c2f98..9ce3766aa9aa 100644 --- a/sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/aio/_client.py +++ b/sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/aio/_client.py @@ -23,9 +23,6 @@ class SecretClient(AsyncKeyVaultClientBase): :mod:`azure.identity.aio` :keyword api_version: version of the Key Vault API to use. Defaults to the most recent. :paramtype api_version: ~azure.keyvault.secrets.ApiVersion - :keyword transport: transport to use. Defaults to - :class:`~azure.core.pipeline.transport.AioHttpTransport`. - :paramtype transport: ~azure.core.pipeline.transport.AsyncHttpTransport Example: .. literalinclude:: ../tests/test_samples_secrets_async.py