From 7d3ca7c4086e0350838f04304214fa983346cbd0 Mon Sep 17 00:00:00 2001 From: Wonhyeong Seo Date: Sun, 28 Aug 2022 15:22:13 +0900 Subject: [PATCH 1/2] fix: typos in language-spellcheck Co-authored-by: Dohyeon Kim --- .vscode/cspell.json | 1 - .../azure-cognitiveservices-language-spellcheck/CHANGELOG.md | 2 +- .../tests/test_spell_check.py | 5 +++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.vscode/cspell.json b/.vscode/cspell.json index cc5464888fa2..499b5bf2354f 100644 --- a/.vscode/cspell.json +++ b/.vscode/cspell.json @@ -34,7 +34,6 @@ "sdk/batch/azure-batch/**", "sdk/cognitivelanguage/azure-ai-language-questionanswering/**", "sdk/cognitivelanguage/azure-ai-language-conversations/**", - "sdk/cognitiveservices/azure-cognitiveservices-language-spellcheck/**", "sdk/cognitiveservices/azure-cognitiveservices-search-autosuggest/**", "sdk/cognitiveservices/azure-cognitiveservices-search-customimagesearch/**", "sdk/cognitiveservices/azure-cognitiveservices-search-customsearch/**", diff --git a/sdk/cognitiveservices/azure-cognitiveservices-language-spellcheck/CHANGELOG.md b/sdk/cognitiveservices/azure-cognitiveservices-language-spellcheck/CHANGELOG.md index 32bb84ff0c3f..b9b187f3228a 100644 --- a/sdk/cognitiveservices/azure-cognitiveservices-language-spellcheck/CHANGELOG.md +++ b/sdk/cognitiveservices/azure-cognitiveservices-language-spellcheck/CHANGELOG.md @@ -54,7 +54,7 @@ introduce breaking changes. - "is" should not be used at all. - "format" will return the string value, where "%s" string formatting will return `NameOfEnum.stringvalue`. Format syntax - should be prefered. + should be preferred. - New Long Running Operation: - Return type changes from `msrestazure.azure_operation.AzureOperationPoller` to diff --git a/sdk/cognitiveservices/azure-cognitiveservices-language-spellcheck/tests/test_spell_check.py b/sdk/cognitiveservices/azure-cognitiveservices-language-spellcheck/tests/test_spell_check.py index e662251adf2c..cd5c3a6928ad 100644 --- a/sdk/cognitiveservices/azure-cognitiveservices-language-spellcheck/tests/test_spell_check.py +++ b/sdk/cognitiveservices/azure-cognitiveservices-language-spellcheck/tests/test_spell_check.py @@ -20,6 +20,7 @@ class SpellCheckTest(ReplayableTest): + # spell-checker:ignore Apim FILTER_HEADERS = ReplayableTest.FILTER_HEADERS + ['Ocp-Apim-Subscription-Key'] def __init__(self, method_name): @@ -50,9 +51,9 @@ def test_spell_check(self): ) text_analytics = SpellCheckClient(credentials=credentials) response = text_analytics.spell_checker( - "cognituve services" + "cognitive services" ) - self.assertEqual(response.flagged_tokens[0].token, "cognituve") + self.assertEqual(response.flagged_tokens[0].token, "cognitive") self.assertEqual(response.flagged_tokens[0].suggestions[0].suggestion, "cognitive") From 275883fd7c6ce7f68cd074efd44e99f0c539cef0 Mon Sep 17 00:00:00 2001 From: Wonhyeong Seo Date: Wed, 31 Aug 2022 12:27:56 +0900 Subject: [PATCH 2/2] fix: revert test and add local ignore list to cspell.json --- .vscode/cspell.json | 4 ++++ .../tests/test_spell_check.py | 5 ++--- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/.vscode/cspell.json b/.vscode/cspell.json index a6e730019309..42bb4bef7593 100644 --- a/.vscode/cspell.json +++ b/.vscode/cspell.json @@ -421,6 +421,10 @@ "filename": "sdk/cognitivelanguage/azure-ai-language-questionanswering/tests/test_query_text*.py", "words": ["groovin", "Olufsen"] }, + { + "filename": "sdk/cognitiveservices/azure-cognitiveservices-language-spellcheck/tests/*.py", + "words": ["Apim", "cognituve"] + }, { "filename": "sdk/communication/**", "words": [ diff --git a/sdk/cognitiveservices/azure-cognitiveservices-language-spellcheck/tests/test_spell_check.py b/sdk/cognitiveservices/azure-cognitiveservices-language-spellcheck/tests/test_spell_check.py index cd5c3a6928ad..e662251adf2c 100644 --- a/sdk/cognitiveservices/azure-cognitiveservices-language-spellcheck/tests/test_spell_check.py +++ b/sdk/cognitiveservices/azure-cognitiveservices-language-spellcheck/tests/test_spell_check.py @@ -20,7 +20,6 @@ class SpellCheckTest(ReplayableTest): - # spell-checker:ignore Apim FILTER_HEADERS = ReplayableTest.FILTER_HEADERS + ['Ocp-Apim-Subscription-Key'] def __init__(self, method_name): @@ -51,9 +50,9 @@ def test_spell_check(self): ) text_analytics = SpellCheckClient(credentials=credentials) response = text_analytics.spell_checker( - "cognitive services" + "cognituve services" ) - self.assertEqual(response.flagged_tokens[0].token, "cognitive") + self.assertEqual(response.flagged_tokens[0].token, "cognituve") self.assertEqual(response.flagged_tokens[0].suggestions[0].suggestion, "cognitive")