From 2bbe8023dfe764351a4b2379ad50e99c139fdfe9 Mon Sep 17 00:00:00 2001 From: praveenkuttappan Date: Thu, 17 Nov 2022 12:45:37 -0500 Subject: [PATCH 1/2] Enforce Package name approval for preview release --- eng/scripts/Create-ApiReview.ps1 | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/eng/scripts/Create-ApiReview.ps1 b/eng/scripts/Create-ApiReview.ps1 index 9465990a5789..8ceca52db109 100644 --- a/eng/scripts/Create-ApiReview.ps1 +++ b/eng/scripts/Create-ApiReview.ps1 @@ -117,6 +117,13 @@ function ProcessPackage($PackageName) } elseif ($version.IsPrerelease) { + # Check if package name is approved. Preview version cannot be released without package name approval + if ($respCode -eq '202' -and $pkgInfo.ReleaseStatus -and $pkgInfo.ReleaseStatus -ne "Unreleased") + { + Write-Host "Package $($PackageName) is not yet approved on APIView for preview release. Package approval for beta relase must be completed by an API approver if it was never released as a stable version." + Write-Host "You can check http://aka.ms/azsdk/engsys/apireview/faq for more details on package name approval." + exit 1 + } # Ignore API review status for prerelease version Write-Host "Package version is not GA. Ignoring API view approval status" } From faacf71f624abbb94a66c08e69062be4623f8c47 Mon Sep 17 00:00:00 2001 From: Praven Kuttappan <55455725+praveenkuttappan@users.noreply.github.com> Date: Thu, 17 Nov 2022 17:10:14 -0500 Subject: [PATCH 2/2] Apply suggestions from code review Co-authored-by: Ben Broderick Phillips --- eng/scripts/Create-ApiReview.ps1 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/eng/scripts/Create-ApiReview.ps1 b/eng/scripts/Create-ApiReview.ps1 index 8ceca52db109..2606710847e1 100644 --- a/eng/scripts/Create-ApiReview.ps1 +++ b/eng/scripts/Create-ApiReview.ps1 @@ -120,8 +120,8 @@ function ProcessPackage($PackageName) # Check if package name is approved. Preview version cannot be released without package name approval if ($respCode -eq '202' -and $pkgInfo.ReleaseStatus -and $pkgInfo.ReleaseStatus -ne "Unreleased") { - Write-Host "Package $($PackageName) is not yet approved on APIView for preview release. Package approval for beta relase must be completed by an API approver if it was never released as a stable version." - Write-Host "You can check http://aka.ms/azsdk/engsys/apireview/faq for more details on package name approval." + Write-Error "Package '$PackageName' is not yet approved on APIView for preview release. Package approval for beta relase must be completed by an API approver if it was never released as a stable version." + Write-Error "You can check http://aka.ms/azsdk/engsys/apireview/faq for more details on package name approval." exit 1 } # Ignore API review status for prerelease version