From ce86d7a841aa8ee013a7c47db787a3f77509e41d Mon Sep 17 00:00:00 2001 From: xiangyan99 Date: Fri, 6 Oct 2023 18:08:54 -0700 Subject: [PATCH 1/2] remove broker support --- sdk/identity/azure-identity/CHANGELOG.md | 4 ++++ .../azure/identity/_internal/msal_credentials.py | 7 ------- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/sdk/identity/azure-identity/CHANGELOG.md b/sdk/identity/azure-identity/CHANGELOG.md index 3b299ca5942e..1da5770e9c64 100644 --- a/sdk/identity/azure-identity/CHANGELOG.md +++ b/sdk/identity/azure-identity/CHANGELOG.md @@ -8,6 +8,10 @@ ### Breaking Changes +> These changes do not impact the API of stable versions such as 1.14.0. +> Only code written against a beta version such as 1.15.0b1 may be affected. +- Windows Web Account Manager (WAM) Brokered Authentication is moved into another package. + ### Bugs Fixed - `ManagedIdentityCredential` will now correctly retry when the instance metadata endpoint returns a 410 response. ([#32200](https://github.com/Azure/azure-sdk-for-python/pull/32200)) diff --git a/sdk/identity/azure-identity/azure/identity/_internal/msal_credentials.py b/sdk/identity/azure-identity/azure/identity/_internal/msal_credentials.py index 28f2e279a52c..68db6b5fc362 100644 --- a/sdk/identity/azure-identity/azure/identity/_internal/msal_credentials.py +++ b/sdk/identity/azure-identity/azure/identity/_internal/msal_credentials.py @@ -27,9 +27,6 @@ def __init__( client_credential: Optional[Union[str, Dict]] = None, *, additionally_allowed_tenants: Optional[List[str]] = None, - allow_broker: Optional[bool] = None, - parent_window_handle: Optional[int] = None, - enable_msa_passthrough: Optional[bool] = None, authority: Optional[str] = None, disable_instance_discovery: Optional[bool] = None, tenant_id: Optional[str] = None, @@ -46,9 +43,6 @@ def __init__( self._client = MsalClient(**kwargs) self._client_credential = client_credential self._client_id = client_id - self._allow_broker = allow_broker - self._parent_window_handle = parent_window_handle - self._enable_msa_passthrough = enable_msa_passthrough self._enable_support_logging = enable_support_logging self._additionally_allowed_tenants = additionally_allowed_tenants or [] @@ -114,7 +108,6 @@ def _get_app(self, **kwargs: Any) -> msal.ClientApplication: token_cache=token_cache, http_client=self._client, instance_discovery=self._instance_discovery, - allow_broker=self._allow_broker, enable_pii_log=self._enable_support_logging, ) From cfb57556503305fd02c419c40150bbf1b3a19a1f Mon Sep 17 00:00:00 2001 From: xiangyan99 Date: Fri, 6 Oct 2023 18:32:56 -0700 Subject: [PATCH 2/2] update --- .../azure-identity/azure/identity/_credentials/browser.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/sdk/identity/azure-identity/azure/identity/_credentials/browser.py b/sdk/identity/azure-identity/azure/identity/_credentials/browser.py index cab504513c5d..956d33dffab5 100644 --- a/sdk/identity/azure-identity/azure/identity/_credentials/browser.py +++ b/sdk/identity/azure-identity/azure/identity/_credentials/browser.py @@ -138,8 +138,6 @@ def _request_token(self, *scopes: str, **kwargs: Any) -> Dict: timeout=self._timeout, prompt="select_account", port=port, - parent_window_handle=self._parent_window_handle, - enable_msa_passthrough=self._enable_msa_passthrough, ) except socket.error as ex: raise CredentialUnavailableError(message="Couldn't start an HTTP server.") from ex