From e5374a13b972f4a2f712346f4a07703d15749722 Mon Sep 17 00:00:00 2001 From: M-Hietala <78813398+M-Hietala@users.noreply.github.com> Date: Tue, 13 May 2025 14:03:07 -0500 Subject: [PATCH 1/3] removing instrumentor call for azure monitor samples --- .../agents_multiagent/utils/agent_trace_configurator.py | 8 -------- ...ple_agents_basics_async_with_azure_monitor_tracing.py | 9 --------- .../sample_agents_basics_with_azure_monitor_tracing.py | 9 --------- ...nts_stream_eventhandler_with_azure_monitor_tracing.py | 9 --------- .../sample_agents_toolset_with_azure_monitor_tracing.py | 9 --------- 5 files changed, 44 deletions(-) diff --git a/sdk/ai/azure-ai-agents/samples/agents_multiagent/utils/agent_trace_configurator.py b/sdk/ai/azure-ai-agents/samples/agents_multiagent/utils/agent_trace_configurator.py index 8ba54dc149eb..7c03cb453d58 100644 --- a/sdk/ai/azure-ai-agents/samples/agents_multiagent/utils/agent_trace_configurator.py +++ b/sdk/ai/azure-ai-agents/samples/agents_multiagent/utils/agent_trace_configurator.py @@ -25,14 +25,6 @@ def enable_azure_monitor_tracing(self): print("Enable it via the 'Tracing' tab in your AI Foundry project page.") exit() configure_azure_monitor(connection_string=application_insights_connection_string) - try: - from azure.ai.agents.telemetry import AIAgentsInstrumentor - - agents_instrumentor = AIAgentsInstrumentor() - if not agents_instrumentor.is_instrumented(): - agents_instrumentor.instrument() - except Exception as exc: # pylint: disable=broad-exception-caught - print(f"Could not call `AIAgentsInstrumentor().instrument()`. Exception: {exc}") def enable_console_tracing_without_genai(self): exporter = ConsoleSpanExporter() diff --git a/sdk/ai/azure-ai-agents/samples/agents_telemetry/sample_agents_basics_async_with_azure_monitor_tracing.py b/sdk/ai/azure-ai-agents/samples/agents_telemetry/sample_agents_basics_async_with_azure_monitor_tracing.py index 09da43a6ca7c..69e938c24a29 100644 --- a/sdk/ai/azure-ai-agents/samples/agents_telemetry/sample_agents_basics_async_with_azure_monitor_tracing.py +++ b/sdk/ai/azure-ai-agents/samples/agents_telemetry/sample_agents_basics_async_with_azure_monitor_tracing.py @@ -52,15 +52,6 @@ async def main() -> None: application_insights_connection_string = os.environ["APPLICATIONINSIGHTS_CONNECTION_STRING"] configure_azure_monitor(connection_string=application_insights_connection_string) - try: - from azure.ai.agents.telemetry import AIAgentsInstrumentor - - agents_instrumentor = AIAgentsInstrumentor() - if not agents_instrumentor.is_instrumented(): - agents_instrumentor.instrument() - except Exception as exc: # pylint: disable=broad-exception-caught - print(f"Could not call `AIAgentsInstrumentor().instrument()`. Exception: {exc}") - with tracer.start_as_current_span(scenario): async with agents_client: agent = await agents_client.create_agent( diff --git a/sdk/ai/azure-ai-agents/samples/agents_telemetry/sample_agents_basics_with_azure_monitor_tracing.py b/sdk/ai/azure-ai-agents/samples/agents_telemetry/sample_agents_basics_with_azure_monitor_tracing.py index 517cb4820dfd..53432a8fc38e 100644 --- a/sdk/ai/azure-ai-agents/samples/agents_telemetry/sample_agents_basics_with_azure_monitor_tracing.py +++ b/sdk/ai/azure-ai-agents/samples/agents_telemetry/sample_agents_basics_with_azure_monitor_tracing.py @@ -46,15 +46,6 @@ application_insights_connection_string = os.environ["APPLICATIONINSIGHTS_CONNECTION_STRING"] configure_azure_monitor(connection_string=application_insights_connection_string) -try: - from azure.ai.agents.telemetry import AIAgentsInstrumentor - - agents_instrumentor = AIAgentsInstrumentor() - if not agents_instrumentor.is_instrumented(): - agents_instrumentor.instrument() -except Exception as exc: # pylint: disable=broad-exception-caught - print(f"Could not call `AIAgentsInstrumentor().instrument()`. Exception: {exc}") - scenario = os.path.basename(__file__) tracer = trace.get_tracer(__name__) diff --git a/sdk/ai/azure-ai-agents/samples/agents_telemetry/sample_agents_stream_eventhandler_with_azure_monitor_tracing.py b/sdk/ai/azure-ai-agents/samples/agents_telemetry/sample_agents_stream_eventhandler_with_azure_monitor_tracing.py index 984aa21910e3..97a053a8c4e5 100644 --- a/sdk/ai/azure-ai-agents/samples/agents_telemetry/sample_agents_stream_eventhandler_with_azure_monitor_tracing.py +++ b/sdk/ai/azure-ai-agents/samples/agents_telemetry/sample_agents_stream_eventhandler_with_azure_monitor_tracing.py @@ -82,15 +82,6 @@ def on_unhandled_event(self, event_type: str, event_data: Any) -> None: application_insights_connection_string = os.environ["APPLICATIONINSIGHTS_CONNECTION_STRING"] configure_azure_monitor(connection_string=application_insights_connection_string) -try: - from azure.ai.agents.telemetry import AIAgentsInstrumentor - - agents_instrumentor = AIAgentsInstrumentor() - if not agents_instrumentor.is_instrumented(): - agents_instrumentor.instrument() -except Exception as exc: # pylint: disable=broad-exception-caught - print(f"Could not call `AIAgentsInstrumentor().instrument()`. Exception: {exc}") - scenario = os.path.basename(__file__) tracer = trace.get_tracer(__name__) diff --git a/sdk/ai/azure-ai-agents/samples/agents_telemetry/sample_agents_toolset_with_azure_monitor_tracing.py b/sdk/ai/azure-ai-agents/samples/agents_telemetry/sample_agents_toolset_with_azure_monitor_tracing.py index 9b5711752952..10ad351fafe2 100644 --- a/sdk/ai/azure-ai-agents/samples/agents_telemetry/sample_agents_toolset_with_azure_monitor_tracing.py +++ b/sdk/ai/azure-ai-agents/samples/agents_telemetry/sample_agents_toolset_with_azure_monitor_tracing.py @@ -50,15 +50,6 @@ application_insights_connection_string = os.environ["APPLICATIONINSIGHTS_CONNECTION_STRING"] configure_azure_monitor(connection_string=application_insights_connection_string) -try: - from azure.ai.agents.telemetry import AIAgentsInstrumentor - - agents_instrumentor = AIAgentsInstrumentor() - if not agents_instrumentor.is_instrumented(): - agents_instrumentor.instrument() -except Exception as exc: # pylint: disable=broad-exception-caught - print(f"Could not call `AIAgentsInstrumentor().instrument()`. Exception: {exc}") - scenario = os.path.basename(__file__) tracer = trace.get_tracer(__name__) From 17a1c87f62c278a4721f518e0ee7cfc3ae4322b9 Mon Sep 17 00:00:00 2001 From: M-Hietala <78813398+M-Hietala@users.noreply.github.com> Date: Tue, 13 May 2025 14:59:27 -0500 Subject: [PATCH 2/3] updating code snippet --- sdk/ai/azure-ai-agents/README.md | 9 --------- 1 file changed, 9 deletions(-) diff --git a/sdk/ai/azure-ai-agents/README.md b/sdk/ai/azure-ai-agents/README.md index 6c66cdb234a0..f1d29e780e96 100644 --- a/sdk/ai/azure-ai-agents/README.md +++ b/sdk/ai/azure-ai-agents/README.md @@ -1143,15 +1143,6 @@ from azure.monitor.opentelemetry import configure_azure_monitor application_insights_connection_string = os.environ["APPLICATIONINSIGHTS_CONNECTION_STRING"] configure_azure_monitor(connection_string=application_insights_connection_string) -try: - from azure.ai.agents.telemetry import AIAgentsInstrumentor - - agents_instrumentor = AIAgentsInstrumentor() - if not agents_instrumentor.is_instrumented(): - agents_instrumentor.instrument() -except Exception as exc: # pylint: disable=broad-exception-caught - print(f"Could not call `AIAgentsInstrumentor().instrument()`. Exception: {exc}") - scenario = os.path.basename(__file__) tracer = trace.get_tracer(__name__) From 9e6214786d0278a6179f19bd4abf650a01110f38 Mon Sep 17 00:00:00 2001 From: M-Hietala <78813398+M-Hietala@users.noreply.github.com> Date: Tue, 13 May 2025 15:39:01 -0500 Subject: [PATCH 3/3] removing unused import from sample to restart build --- .../sample_agents_basics_with_azure_monitor_tracing.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/ai/azure-ai-agents/samples/agents_telemetry/sample_agents_basics_with_azure_monitor_tracing.py b/sdk/ai/azure-ai-agents/samples/agents_telemetry/sample_agents_basics_with_azure_monitor_tracing.py index 53432a8fc38e..9d8ecaea9a6c 100644 --- a/sdk/ai/azure-ai-agents/samples/agents_telemetry/sample_agents_basics_with_azure_monitor_tracing.py +++ b/sdk/ai/azure-ai-agents/samples/agents_telemetry/sample_agents_basics_with_azure_monitor_tracing.py @@ -28,7 +28,7 @@ can be found in the `sample_telemetry.py` file in the azure-ai-projects telemetry samples. """ -import os, time +import os from azure.ai.agents import AgentsClient from azure.ai.agents.models import ListSortOrder from azure.identity import DefaultAzureCredential