cloudprovider_test.go

/*
Portions Copyright (c) Microsoft Corporation.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

    http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package cloudprovider

import (
	"context"
	"testing"
	"time"

	"github.com/Azure/azure-sdk-for-go/sdk/azcore/to"
	"github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/compute/armcompute/v7"
	. "github.com/onsi/gomega"
	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
)

func TestGenerateNodeClaimName(t *testing.T) {
	tests := []struct {
		name     string
		vmName   string
		expected string
	}{
		{
			name:     "basic",
			vmName:   "aks-default-a1b2c",
			expected: "default-a1b2c",
		},
		{
			name:     "dashes nodepool name",
			vmName:   "aks-node-pool-name-a1b2c",
			expected: "node-pool-name-a1b2c",
		},
		{
			name:     "aks",
			vmName:   "aks-aks-default-a1b2c",
			expected: "aks-default-a1b2c",
		},
	}

	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			g := NewWithT(t)

			result := GetNodeClaimNameFromVMName(tt.vmName)
			g.Expect(result).To(Equal(tt.expected))
		})
	}
}

func TestVmInstanceToNodeClaim_NilProperties(t *testing.T) {
	tests := []struct {
		name                string
		vm                  *armcompute.VirtualMachine
		expectFallbackToNow bool
		expectExactTime     *time.Time
	}{
		{
			name: "nil Properties - fallback to time.Now()",
			vm: &armcompute.VirtualMachine{
				Name: to.Ptr("aks-test-vm"),
				ID:   to.Ptr("/subscriptions/sub/resourceGroups/rg/providers/Microsoft.Compute/virtualMachines/aks-test-vm"),
			},
			expectFallbackToNow: true,
		},
		{
			name: "nil TimeCreated - fallback to time.Now()",
			vm: &armcompute.VirtualMachine{
				Name:       to.Ptr("aks-test-vm"),
				ID:         to.Ptr("/subscriptions/sub/resourceGroups/rg/providers/Microsoft.Compute/virtualMachines/aks-test-vm"),
				Properties: &armcompute.VirtualMachineProperties{},
			},
			expectFallbackToNow: true,
		},
		{
			name: "valid TimeCreated - use exact time",
			vm: &armcompute.VirtualMachine{
				Name: to.Ptr("aks-test-vm"),
				ID:   to.Ptr("/subscriptions/sub/resourceGroups/rg/providers/Microsoft.Compute/virtualMachines/aks-test-vm"),
				Properties: &armcompute.VirtualMachineProperties{
					TimeCreated: to.Ptr(time.Date(2024, 1, 1, 0, 0, 0, 0, time.UTC)),
				},
			},
			expectExactTime: to.Ptr(time.Date(2024, 1, 1, 0, 0, 0, 0, time.UTC)),
		},
	}

	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			g := NewWithT(t)
			ctx := context.Background()

			cp := &CloudProvider{}
			before := time.Now()
			nodeClaim, err := cp.vmInstanceToNodeClaim(ctx, tt.vm, nil)
			after := time.Now()

			g.Expect(err).ToNot(HaveOccurred())
			g.Expect(nodeClaim).ToNot(BeNil())
			g.Expect(nodeClaim.CreationTimestamp).ToNot(Equal(metav1.Time{}))

			if tt.expectFallbackToNow {
				// When TimeCreated is unavailable, should fallback to time.Now() for GC safety
				g.Expect(nodeClaim.CreationTimestamp.Time).To(BeTemporally(">=", before))
				g.Expect(nodeClaim.CreationTimestamp.Time).To(BeTemporally("<=", after))
			}

			if tt.expectExactTime != nil {
				// When TimeCreated is available, should use the exact time from VM
				g.Expect(nodeClaim.CreationTimestamp.Time).To(Equal(*tt.expectExactTime))
			}
		})
	}
}