refactor: rename instance.InstancePromise to instance.Promise

Author: comtalyst

pkg/cloudprovider/cloudprovider.go

@@ -175,7 +175,7 @@ func (c *CloudProvider) createVMInstance(ctx context.Context, nodeClass *v1beta1
 }
 
 // handleInstancePromise handles the instance promise, primarily deciding on sync/async provisioning.
-func (c *CloudProvider) handleInstancePromise(ctx context.Context, instancePromise instance.InstancePromise, nodeClaim *karpv1.NodeClaim) error {
+func (c *CloudProvider) handleInstancePromise(ctx context.Context, instancePromise instance.Promise, nodeClaim *karpv1.NodeClaim) error {
 	if isNodeClaimStandalone(nodeClaim) {
 		// Standalone NodeClaims aren't re-queued for reconciliation in the provision_trigger controller,
 		// so we delete them synchronously. After marking Launched=true,
@@ -230,7 +230,7 @@ func (c *CloudProvider) handleInstancePromise(ctx context.Context, instancePromi
 	return nil
 }
 
-func (c *CloudProvider) handleInstancePromiseWaitError(ctx context.Context, instancePromise instance.InstancePromise, nodeClaim *karpv1.NodeClaim, waitErr error) {
+func (c *CloudProvider) handleInstancePromiseWaitError(ctx context.Context, instancePromise instance.Promise, nodeClaim *karpv1.NodeClaim, waitErr error) {
 	c.recorder.Publish(cloudproviderevents.NodeClaimFailedToRegister(nodeClaim, waitErr))
 	log.FromContext(ctx).Error(waitErr, "failed launching nodeclaim")
 

pkg/providers/instance/instancepromise.go

@@ -21,7 +21,7 @@ import (
 )
 
 // Intended for lifecycle handling on the higher abstractions.
-type InstancePromise interface {
+type Promise interface {
 	// Cleanup removes the instance from the cloud provider.
 	Cleanup(ctx context.Context) error
 	// Wait blocks until the instance is ready.