refactor: separate function for setting additional NodeClaim annotations

Author: comtalyst

pkg/cloudprovider/cloudprovider.go

@@ -188,15 +188,9 @@ func (c *CloudProvider) Create(ctx context.Context, nodeClaim *karpv1.NodeClaim)
 	if err != nil {
 		return nil, err
 	}
-	inPlaceUpdateHash, err := inplaceupdate.HashFromNodeClaim(options.FromContext(ctx), nc, nodeClass)
-	if err != nil {
-		return nil, fmt.Errorf("failed to calculate in place update hash, %w", err)
+	if err := setAdditionalAnnotationsForNewNodeClaim(ctx, nc, nodeClass); err != nil {
+		return nil, err
 	}
-	nc.Annotations = lo.Assign(nc.Annotations, map[string]string{
-		v1beta1.AnnotationAKSNodeClassHash:        nodeClass.Hash(),
-		v1beta1.AnnotationAKSNodeClassHashVersion: v1beta1.AKSNodeClassHashVersion,
-		v1beta1.AnnotationInPlaceUpdateHash:       inPlaceUpdateHash,
-	})
 	return nc, nil
 }
 
@@ -526,3 +520,19 @@ func truncateMessage(msg string) string {
 	}
 	return msg[:truncateAt] + "..."
 }
+
+func setAdditionalAnnotationsForNewNodeClaim(ctx context.Context, nodeClaim *karpv1.NodeClaim, nodeClass *v1beta1.AKSNodeClass) error {
+	// Additional annotations
+	// ASSUMPTION: this is not needed in other places that the core also wants NodeClaim (e.g., Get, List).
+	// As of the time of writing, AWS is doing something similar.
+	inPlaceUpdateHash, err := inplaceupdate.HashFromNodeClaim(options.FromContext(ctx), nodeClaim, nodeClass)
+	if err != nil {
+		return fmt.Errorf("failed to calculate in place update hash, %w", err)
+	}
+	nodeClaim.Annotations = lo.Assign(nodeClaim.Annotations, map[string]string{
+		v1beta1.AnnotationAKSNodeClassHash:        nodeClass.Hash(),
+		v1beta1.AnnotationAKSNodeClassHashVersion: v1beta1.AKSNodeClassHashVersion,
+		v1beta1.AnnotationInPlaceUpdateHash:       inPlaceUpdateHash,
+	})
+	return nil
+}