diff --git a/bandwidth/model/bxml/verbs/phone_number.py b/bandwidth/model/bxml/verbs/phone_number.py index d57decaf..d2de4c0d 100644 --- a/bandwidth/model/bxml/verbs/phone_number.py +++ b/bandwidth/model/bxml/verbs/phone_number.py @@ -33,17 +33,17 @@ def __init__( tag (str, optional): A custom string that will be sent with these and all future callbacks unless overwritten by a future tag attribute or cleared. May be cleared by setting tag="" Max length 256 characters. Defaults to None. """ self.attributes = { - "fallbackPassword": fallback_password, - "fallbackUsername": fallback_username, - "password": password, - "tag": tag, - "transferAnswerFallbackMethod": transfer_answer_fallback_method, - "transferAnswerFallbackUrl": transfer_answer_fallback_url, - "transferAnswerMethod": transfer_answer_method, "transferAnswerUrl": transfer_answer_url, - "transferDisconnectMethod": transfer_disconnect_method, + "transferAnswerMethod": transfer_answer_method, + "transferAnswerFallbackUrl": transfer_answer_fallback_url, + "transferAnswerFallbackMethod": transfer_answer_fallback_method, "transferDisconnectUrl": transfer_disconnect_url, - "username": username + "transferDisconnectMethod": transfer_disconnect_method, + "username": username, + "password": password, + "fallbackUsername": fallback_username, + "fallbackPassword": fallback_password, + "tag": tag } super().__init__( tag="PhoneNumber", diff --git a/bandwidth/model/bxml/verbs/sip_uri.py b/bandwidth/model/bxml/verbs/sip_uri.py index a4273900..f622e7c9 100644 --- a/bandwidth/model/bxml/verbs/sip_uri.py +++ b/bandwidth/model/bxml/verbs/sip_uri.py @@ -34,18 +34,18 @@ def __init__( tag (str, optional): A custom string that will be sent with these and all future callbacks unless overwritten by a future tag attribute or cleared. May be cleared by setting tag="" Max length 256 characters. Defaults to None. """ self.attributes = { - "fallbackPassword": fallback_password, - "fallbackUsername": fallback_username, - "password": password, - "tag": tag, - "transferAnswerFallbackMethod": transfer_answer_fallback_method, - "transferAnswerFallbackUrl": transfer_answer_fallback_url, - "transferAnswerMethod": transfer_answer_method, + "uui": uui, "transferAnswerUrl": transfer_answer_url, - "transferDisconnectMethod": transfer_disconnect_method, + "transferAnswerMethod": transfer_answer_method, + "transferAnswerFallbackUrl": transfer_answer_fallback_url, + "transferAnswerFallbackMethod": transfer_answer_fallback_method, "transferDisconnectUrl": transfer_disconnect_url, + "transferDisconnectMethod": transfer_disconnect_method, "username": username, - "uui": uui + "password": password, + "fallbackUsername": fallback_username, + "fallbackPassword": fallback_password, + "tag": tag } super().__init__( tag="SipUri", diff --git a/bandwidth/model/bxml/verbs/transfer.py b/bandwidth/model/bxml/verbs/transfer.py index 35215e3f..601bd38a 100644 --- a/bandwidth/model/bxml/verbs/transfer.py +++ b/bandwidth/model/bxml/verbs/transfer.py @@ -62,19 +62,19 @@ def __init__( Defaults to None. """ self.attributes = { + "transferCallerId": transfer_caller_id, "callTimeout": call_timeout, - "diversionReason": diversion_reason, - "diversionTreatment": diversion_treatment, - "fallbackPassword": fallback_password, - "fallbackUsername": fallback_username, + "transferCompleteUrl": transfer_complete_url, + "transferCompleteMethod": transfer_complete_method, + "transferCompleteFallbackUrl": transfer_complete_fallback_url, + "transferCompleteFallbackMethod": transfer_complete_fallback_method, + "username": username, "password": password, + "fallbackUsername": fallback_username, + "fallbackPassword": fallback_password, "tag": tag, - "transferCallerId": transfer_caller_id, - "transferCompleteFallbackMethod": transfer_complete_fallback_method, - "transferCompleteFallbackUrl": transfer_complete_fallback_url, - "transferCompleteMethod": transfer_complete_method, - "transferCompleteUrl": transfer_complete_url, - "username": username + "diversionTreatment": diversion_treatment, + "diversionReason": diversion_reason } super().__init__( tag="Transfer", diff --git a/test/unit/bxml/test_phone_number.py b/test/unit/bxml/test_phone_number.py index e30001f8..35c6b65b 100644 --- a/test/unit/bxml/test_phone_number.py +++ b/test/unit/bxml/test_phone_number.py @@ -5,6 +5,7 @@ @copyright Bandwidth Inc. """ +import os import pytest import unittest @@ -17,14 +18,18 @@ class TestPhoneNumber(unittest.TestCase): def setUp(self): self.phone_number = PhoneNumber( number="+19195551234", - tag="", + transfer_answer_url="https://example.com/webhooks/transfer_answer", transfer_answer_method="POST", - transfer_answer_url="https://example.com/webhooks/transfer_answer" + tag="" ) self.test_verb = Verb(tag="test") def test_to_bxml(self): - expected = '+19195551234' + if os.environ['PYTHON_VERSION'] == '3.7': + expected = '+19195551234' + else: + expected = '+19195551234' + assert(expected == self.phone_number.to_bxml()) def test_add_verb(self): diff --git a/test/unit/bxml/test_sip_uri.py b/test/unit/bxml/test_sip_uri.py index 7e871e08..fa9a06d1 100644 --- a/test/unit/bxml/test_sip_uri.py +++ b/test/unit/bxml/test_sip_uri.py @@ -5,6 +5,7 @@ @copyright Bandwidth Inc. """ +import os import pytest import unittest @@ -17,15 +18,18 @@ class TestSipUri(unittest.TestCase): def setUp(self): self.phone_number = SipUri( uri="sip:1-999-123-4567@voip-provider.example.net", - tag="test", - transfer_answer_method="POST", + uui="abc123", transfer_answer_url="https://example.com/webhooks/transfer_answer", - uui="abc123" + transfer_answer_method="POST", + tag="test" ) self.test_verb = Verb(tag="test") def test_to_bxml(self): - expected = 'sip:1-999-123-4567@voip-provider.example.net' + if os.environ['PYTHON_VERSION'] == '3.7': + expected = 'sip:1-999-123-4567@voip-provider.example.net' + else: + expected = 'sip:1-999-123-4567@voip-provider.example.net' assert(expected == self.phone_number.to_bxml()) def test_add_verb(self): diff --git a/test/unit/bxml/test_transfer.py b/test/unit/bxml/test_transfer.py index 6c32d7d2..56be72e4 100644 --- a/test/unit/bxml/test_transfer.py +++ b/test/unit/bxml/test_transfer.py @@ -5,6 +5,7 @@ @copyright Bandwidth Inc. """ +import os import pytest import unittest @@ -27,15 +28,21 @@ def setUp(self): self.transfer = Transfer( transfer_to=[self.sip_uri], call_timeout = "15", - tag = "test", - transfer_caller_id = "+19195554321" + transfer_caller_id = "+19195554321", + tag = "test" ) def test_to_bxml(self): - expected = 'sip@bw.com' + if os.environ['PYTHON_VERSION'] == '3.7': + expected = 'sip@bw.com' + else: + expected = 'sip@bw.com' assert(expected == self.transfer.to_bxml()) def test_add_verb(self): - expected = 'sip@bw.com+19195551234' + if os.environ['PYTHON_VERSION'] == '3.7': + expected = 'sip@bw.com+19195551234' + else: + expected = 'sip@bw.com+19195551234' self.transfer.add_transfer_recipient(self.phone_number) assert(expected == self.transfer.to_bxml())