From 590d138ba9efb241c0897eee8ed2a85e6d76db76 Mon Sep 17 00:00:00 2001
From: AJ Rice <53190766+ajrice6713@users.noreply.github.com>
Date: Thu, 30 Mar 2023 11:42:05 -0400
Subject: [PATCH] SWI-1997 Strip `_` from BXML keys that are reserved

---
 bandwidth/model/bxml/verb.py   | 2 +-
 test-requirements.txt          | 2 +-
 test/unit/bxml/test_forward.py | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/bandwidth/model/bxml/verb.py b/bandwidth/model/bxml/verb.py
index b0dbf4f1..532881c4 100644
--- a/bandwidth/model/bxml/verb.py
+++ b/bandwidth/model/bxml/verb.py
@@ -60,7 +60,7 @@ def _set_attributes(self, root: ET.Element):
         if self._attributes is not None:
             for key, value in self._attributes.items():
                 if value is not None:
-                    root.set(key, value)
+                    root.set(key.strip("_"), value)
 
     def _to_etree_element(self) -> ET.Element:
         """Generate an ET.Element object from a Verb Object
diff --git a/test-requirements.txt b/test-requirements.txt
index 9dc0deb4..b1941c02 100644
--- a/test-requirements.txt
+++ b/test-requirements.txt
@@ -1,2 +1,2 @@
 pytest-cov>=2.8.1
-pyhamcrest>=2.0.3
+pyhamcrest>=2.0.4
diff --git a/test/unit/bxml/test_forward.py b/test/unit/bxml/test_forward.py
index 99589bf7..c6d5b6a8 100644
--- a/test/unit/bxml/test_forward.py
+++ b/test/unit/bxml/test_forward.py
@@ -25,5 +25,5 @@ def setUp(self):
         self.test_verb = Verb(tag="test")
 
     def test_to_bxml(self):
-        expected = '<Forward to="19195554321" _from="19195554322" callTimeout="15" diversionTreatment="propagate" diversionReason="away" uui="93d6f3c0be5845960b744fa28015d8ede84bd1a4;encoding=base64,asdf;encoding=jwt" />'
+        expected = '<Forward to="19195554321" from="19195554322" callTimeout="15" diversionTreatment="propagate" diversionReason="away" uui="93d6f3c0be5845960b744fa28015d8ede84bd1a4;encoding=base64,asdf;encoding=jwt" />'
         assert(expected == self.forward.to_bxml())