Skip to content

Commit a4c5a84

Browse files
authored
fix: make node in UploadMetadata.new optional (#735)
1 parent ae0152d commit a4c5a84

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

lib/beacon/loader/worker.ex

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ defmodule Beacon.Loader.Worker do
4444
Beacon.MediaLibrary.UploadMetadata.new(
4545
site,
4646
path,
47-
Node.self(),
4847
name: "beacon.png",
4948
extra: %{"alt" => "logo"}
5049
)

lib/beacon/media_library/upload_metadata.ex

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ defmodule Beacon.MediaLibrary.UploadMetadata do
2424

2525
# TODO: https://github.com/BeaconCMS/beacon/pull/239#discussion_r1194160478
2626
@doc false
27-
def new(site, path, node, opts \\ []) do
27+
def new(site, path, opts \\ []) do
2828
opts =
2929
Keyword.reject(opts, fn
3030
{_, ""} -> true
@@ -33,6 +33,7 @@ defmodule Beacon.MediaLibrary.UploadMetadata do
3333

3434
config = Beacon.Config.fetch!(site)
3535
name = Keyword.get(opts, :name, Path.basename(path))
36+
node = opts[:node] || Node.self()
3637

3738
media_type =
3839
opts

lib/beacon/test/fixtures.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -368,7 +368,7 @@ defmodule Beacon.Test.Fixtures do
368368

369369
attrs = Map.put_new(attrs, :file_path, path_for(attrs.file_name))
370370

371-
UploadMetadata.new(attrs.site, attrs.file_path, Node.self(), name: attrs.file_name, size: attrs.file_size, extra: attrs.extra)
371+
UploadMetadata.new(attrs.site, attrs.file_path, name: attrs.file_name, size: attrs.file_size, extra: attrs.extra)
372372
end
373373

374374
defp path_for(file_name) do

0 commit comments

Comments
 (0)