From 4cb284c893d1e814220f1502b75c696fea14e856 Mon Sep 17 00:00:00 2001 From: Berkay Date: Thu, 16 Apr 2026 22:34:25 +0200 Subject: [PATCH] fix: align web test fixtures with ServerProvider contract additions - Remove obsolete props (hasMessages, scrollContainer, nowIso, etc.) from MessagesTimeline handoff test; use buildProps() spread like sibling tests. - Add slashCommands/skills empty arrays to provider fixtures in SettingsPanels.browser.tsx and composerDraftStore.test.ts to satisfy the ServerProvider schema fields added via withDecodingDefault. --- .../components/chat/MessagesTimeline.test.tsx | 24 +------------------ .../settings/SettingsPanels.browser.tsx | 6 +++++ apps/web/src/composerDraftStore.test.ts | 4 ++++ 3 files changed, 11 insertions(+), 23 deletions(-) diff --git a/apps/web/src/components/chat/MessagesTimeline.test.tsx b/apps/web/src/components/chat/MessagesTimeline.test.tsx index f83c2a2488..919565375e 100644 --- a/apps/web/src/components/chat/MessagesTimeline.test.tsx +++ b/apps/web/src/components/chat/MessagesTimeline.test.tsx @@ -164,11 +164,7 @@ describe("MessagesTimeline", () => { const { MessagesTimeline } = await import("./MessagesTimeline"); const markup = renderToStaticMarkup( { }, }, ]} - completionDividerBeforeEntryId={null} - completionSummary={null} - turnDiffSummaryByAssistantMessageId={new Map()} - nowIso="2026-03-17T19:12:30.000Z" - expandedWorkGroups={{}} - onToggleWorkGroup={() => {}} - changedFilesExpandedByTurnId={{}} - onSetChangedFilesExpanded={() => {}} - onOpenTurnDiff={() => {}} - revertTurnCountByUserMessageId={new Map()} - onRevertUserMessage={() => {}} - isRevertingCheckpoint={false} - onImageExpand={() => {}} - activeThreadEnvironmentId={ACTIVE_THREAD_ENVIRONMENT_ID} - markdownCwd={undefined} - resolvedTheme="light" - timestampFormat="locale" - workspaceRoot={undefined} />, ); diff --git a/apps/web/src/components/settings/SettingsPanels.browser.tsx b/apps/web/src/components/settings/SettingsPanels.browser.tsx index 924c5c18a9..648381002f 100644 --- a/apps/web/src/components/settings/SettingsPanels.browser.tsx +++ b/apps/web/src/components/settings/SettingsPanels.browser.tsx @@ -725,6 +725,8 @@ describe("GeneralSettingsPanel observability", () => { auth: { status: "authenticated", label: "ChatGPT Pro Subscription" }, checkedAt: "2026-04-04T00:00:00.000Z", models: [], + slashCommands: [], + skills: [], usageLimits: { updatedAt: "2026-04-04T00:00:00.000Z", windows: [ @@ -779,6 +781,8 @@ describe("GeneralSettingsPanel observability", () => { auth: { status: "authenticated", label: "Claude Pro Subscription" }, checkedAt: "2026-04-04T00:00:00.000Z", models: [], + slashCommands: [], + skills: [], usageLimits: { updatedAt: "2026-04-04T00:00:00.000Z", windows: [ @@ -819,6 +823,8 @@ describe("GeneralSettingsPanel observability", () => { auth: { status: "authenticated" }, checkedAt: "2026-04-04T00:00:00.000Z", models: [], + slashCommands: [], + skills: [], }, ], }); diff --git a/apps/web/src/composerDraftStore.test.ts b/apps/web/src/composerDraftStore.test.ts index b43f920fef..0e5bbd3482 100644 --- a/apps/web/src/composerDraftStore.test.ts +++ b/apps/web/src/composerDraftStore.test.ts @@ -125,6 +125,8 @@ const TEST_PROVIDERS: ServerProvider[] = [ { slug: "gpt-5.4", name: "GPT-5.4", isCustom: false, capabilities: null }, { slug: "gpt-5.4-mini", name: "GPT-5.4 Mini", isCustom: false, capabilities: null }, ], + slashCommands: [], + skills: [], }, { provider: "claudeAgent", @@ -134,6 +136,8 @@ const TEST_PROVIDERS: ServerProvider[] = [ status: "ready", auth: { status: "authenticated" }, checkedAt: "2026-04-10T00:00:00.000Z", + slashCommands: [], + skills: [], models: [ { slug: "claude-opus-4-6",