From 14ed0bb4e44d70ab83c164222fdd61be98ac2641 Mon Sep 17 00:00:00 2001 From: BigSimmo <87357024+BigSimmo@users.noreply.github.com> Date: Thu, 9 Jul 2026 20:42:35 +0800 Subject: [PATCH] fix: record PR 443 review follow-ups --- docs/branch-review-ledger.md | 3 +++ scripts/check-m13-migration.ts | 3 +-- src/components/clinical-dashboard/source-actions.tsx | 6 +++--- src/components/forms/form-detail-page.tsx | 2 +- src/components/ui-primitives.tsx | 2 +- supabase/drift-manifest.json | 4 ++-- 6 files changed, 11 insertions(+), 9 deletions(-) diff --git a/docs/branch-review-ledger.md b/docs/branch-review-ledger.md index 9226ec5f6..4c06bd362 100644 --- a/docs/branch-review-ledger.md +++ b/docs/branch-review-ledger.md @@ -21,3 +21,6 @@ Use this ledger to prevent repeated branch and PR reviews when the reviewed HEAD | Date | Branch or ref | Reviewed HEAD | Scope | Outcome | Checks | | ---------- | -------------- | --------------------------------------- | -------------- | ------------------------------------------------------------- | ---------------------------------------------------------------------------------------------------------- | | 2026-07-09 | example/branch | abc1234567890abcdef1234567890abcdef1234 | branch-cleanup | Example: already merged into `main`; no unique patch content. | `git log --right-only --cherry-pick main...example/branch`; `git diff --name-status main...example/branch` | +| 2026-07-09 | claude/llm-pipeline-review | 009e85c6be437d98dd868d26cc797327bf8fc377 | design-review | Passed; resolved 3 minor P3 design system alignment issues (fixed arbitrary font sizes to `text-2xs` and `min-h-11` to `min-h-tap`). | `npm run verify:cheap` (ESLint + typecheck + 1409 unit tests passed); `node scripts/check-type-scale.mjs`; z-index & compile checks | +| 2026-07-09 | claude/llm-pipeline-review | 009e85c6be437d98dd868d26cc797327bf8fc377 | ai-architecture-review | AI architecture review completed. Found 1 P1 issue (GET seeding routes crash on OpenAI outage) and 2 P2 issues (scaling bottleneck in spelling query corrector, orphaned chunks on registry delete). All 1409 tests passed. | `git diff origin/main...HEAD`, `npm run verify:cheap` (ESLint + typecheck + 1409 unit tests passed) | +| 2026-07-09 | claude/llm-pipeline-review | 009e85c6be437d98dd868d26cc797327bf8fc377 | api-review | No high-confidence P0/P1/P2 issues. Identified minor validation sequence and parameter bounds checks (P3). | `npm run verify:cheap` (TypeScript typecheck, ESLint, and isolated Vitest runs on medications-route, rag-answer-fallback, and rag-cache-invalidation) | diff --git a/scripts/check-m13-migration.ts b/scripts/check-m13-migration.ts index 741e3ea2b..3ec4b6e20 100644 --- a/scripts/check-m13-migration.ts +++ b/scripts/check-m13-migration.ts @@ -1,7 +1,5 @@ import { loadEnvConfig } from "@next/env"; -import { createAdminClient } from "@/lib/supabase/admin"; - loadEnvConfig(process.cwd()); const M13_HEALTH_MARKER = "commit_document_index_generation.preserve_legacy_artifacts_migration"; @@ -19,6 +17,7 @@ function missingMarkers(data: unknown) { } async function main() { + const { createAdminClient } = await import("@/lib/supabase/admin"); const supabase = createAdminClient(); const { data, error } = await supabase.rpc("search_schema_health"); if (error) { diff --git a/src/components/clinical-dashboard/source-actions.tsx b/src/components/clinical-dashboard/source-actions.tsx index 453808dd2..337a68345 100644 --- a/src/components/clinical-dashboard/source-actions.tsx +++ b/src/components/clinical-dashboard/source-actions.tsx @@ -26,7 +26,7 @@ export function SourceActionRow({ }) { return (
- + Open source @@ -53,7 +53,7 @@ export function SourceActionRow({ Add scope {imageCount > 0 && ( - + {imageCount} indexed image{imageCount === 1 ? "" : "s"} )} @@ -124,7 +124,7 @@ export function SourcePassageLinks({ href={sourceResultHref(source)} className={cn( compact ? metadataPill : floatingControl, - "min-h-11 gap-1.5 px-2.5 text-2xs sm:min-h-9 sm:px-3", + "min-h-tap gap-1.5 px-2.5 text-2xs sm:min-h-9 sm:px-3", )} title={`${source.title} · page ${source.page_number ?? "n/a"} · chunk ${source.chunk_index}`} aria-label={`Open source passage #${index + 1}`} diff --git a/src/components/forms/form-detail-page.tsx b/src/components/forms/form-detail-page.tsx index e899fe11e..5c1b30adf 100644 --- a/src/components/forms/form-detail-page.tsx +++ b/src/components/forms/form-detail-page.tsx @@ -559,7 +559,7 @@ export function FormDetailPage({ form }: { form: FormRecord }) { diff --git a/src/components/ui-primitives.tsx b/src/components/ui-primitives.tsx index 9fc8159da..802b5dde3 100644 --- a/src/components/ui-primitives.tsx +++ b/src/components/ui-primitives.tsx @@ -75,7 +75,7 @@ export const chatActionRow = export const chatMicroAction = "inline-flex min-h-tap min-w-tap items-center justify-center gap-1.5 rounded-md px-2 text-xs font-semibold text-[color:var(--text-muted)] transition hover:bg-[color:var(--clinical-accent-soft)] hover:text-[color:var(--clinical-accent)] focus-visible:outline focus-visible:outline-2 focus-visible:outline-offset-2 focus-visible:outline-[color:var(--focus)] disabled:cursor-not-allowed disabled:opacity-50"; export const sourceCapsule = - "source-capsule-hover focus-ring-premium inline-flex min-h-tap items-center gap-1 rounded-md border border-[color:var(--border)] bg-[color-mix(in_srgb,var(--clinical-accent-soft)_55%,var(--surface))] px-2 text-[11px] font-medium text-[color:var(--clinical-accent)] transition hover:border-[color:var(--clinical-accent-border)] sm:px-2.5"; + "source-capsule-hover focus-ring-premium inline-flex min-h-tap items-center gap-1 rounded-md border border-[color:var(--border)] bg-[color-mix(in_srgb,var(--clinical-accent-soft)_55%,var(--surface))] px-2 text-2xs font-medium text-[color:var(--clinical-accent)] transition hover:border-[color:var(--clinical-accent-border)] sm:px-2.5"; export const sourceCapsuleCountBadge = "nums inline-flex h-5 min-w-5 shrink-0 items-center justify-center rounded-full bg-[color:var(--surface-raised)] px-1.5 text-2xs font-semibold text-[color:var(--clinical-accent)] shadow-[var(--shadow-inset)]"; export const evidenceRow = diff --git a/supabase/drift-manifest.json b/supabase/drift-manifest.json index ae7e65f53..7d39c5d85 100644 --- a/supabase/drift-manifest.json +++ b/supabase/drift-manifest.json @@ -1,9 +1,9 @@ { - "generated_at": "2026-07-09T08:52:11.900Z", + "generated_at": "2026-07-09T11:02:02.346Z", "generator": "scripts/generate-drift-manifest.ts", "postgres_image": "supabase/postgres:17.6.1.127", "schema_sha256": "3a60bf1561142aed58e45a1cf8a9605ccc715dd7358e154c4ad9879b82be4cd5", - "replay_seconds": 16, + "replay_seconds": 28, "snapshot": { "views": [ {