Sort by
A to Z
diff --git a/src/components/clinical-dashboard/favourites-guest-gate.tsx b/src/components/clinical-dashboard/favourites-guest-gate.tsx
new file mode 100644
index 000000000..38836fae2
--- /dev/null
+++ b/src/components/clinical-dashboard/favourites-guest-gate.tsx
@@ -0,0 +1,22 @@
+"use client";
+
+/**
+ * Inline gate when Favourites content would otherwise render in the dashboard
+ * for a signed-out non-demo session (defense in depth; /favourites is canonical).
+ */
+export function FavouritesGuestGate({ onOpenAccountSetup }: { onOpenAccountSetup: () => void }) {
+ return (
+
+
Favourites are tied to your account.
+
Sign in or create an account to continue.
+
+
+ );
+}
diff --git a/src/components/clinical-dashboard/global-search-shell.tsx b/src/components/clinical-dashboard/global-search-shell.tsx
index 58c3e2baa..ad26d0dda 100644
--- a/src/components/clinical-dashboard/global-search-shell.tsx
+++ b/src/components/clinical-dashboard/global-search-shell.tsx
@@ -439,7 +439,7 @@ function GlobalStandaloneSearchShellClient({
function prefetchApplications() {
router.prefetch("/?mode=tools");
- router.prefetch("/favourites");
+ if (favouritesAccessible) router.prefetch("/favourites");
router.prefetch("/differentials");
router.prefetch("/dsm");
router.prefetch("/specifiers");
@@ -521,6 +521,13 @@ function GlobalStandaloneSearchShellClient({
}
function crossModeSearch(mode: AppModeId, crossQuery: string) {
+ if (mode === "favourites" && !favouritesAccessible) {
+ setGuideOpen(false);
+ setSettingsOpen(false);
+ setMobileMenuOpen(false);
+ openAccountSetup("favourites");
+ return;
+ }
setQuery(crossQuery);
setCommandScopes([]);
setSearchMode(mode);
diff --git a/src/components/clinical-dashboard/master-search-header.tsx b/src/components/clinical-dashboard/master-search-header.tsx
index 6adb76e71..423fc5790 100644
--- a/src/components/clinical-dashboard/master-search-header.tsx
+++ b/src/components/clinical-dashboard/master-search-header.tsx
@@ -185,7 +185,7 @@ export function MasterSearchHeader({
onMobileBack,
hideOnScroll,
onBottomComposerHiddenChange,
- canAccessFavourites = true,
+ canAccessFavourites = false,
onRequestAccountSetup,
}: {
demoMode: boolean;
@@ -266,19 +266,25 @@ export function MasterSearchHeader({
/**
* Favourites are account-scoped. When false, omit Favourites from the mode menu
* and route favourites actions to account setup instead of switching mode.
- * Defaults to true for backward-compatible call sites (tests/story fixtures).
+ * Defaults to false (fail closed) so guests never see Favourites unless the host
+ * explicitly grants access from the current session / demo mode.
*/
canAccessFavourites?: boolean;
/** Invoked when the user tries to open Favourites without access. */
onRequestAccountSetup?: () => void;
}) {
+ // Hosts pass the precomputed session decision in canAccessFavourites (auth || demo).
+ // Do not OR demoMode again here โ that would reopen Favourites when props diverge.
const visibleAppModeOptions = visibleAppModeDefinitionsForSession({
authenticated: canAccessFavourites,
demoMode: false,
});
const trimmedQuery = query.trim();
const selectedSearch = appModeSearchConfig(searchMode);
- const selectedAppMode = appModeDefinition(searchMode);
+ // Guests on /favourites keep the route gate, but the mode trigger must not claim
+ // Favourites is a selectable guest mode when it is omitted from the menu.
+ const modeTriggerId = searchMode === "favourites" && !canAccessFavourites ? "answer" : searchMode;
+ const selectedAppMode = appModeDefinition(modeTriggerId);
const selectedSearchable = isSearchableAppMode(searchMode);
const isAnswerFooterComposer = searchMode === "answer";
const isWorkflowHeader = headerVariant === "workflow";
@@ -1297,6 +1303,7 @@ export function MasterSearchHeader({
) : null}
{
+ if (targetMode === "favourites" && !canAccessFavourites) {
+ onRequestAccountSetup?.();
+ return;
+ }
if (onCrossModeSearch) {
onCrossModeSearch(targetMode, crossQuery);
return;
diff --git a/src/components/clinical-dashboard/search-results-header-band.tsx b/src/components/clinical-dashboard/search-results-header-band.tsx
index c87c77920..4c63beb2d 100644
--- a/src/components/clinical-dashboard/search-results-header-band.tsx
+++ b/src/components/clinical-dashboard/search-results-header-band.tsx
@@ -175,15 +175,18 @@ export function SearchResultsEmptyState({
onClearScopes,
onTryExample,
onCrossMode,
+ canAccessFavourites = false,
}: {
modeId: AppModeId;
query: string;
onClearScopes?: () => void;
onTryExample?: (example: string) => void;
onCrossMode?: (modeId: AppModeId) => void;
+ canAccessFavourites?: boolean;
}) {
const command = useSearchCommand();
const config = searchCommandSurfaceConfig(modeId);
+ const crossModes = (config?.crossModes ?? []).filter((target) => canAccessFavourites || target !== "favourites");
const activeScopes = command?.commandScopes ?? [];
return (
@@ -222,7 +225,7 @@ export function SearchResultsEmptyState({
Try: {config.examples[0]}
) : null}
- {config?.crossModes.slice(0, 2).map((target) =>
+ {crossModes.slice(0, 2).map((target) =>
onCrossMode ? (