Skip to content

Commit bce9776

Browse files
committed
Run ODBC tests in workflow
Run test executables once without re-runs and without using test script. This way the segmentation fault is not caught.
1 parent 8010794 commit bce9776

File tree

1 file changed

+10
-3
lines changed

1 file changed

+10
-3
lines changed

.github/workflows/cpp_extra.yml

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -434,10 +434,17 @@ jobs:
434434
shell: cmd
435435
run: |
436436
call "cpp\src\arrow\flight\sql\odbc\tests\install_odbc.cmd" ${{ github.workspace }}\build\cpp\%ARROW_BUILD_TYPE%\arrow_flight_sql_odbc.dll
437-
# GH-48270 TODO: Resolve segementation fault during Arrow library unload
438-
# GH-48269 TODO: Enable Flight & Flight SQL testing in MSVC CI
437+
# GH-48270 TODO: Resolve segementation fault during Arrow library unload, segementation fault is caught with `ci/scripts/cpp_test.sh`
438+
# GH-48269 TODO: Enable Flight & Flight SQL testing in MSVC CI and run tests with `ci/scripts/cpp_test.sh` instead
439439
# GH-48547 TODO: enable ODBC tests after GH-48270 and GH-48269 are resolved.
440-
440+
- name: Run ODBC Unit Tests
441+
shell: cmd
442+
run: |
443+
build\cpp\%ARROW_BUILD_TYPE%\arrow-odbc-spi-impl-test.exe
444+
- name: Run ODBC Driver Tests
445+
shell: cmd
446+
run: |
447+
build\cpp\%ARROW_BUILD_TYPE%\arrow-flight-sql-odbc-test.exe
441448
- name: Install WiX Toolset
442449
shell: pwsh
443450
run: |

0 commit comments

Comments
 (0)