From 4fe6d9285a3663373b6c9eca376bf69d39b28339 Mon Sep 17 00:00:00 2001 From: Lynx6319 <193745545+Lynx6319@users.noreply.github.com> Date: Mon, 30 Mar 2026 18:30:09 +0200 Subject: [PATCH 1/3] Update MarkSkill.ts update markskill.ts so it can accept the skills different states --- src/types/MarkSkill.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/types/MarkSkill.ts b/src/types/MarkSkill.ts index 8ab8a5f..47978a4 100644 --- a/src/types/MarkSkill.ts +++ b/src/types/MarkSkill.ts @@ -1,7 +1,7 @@ export interface MarkSkill { descriptif: string; idElemProg: number; - valeur: "2"; // Max 4 + valeur: "1" | "2" | "3" | "4"; cdt: boolean; idCompetence: number; idConnaissance: number; From a2a1c26b32a8e1163b0fc4aae2635e2f57a8215b Mon Sep 17 00:00:00 2001 From: Lynx6319 <193745545+Lynx6319@users.noreply.github.com> Date: Mon, 30 Mar 2026 18:31:58 +0200 Subject: [PATCH 2/3] Update MarkSkill.ts update so it won't break if ed is not using a string --- src/types/MarkSkill.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/types/MarkSkill.ts b/src/types/MarkSkill.ts index 47978a4..8546491 100644 --- a/src/types/MarkSkill.ts +++ b/src/types/MarkSkill.ts @@ -1,7 +1,7 @@ export interface MarkSkill { descriptif: string; idElemProg: number; - valeur: "1" | "2" | "3" | "4"; + valeur: 1 | 2 | 3 | 4 | "1" | "2" | "3" | "4"; cdt: boolean; idCompetence: number; idConnaissance: number; From daef0d819e527c3a4ecdaa10f0cf2a83a1fb72e0 Mon Sep 17 00:00:00 2001 From: godetremy Date: Wed, 1 Apr 2026 22:32:58 +0200 Subject: [PATCH 3/3] feat: Update MarkSkill value to support absence, exempt, and not rated skills --- src/types/MarkSkill.ts | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/types/MarkSkill.ts b/src/types/MarkSkill.ts index 8546491..8468469 100644 --- a/src/types/MarkSkill.ts +++ b/src/types/MarkSkill.ts @@ -1,7 +1,17 @@ +export enum MarkSkillValue { + ABSENT = 'abs', + EXEMPT = 'disp', + NOT_RATED = 'ne', + NOT_ACHIEVED = '1', + PARTIALLY_ACHIEVED = '2', + ACHIEVED = '3', + EXCEEEDED = '4' +} + export interface MarkSkill { descriptif: string; idElemProg: number; - valeur: 1 | 2 | 3 | 4 | "1" | "2" | "3" | "4"; + valeur: MarkSkillValue; cdt: boolean; idCompetence: number; idConnaissance: number;