Skip to content

Commit 4ffc14a

Browse files
committed
test(introspection): annotate new tests with -> None return type
Match the style used for the new tests added in #653 and address review feedback on #655.
1 parent c6a3c2e commit 4ffc14a

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

tests/test_introspection.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ def test_default_interfaces():
151151
assert type(default) is intr.Node
152152

153153

154-
def test_introspection_rejects_billion_laughs():
154+
def test_introspection_rejects_billion_laughs() -> None:
155155
"""Nested-entity expansion in an Introspect reply is rejected."""
156156
payload = (
157157
'<?xml version="1.0"?>'
@@ -166,7 +166,7 @@ def test_introspection_rejects_billion_laughs():
166166
intr.Node.parse(payload)
167167

168168

169-
def test_introspection_rejects_quadratic_blowup():
169+
def test_introspection_rejects_quadratic_blowup() -> None:
170170
"""A single large entity referenced many times is rejected."""
171171
payload = (
172172
'<?xml version="1.0"?>'
@@ -179,7 +179,7 @@ def test_introspection_rejects_quadratic_blowup():
179179
intr.Node.parse(payload)
180180

181181

182-
def test_introspection_rejects_xxe_external_entity():
182+
def test_introspection_rejects_xxe_external_entity() -> None:
183183
"""External-entity declarations are rejected even without expansion."""
184184
payload = (
185185
'<?xml version="1.0"?>'
@@ -192,7 +192,7 @@ def test_introspection_rejects_xxe_external_entity():
192192
intr.Node.parse(payload)
193193

194194

195-
def test_introspection_accepts_standard_doctype():
195+
def test_introspection_accepts_standard_doctype() -> None:
196196
"""The standard D-Bus introspection DOCTYPE (no internal subset) parses."""
197197
payload = (
198198
'<?xml version="1.0"?>\n'
@@ -205,7 +205,7 @@ def test_introspection_accepts_standard_doctype():
205205
assert node.interfaces[0].name == "org.example.Iface"
206206

207207

208-
def test_introspection_malformed_xml_raises_parse_error():
208+
def test_introspection_malformed_xml_raises_parse_error() -> None:
209209
"""Malformed XML still raises ET.ParseError, not a silent failure."""
210210
with pytest.raises(ET.ParseError):
211211
intr.Node.parse("<node><unclosed")

0 commit comments

Comments
 (0)