fix(errors): put built-in exception bases before DBusFastError in MRO

Author: bluetoothbot

src/dbus_fast/errors.py

@@ -8,27 +8,27 @@ class DBusFastError(Exception):
     """
 
 
-class SignatureBodyMismatchError(DBusFastError, ValueError):
+class SignatureBodyMismatchError(ValueError, DBusFastError):
     pass
 
 
-class InvalidSignatureError(DBusFastError, ValueError):
+class InvalidSignatureError(ValueError, DBusFastError):
     pass
 
 
-class InvalidAddressError(DBusFastError, ValueError):
+class InvalidAddressError(ValueError, DBusFastError):
     pass
 
 
 class AuthError(DBusFastError):
     pass
 
 
-class InvalidMessageError(DBusFastError, ValueError):
+class InvalidMessageError(ValueError, DBusFastError):
     pass
 
 
-class InvalidIntrospectionError(DBusFastError, ValueError):
+class InvalidIntrospectionError(ValueError, DBusFastError):
     pass
 
 
@@ -40,22 +40,22 @@ class SignalDisabledError(DBusFastError):
     pass
 
 
-class InvalidBusNameError(DBusFastError, TypeError):
+class InvalidBusNameError(TypeError, DBusFastError):
     def __init__(self, name: str) -> None:
         super().__init__(f"invalid bus name: {name}")
 
 
-class InvalidObjectPathError(DBusFastError, TypeError):
+class InvalidObjectPathError(TypeError, DBusFastError):
     def __init__(self, path: str) -> None:
         super().__init__(f"invalid object path: {path}")
 
 
-class InvalidInterfaceNameError(DBusFastError, TypeError):
+class InvalidInterfaceNameError(TypeError, DBusFastError):
     def __init__(self, name: str) -> None:
         super().__init__(f"invalid interface name: {name}")
 
 
-class InvalidMemberNameError(DBusFastError, TypeError):
+class InvalidMemberNameError(TypeError, DBusFastError):
     def __init__(self, member: str) -> None:
         super().__init__(f"invalid member name: {member}")
 

tests/test_errors.py

@@ -77,6 +77,29 @@ def test_type_error_subclasses_preserved(err_cls: type[BaseException]) -> None:
     assert issubclass(err_cls, TypeError)
 
 
+def test_value_error_subclass_mro_order() -> None:
+    """Built-in ``ValueError`` must precede ``DBusFastError`` in the MRO.
+
+    This ordering ensures ``super().__init__`` routes through
+    ``ValueError.__init__`` rather than skipping straight to
+    ``Exception.__init__``, preserving the behavior of the historical
+    single-inheritance ``ValueError`` subclasses.
+    """
+    mro = InvalidSignatureError.__mro__
+    assert mro.index(ValueError) < mro.index(DBusFastError)
+
+
+def test_type_error_subclass_mro_order() -> None:
+    """Built-in ``TypeError`` must precede ``DBusFastError`` in the MRO.
+
+    Same rationale as the ``ValueError`` MRO test: keeps ``super().__init__``
+    routing through ``TypeError.__init__`` to match the original
+    single-inheritance ``TypeError`` subclasses.
+    """
+    mro = InvalidBusNameError.__mro__
+    assert mro.index(TypeError) < mro.index(DBusFastError)
+
+
 def test_dbus_fast_error_catches_value_error_subclass() -> None:
     with pytest.raises(DBusFastError):
         raise SignatureBodyMismatchError("body mismatch")