Refactor constructors to use explicit property assignments

Author: minht11

lib/ParseError.ts

@@ -25,8 +25,11 @@ export class UnsupportedFileTypeError extends makeParseError('UnsupportedFileTyp
 
 // Concrete error class representing unexpected file content.
 class UnexpectedFileContentError extends makeParseError('UnexpectedFileContentError') {
-  constructor(public readonly fileType: string, message: string) {
+  public readonly fileType: string;
+
+  constructor(fileType: string, message: string) {
     super(message);
+    this.fileType = fileType;
   }
 
   // Override toString to include file type information.

lib/aiff/AiffToken.ts

@@ -41,7 +41,10 @@ export class Common implements IGetToken<ICommon> {
 
   public len: number;
 
-  public constructor(header: iff.IChunkHeader, private isAifc: boolean) {
+  private isAifc: boolean;
+
+  public constructor(header: iff.IChunkHeader, isAifc: boolean) {
+    this.isAifc = isAifc;
     const minimumChunkSize = isAifc ? 22 : 18;
     if (header.chunkSize < minimumChunkSize) throw new AiffContentError(`COMMON CHUNK size should always be at least ${minimumChunkSize}`);
     this.len = header.chunkSize;

lib/asf/AsfObject.ts

@@ -587,7 +587,10 @@ export class WmPictureToken implements IGetToken<IWmPicture> {
     return pic.get(buffer, 0);
   }
 
-  constructor(public len: number) {
+  public len: number;
+
+  constructor(len: number) {
+    this.len = len;
   }
 
   public get(buffer: Uint8Array, offset: number): IWmPicture {

lib/asf/GUID.ts

@@ -118,7 +118,10 @@ export default class GUID {
     return bin;
   }
 
-  public constructor(public str: string) {
+  public str: string;
+
+  public constructor(str: string) {
+    this.str = str;
   }
 
   public equals(guid: GUID) {

lib/common/BasicParser.ts

@@ -6,17 +6,26 @@ import type { INativeMetadataCollector } from './MetadataCollector.js';
 
 export abstract class BasicParser implements ITokenParser {
 
+  protected readonly metadata: INativeMetadataCollector;
+
+  protected readonly tokenizer: ITokenizer;
+  
+  protected readonly options: IOptions;
+
   /**
    * Initialize parser with output (metadata), input (tokenizer) & parsing options (options).
    * @param {INativeMetadataCollector} metadata Output
    * @param {ITokenizer} tokenizer Input
    * @param {IOptions} options Parsing options
    */
   constructor(
-    protected readonly metadata: INativeMetadataCollector,
-    protected readonly tokenizer: ITokenizer,
-    protected readonly options: IOptions
+    metadata: INativeMetadataCollector,
+    tokenizer: ITokenizer,
+    options: IOptions
   ) {
+    this.metadata = metadata;
+    this.tokenizer = tokenizer;
+    this.options = options;
   }
 
   public abstract parse(): Promise<void>;

lib/common/GenericTagMapper.ts

@@ -43,7 +43,13 @@ export class CommonTagMapper implements IGenericTagMapper {
     };
   }
 
-  public constructor(public tagTypes: generic.TagType[], public tagMap: generic.INativeTagMap) {
+  public tagTypes: generic.TagType[];
+
+  public tagMap: generic.INativeTagMap;
+
+  public constructor(tagTypes: generic.TagType[], tagMap: generic.INativeTagMap) {
+    this.tagTypes = tagTypes;
+    this.tagMap = tagMap;
   }
 
   /**

lib/common/MetadataCollector.ts

@@ -92,7 +92,10 @@ export class MetadataCollector implements INativeMetadataCollector {
 
   private tagMapper = new CombinedTagMapper();
 
-  public constructor(private opts?: IOptions) {
+  private opts?: IOptions;
+
+  public constructor(opts?: IOptions) {
+    this.opts = opts;
     let priority = 1;
     for (const tagType of TagPriority) {
       this.originPriority[tagType] = priority++;

lib/ebml/EbmlIterator.ts

@@ -52,11 +52,14 @@ export class EbmlIterator {
   private ebmlMaxIDLength = 4;
   private ebmlMaxSizeLength = 8;
 
+  private tokenizer: ITokenizer;
+
   /**
    * @param {ITokenizer} tokenizer Input
    * @param tokenizer
    */
-  constructor(private tokenizer: ITokenizer) {
+  constructor(tokenizer: ITokenizer) {
+    this.tokenizer = tokenizer;
     this.parserMap.set(DataType.uint, e => this.readUint(e));
     this.parserMap.set(DataType.string, e => this.readString(e));
     this.parserMap.set(DataType.binary, e => this.readBuffer(e));

lib/id3v1/ID3v1Parser.ts

@@ -93,9 +93,12 @@ const Iid3v1Token: IGetToken<IId3v1Header | null> = {
 
 class Id3v1StringType implements IGetToken<string | undefined> {
 
+  public len: number;
+
   private stringType;
 
-  constructor(public len: number) {
+  constructor(len: number) {
+    this.len = len;
     this.stringType = new StringType(len, 'latin1');
   }
 

lib/id3v2/FrameParser.ts

@@ -100,13 +100,18 @@ function parseGenreCode(code: string): string | undefined{
 }
 
 export class FrameParser {
+  private major: ID3v2MajorVersion;
+
+  private warningCollector: IWarningCollector;
 
   /**
    * Create id3v2 frame parser
    * @param major - Major version, e.g. (4) for  id3v2.4
    * @param warningCollector - Used to collect decode issue
    */
-  constructor(private major: ID3v2MajorVersion, private warningCollector: IWarningCollector) {
+  constructor(major: ID3v2MajorVersion, warningCollector: IWarningCollector) {
+    this.major = major;
+    this.warningCollector = warningCollector;
   }
 
   public readData(uint8Array: Uint8Array, type: string, includeCovers: boolean) {