[core] Returning the wrong type on trace/capture fn causes mulog to silently stop recording logs and traces Fix #119

Author: BrunoBonacci

mulog-core/src/com/brunobonacci/mulog.clj

@@ -392,7 +392,13 @@ For more information, please visit: https://github.com/BrunoBonacci/mulog
            (core/log-trace ~event-name tid# ptid# (- (System/nanoTime) t0#) ts# :ok pairs#
              ;; if there is something to capture form the evaluation result
              ;; then use the capture function
-             (core/on-error {:mulog/capture :error} (when capture# (capture# r#))))
+             (core/on-error {:mulog/capture :error}
+               (when capture#
+                 (let [captured# (capture# r#)]
+                   (if (or (map? captured#) (nil? captured#))
+                     captured#
+                     {:mulog/capture :error
+                      :mulog/capture-message "Invalid type returned, :capture fn must return a map!"})))))
            ;; return the body result
            r#)
          ;; If and exception occur, then log the error.

mulog-core/src/com/brunobonacci/mulog/core.clj

@@ -143,7 +143,7 @@
   (delay ;; Delay the task initialisation at runtime (GraalVM)
     (rb/recurring-task
       PUBLISH-INTERVAL
-      (fn []
+      (fn dispatch-publishers-task []
         (let [pubs @publishers
               ;;    group-by buffer
               pubs (group-by :buffer (map second pubs))]

mulog-core/test/com/brunobonacci/mulog_test.clj

@@ -506,6 +506,21 @@
              :mulog/capture    :error})]))
 
 
+  (fact "success case but failing extraction with wrong type returned"
+    (tp/with-test-publisher
+      (u/trace :test
+        {:pairs   [:key1 "value1"]
+         :capture (constantly 1)}
+        {:http-status 200 :body "OK"}))
+
+    => (just
+        [(contains
+           {:mulog/event-name :test
+            :key1             "value1"
+            :mulog/capture    :error
+            :mulog/capture-message "Invalid type returned, :capture fn must return a map!"})]))
+
+
   (fact "extraction can redefine internal properties such as :outcome and :exception"
     (tp/with-test-publisher
       (u/trace :test