From 84d1cc88d1f0c781afd247ea408ce0ab1f637ceb Mon Sep 17 00:00:00 2001 From: Pratyush Sharma <56130065+pratyush618@users.noreply.github.com> Date: Mon, 6 Jul 2026 21:58:37 +0530 Subject: [PATCH] fix(java): drop method refs flagged by null analysis --- .../java/org/byteveda/taskito/resources/ResourceRuntime.java | 4 +++- .../java/org/byteveda/taskito/workflows/WorkflowAnalysis.java | 2 +- sdks/java/src/test/java/org/byteveda/taskito/Greeter.java | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/sdks/java/src/main/java/org/byteveda/taskito/resources/ResourceRuntime.java b/sdks/java/src/main/java/org/byteveda/taskito/resources/ResourceRuntime.java index 89938148..155e4fa4 100644 --- a/sdks/java/src/main/java/org/byteveda/taskito/resources/ResourceRuntime.java +++ b/sdks/java/src/main/java/org/byteveda/taskito/resources/ResourceRuntime.java @@ -385,7 +385,9 @@ private Object build(String name, ResourceDefinition definition, ResourceContext private void disposeWorker() { // Pools first: pooled instances may depend on worker resources, which the // teardown stack below disposes. - pools.values().forEach(ResourcePool::shutdown); + for (ResourcePool pool : pools.values()) { + pool.shutdown(); + } pools.clear(); synchronized (workerTeardown) { while (!workerTeardown.isEmpty()) { diff --git a/sdks/java/src/main/java/org/byteveda/taskito/workflows/WorkflowAnalysis.java b/sdks/java/src/main/java/org/byteveda/taskito/workflows/WorkflowAnalysis.java index 6f833f41..c1f23db4 100644 --- a/sdks/java/src/main/java/org/byteveda/taskito/workflows/WorkflowAnalysis.java +++ b/sdks/java/src/main/java/org/byteveda/taskito/workflows/WorkflowAnalysis.java @@ -55,7 +55,7 @@ public static List topologicalOrder(Workflow workflow) { String node = ready.poll(); order.add(node); for (String next : successors.getOrDefault(node, List.of())) { - indegree.merge(next, -1, Integer::sum); + indegree.merge(next, -1, (count, delta) -> count + delta); if (indegree.get(next) == 0) { ready.add(next); } diff --git a/sdks/java/src/test/java/org/byteveda/taskito/Greeter.java b/sdks/java/src/test/java/org/byteveda/taskito/Greeter.java index fd1a2814..878a229f 100644 --- a/sdks/java/src/test/java/org/byteveda/taskito/Greeter.java +++ b/sdks/java/src/test/java/org/byteveda/taskito/Greeter.java @@ -13,6 +13,6 @@ String greet(String name) { @TaskHandler Integer total(List numbers) { - return numbers.stream().mapToInt(Integer::intValue).sum(); + return numbers.stream().mapToInt(number -> number.intValue()).sum(); } }