Skip to content

Commit 714af40

Browse files
cqliu1CAWilson94
authored andcommitted
[Navigation] Fix props for icon only top nav menu item (elastic#247634)
## Summary Closes elastic#247633. Bug introduced in elastic#224552. This changes the conditional for passing the correct props to match the condition for rendering this nested component as a `Fragment` or `EuiTooltip`. This prevents the invalid tooltips props from being passed on the `Fragment`. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ...
1 parent 18a6daf commit 714af40

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/platform/plugins/shared/navigation/public/top_nav_menu/top_nav_menu_item.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ export function TopNavMenuItem(props: TopNavMenuItemProps) {
131131
showFragment ? React.Fragment : EuiToolTip,
132132
// @ts-expect-error - EuiToolTip does not accept `key` prop, we pass to react Fragment
133133
{
134-
...(props.disableButton
134+
...(showFragment
135135
? { key: props.label || props.id! }
136136
: {
137137
content: upperFirst(props.label || props.id!),

0 commit comments

Comments
 (0)