Skip to content

Commit 9834601

Browse files
authored
Merge pull request #243 from CPJKU/develop
Release 1.2.2
2 parents fc3e42a + 59cbe3a commit 9834601

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

50 files changed

+6142
-326
lines changed

.github/workflows/linting.yml

Lines changed: 39 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,39 @@
1+
name: Blacken code
2+
3+
on:
4+
push:
5+
branches:
6+
- master
7+
pull_request:
8+
branches:
9+
- master
10+
jobs:
11+
format:
12+
runs-on: ubuntu-latest
13+
steps:
14+
- uses: actions/checkout@v2
15+
- name: Format code with black
16+
run: |
17+
pip install black
18+
black --include="\.py,\.pyi" --exclude="env/*,tests/*" .
19+
- name: Commit changes
20+
uses: EndBug/add-and-commit@v4
21+
with:
22+
author_name: ${{ github.actor }}
23+
author_email: ${{ github.actor }}@users.noreply.github.com
24+
message: "Format code with black"
25+
add: "."
26+
branch: ${{ github.ref }}
27+
- name: Notify errors
28+
if: failure()
29+
uses: dawidd6/action-send-mail@v2
30+
with:
31+
server_address: smtp.gmail.com
32+
server_port: 465
33+
username: ${{ secrets.EMAIL_USERNAME }}
34+
password: ${{ secrets.EMAIL_PASSWORD }}
35+
subject: "Format code with black"
36+
body: "Format code with black failed"
37+
to: ${{ secrets.EMAIL_TO }}
38+
from: ${{ secrets.EMAIL_FROM }}
39+
content_type: text/plain

.github/workflows/pypi_publish.yml

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
name: Publish to PyPI.org
2+
on:
3+
release:
4+
types: [published]
5+
jobs:
6+
pypi:
7+
runs-on: ubuntu-latest
8+
steps:
9+
- name: Checkout
10+
uses: actions/checkout@v3
11+
with:
12+
fetch-depth: 0
13+
- run: python3 -m pip install --upgrade build && python3 -m build
14+
- name: Publish package
15+
uses: pypa/gh-action-pypi-publish@release/v1
16+
with:
17+
password: ${{ secrets.PYPI_API_TOKEN }}

.github/workflows/stale.yml

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
name: "Close stale issues and PRs"
2+
3+
on:
4+
schedule:
5+
# Every day at 00:00
6+
- cron: "0 0 * * *"
7+
workflow_dispatch:
8+
9+
jobs:
10+
stale:
11+
runs-on: ubuntu-latest
12+
13+
steps:
14+
- uses: actions/stale@v4.0.0
15+
with:
16+
stale-issue-message: 'This issue had no activity for **6 months**. It will be closed in **2 weeks** unless there is some new activity. Is this issue already resolved?'
17+
stale-issue-label: 'stale'
18+
exempt-issue-labels: 'bug,enhancement,good first issue'
19+
stale-pr-message: 'This pull request had no activity for **6 months**. It will be closed in **2 weeks** unless there is some new activity.'
20+
stale-pr-label: 'stale'
21+
days-before-stale: 180
22+
days-before-close: 14
23+
operations-per-run: 200

CHANGES.md

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,31 @@
11
Release Notes
22
=============
33

4+
Version 1.2.2 (Released on 2023-10-05)
5+
--------------------------------------
6+
7+
New features
8+
------------
9+
* slicing performed parts
10+
* roman numeral analysis
11+
* harmony class for part and export
12+
* staff with custom number of lines
13+
* transposition by intervals
14+
15+
16+
Bug fixes
17+
---------
18+
* file naming bug in load_musicxml()
19+
* fixed bug in score part unfolding
20+
* bugfix for fine, ritenuto parsing and unfolding
21+
* bugfix for performance codec
22+
23+
24+
Other changes
25+
-------------
26+
* Improved documentation
27+
* Added contributing file
28+
429

530
Version 1.2.1 (Released on 2023-02-09)
631
--------------------------------------

CONTRIBUTING.md

Lines changed: 104 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,104 @@
1+
# Contributing
2+
3+
You can help the developers of **Partitura** by contributing, requesting features or reporting error.
4+
5+
## Opening an Issue
6+
7+
To open an issue navigate to the partitura github repository:
8+
9+
[Repository]: https://github.com/CPJKU/partitura/issues "Partitura Issues Link"
10+
11+
#### Click to **New Issue**
12+
13+
![](docs/source/images/issue_page.png)
14+
15+
#### Write your description
16+
17+
![](docs/source/images/writing_issue.png)
18+
19+
#### Choose the appropriate label
20+
21+
![](docs/source/images/issue_choosing_label.png)
22+
23+
##### How to choose your issue label:
24+
25+
- **Question** to ask us a question or **help wanted** if you need a solution to a particular partitura problem.
26+
- **Bug** to report something not working correctly.
27+
- **Enhancement** to request for a feature.
28+
29+
## How to contribute
30+
31+
A step by step guide :
32+
33+
1. To contribute is to open a relevant issue.
34+
2. ***Fork*** the Partitura repo.
35+
3. *Checkout* or *Pull* the latest stable develop branch.
36+
4. *Checkout a new branch* from the develop with the name of your develop idea.
37+
5. When finished coding, open a pull request to the develop branch of partitura.
38+
39+
### Open a relevant issue
40+
41+
Follow section how to open an issue.
42+
43+
### **Fork** the Repo
44+
45+
Fork partitura from
46+
https://github.com/CPJKU/partitura
47+
48+
Once that you have already forked the repo, you can clone it:
49+
```shell
50+
git clone https://github.com/YourUsername/partitura.git
51+
cd partitura
52+
```
53+
54+
### Get latest Develop Branch
55+
56+
```shell
57+
git fetch upstream
58+
git checkout develop
59+
git pull
60+
```
61+
62+
### Create your Branch
63+
64+
```shel
65+
git checkout -b mycrazyidea
66+
```
67+
68+
Do your coding magic!!!
69+
70+
Remember to commit regularly with descriptive messages about your changes.
71+
72+
**!!! IMPORTANT NOTE !!!**
73+
74+
Write Unit tests to check the compatibility and assure the evolution of your features.
75+
76+
*Please follow instruction script found in the Tutorial repository.*
77+
78+
### Opening your Pull Request
79+
80+
##### Go to your forked Partitura repo and Click New Pull Request
81+
82+
Open a Pull request from your new branch into the original `https://github.com/CPJKU/partitura` **develop** branch.
83+
84+
Your pull request should then be visible on:
85+
86+
[Partitura Pull Requests]: https://github.com/CPJKU/partitura/pulls "Partitura Pull Requests"
87+
88+
![](docs/source/images/pull_requests.png)
89+
90+
##### Set the base to develop and the compare to your branch
91+
92+
![](docs/source/images/open_pull_request.png)
93+
94+
##### Then create your Pull Request and add a description.
95+
96+
When you create your PR then the partitura Unitests including the Unit Tests you wrote are ran.
97+
98+
If there is no conflict with the develop branch then you will see this on your screen :
99+
100+
![](docs/source/images/unitest_pass.png)
101+
102+
If indeed the tests pass then a person from the development team of Partitura will review your work and accept your Pull Request.
103+
104+
Your features will then be included to the next release of Partitura or a discussion will kick-start on your pull request thread.

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ This will install the latest release of the package and will install all depende
3434

3535
Quickstart
3636
==========
37+
A detailed tutorial with some hands-on MIR applications is available [here](https://cpjku.github.io/partitura_tutorial/index.html).
3738

3839
The following code loads the contents of an example MusicXML file included in
3940
the package:

docs/source/conf.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,9 @@
2929
# built documents.
3030
#
3131
# The short X.Y version.
32-
version = "1.1.1" # pkg_resources.get_distribution("partitura").version
32+
version = "1.2.2" # pkg_resources.get_distribution("partitura").version
3333
# The full version, including alpha/beta/rc tags.
34-
release = "1.1.1"
34+
release = "1.2.2"
3535

3636
# # The full version, including alpha/beta/rc tags
3737
# release = pkg_resources.get_distribution("partitura").version
@@ -67,7 +67,7 @@
6767
"sphinx.ext.viewcode",
6868
# 'sphinxcontrib.napoleon',
6969
"sphinx.ext.napoleon",
70-
'nbsphinx',
70+
"nbsphinx",
7171
# 'sphinxcontrib.bibtex', # for bibliographic references
7272
# 'sphinxcontrib.rsvgconverter', # for SVG->PDF conversion in LaTeX output
7373
# 'sphinx_gallery.load_style', # load CSS for gallery (needs SG >= 0.6)
@@ -78,11 +78,11 @@
7878

7979
# These projects are also used for the sphinx_codeautolink extension:
8080
intersphinx_mapping = {
81-
'IPython': ('https://ipython.readthedocs.io/en/stable/', None),
82-
'matplotlib': ('https://matplotlib.org/', None),
83-
'numpy': ('https://docs.scipy.org/doc/numpy/', None),
84-
'pandas': ('https://pandas.pydata.org/docs/', None),
85-
'python': ('https://docs.python.org/3/', None),
81+
"IPython": ("https://ipython.readthedocs.io/en/stable/", None),
82+
"matplotlib": ("https://matplotlib.org/", None),
83+
"numpy": ("https://docs.scipy.org/doc/numpy/", None),
84+
"pandas": ("https://pandas.pydata.org/docs/", None),
85+
"python": ("https://docs.python.org/3/", None),
8686
}
8787

8888
# see http://stackoverflow.com/q/12206334/562769
96.6 KB
Loading

docs/source/images/issue_page.png

122 KB
Loading
45.7 KB
Loading

0 commit comments

Comments
 (0)