diff --git a/src/CallfireApiClient/RestApiClient.cs b/src/CallfireApiClient/RestApiClient.cs index 49b966e..4c3b066 100644 --- a/src/CallfireApiClient/RestApiClient.cs +++ b/src/CallfireApiClient/RestApiClient.cs @@ -26,7 +26,7 @@ public class RestApiClient private readonly Logger Logger = new Logger(); private readonly ISerializer JsonSerializer; private readonly IDeserializer JsonDeserializer; - private static KeyValueConfigurationCollection clientConfig; + private static KeyValueConfigurationCollection ClientConfig; /// /// RestSharp client configured to query Callfire API @@ -50,7 +50,7 @@ public class RestApiClient /// loads client configuration /// static RestApiClient() { - clientConfig = loadAppSettings(); + ClientConfig = LoadAppSettings(); } /// @@ -59,7 +59,7 @@ static RestApiClient() { /// configuration properties collection public static KeyValueConfigurationCollection getClientConfig() { - return clientConfig; + return ClientConfig; } /// @@ -70,7 +70,7 @@ public static KeyValueConfigurationCollection getClientConfig() /// public RestApiClient(IAuthenticator authenticator) { - ApiBasePath = clientConfig[ClientConstants.CONFIG_API_BASE_PATH].Value; + ApiBasePath = ClientConfig[ClientConstants.CONFIG_API_BASE_PATH].Value; JsonSerializer = new CallfireJsonConverter(); JsonDeserializer = JsonSerializer as IDeserializer; @@ -80,8 +80,8 @@ public RestApiClient(IAuthenticator authenticator) RestClient.AddHandler("application/json", JsonDeserializer); - String proxyAddress = clientConfig[ClientConstants.PROXY_ADDRESS_PROPERTY] != null ? clientConfig[ClientConstants.PROXY_ADDRESS_PROPERTY].Value : null; - String proxyCredentials = clientConfig[ClientConstants.PROXY_CREDENTIALS_PROPERTY] != null ? clientConfig[ClientConstants.PROXY_CREDENTIALS_PROPERTY].Value : null; + String proxyAddress = ClientConfig[ClientConstants.PROXY_ADDRESS_PROPERTY]?.Value; + String proxyCredentials = ClientConfig[ClientConstants.PROXY_CREDENTIALS_PROPERTY]?.Value; if (!String.IsNullOrEmpty(proxyAddress)) { @@ -96,7 +96,7 @@ public RestApiClient(IAuthenticator authenticator) { if (parsedCredentials.Length > 1) { - proxy.Credentials = new NetworkCredential(parsedCredentials[0], parsedCredentials[0]); + proxy.Credentials = new NetworkCredential(parsedCredentials[0], parsedCredentials[1]); } else { @@ -112,7 +112,7 @@ public RestApiClient(IAuthenticator authenticator) /// /// Loads client's app settings config section /// - public static KeyValueConfigurationCollection loadAppSettings() + public static KeyValueConfigurationCollection LoadAppSettings() { var path = typeof(RestApiClient).Assembly.Location; var config = ConfigurationManager.OpenExeConfiguration(path);