From 36f212feb53452ea1b0940d7dd75de084e2cb4b3 Mon Sep 17 00:00:00 2001
From: vmalinovskiy <vn.malinovskiy@gmail.com>
Date: Tue, 15 Mar 2016 20:23:46 +0200
Subject: [PATCH 1/2] vmalinovskiy - fixed bug with proxy

---
 src/CallfireApiClient/RestApiClient.cs | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/CallfireApiClient/RestApiClient.cs b/src/CallfireApiClient/RestApiClient.cs
index 49b966e..eeb5ef2 100644
--- a/src/CallfireApiClient/RestApiClient.cs
+++ b/src/CallfireApiClient/RestApiClient.cs
@@ -26,7 +26,7 @@ public class RestApiClient
         private readonly Logger Logger = new Logger();
         private readonly ISerializer JsonSerializer;
         private readonly IDeserializer JsonDeserializer;
-        private static KeyValueConfigurationCollection clientConfig;
+        private static KeyValueConfigurationCollection ClientConfig;
 
         /// <summary>
         /// RestSharp client configured to query Callfire API
@@ -50,7 +50,7 @@ public class RestApiClient
         /// loads client configuration
         /// </summary>
         static RestApiClient() {
-            clientConfig = loadAppSettings();
+            ClientConfig = LoadAppSettings();
         }
 
         /// <summary>
@@ -59,7 +59,7 @@ static RestApiClient() {
         /// <value>configuration properties collection</value>
         public static KeyValueConfigurationCollection getClientConfig()
         {
-            return clientConfig;
+            return ClientConfig;
         }
 
         /// <summary>
@@ -70,7 +70,7 @@ public static KeyValueConfigurationCollection getClientConfig()
         /// </param>
         public RestApiClient(IAuthenticator authenticator)
         {
-            ApiBasePath = clientConfig[ClientConstants.CONFIG_API_BASE_PATH].Value;
+            ApiBasePath = ClientConfig[ClientConstants.CONFIG_API_BASE_PATH].Value;
             JsonSerializer = new CallfireJsonConverter();
             JsonDeserializer = JsonSerializer as IDeserializer;
 
@@ -80,8 +80,8 @@ public RestApiClient(IAuthenticator authenticator)
             RestClient.AddHandler("application/json", JsonDeserializer);
 
             
-            String proxyAddress = clientConfig[ClientConstants.PROXY_ADDRESS_PROPERTY] != null ? clientConfig[ClientConstants.PROXY_ADDRESS_PROPERTY].Value : null; 
-            String proxyCredentials = clientConfig[ClientConstants.PROXY_CREDENTIALS_PROPERTY] != null ? clientConfig[ClientConstants.PROXY_CREDENTIALS_PROPERTY].Value : null; 
+            String proxyAddress = ClientConfig[ClientConstants.PROXY_ADDRESS_PROPERTY] != null ? ClientConfig[ClientConstants.PROXY_ADDRESS_PROPERTY].Value : null; 
+            String proxyCredentials = ClientConfig[ClientConstants.PROXY_CREDENTIALS_PROPERTY] != null ? ClientConfig[ClientConstants.PROXY_CREDENTIALS_PROPERTY].Value : null; 
 
             if (!String.IsNullOrEmpty(proxyAddress))
             {
@@ -96,7 +96,7 @@ public RestApiClient(IAuthenticator authenticator)
                 {
                     if (parsedCredentials.Length > 1)
                     {
-                        proxy.Credentials = new NetworkCredential(parsedCredentials[0], parsedCredentials[0]);
+                        proxy.Credentials = new NetworkCredential(parsedCredentials[0], parsedCredentials[1]);
                     }
                     else
                     {
@@ -112,7 +112,7 @@ public RestApiClient(IAuthenticator authenticator)
         /// <summary>
         /// Loads client's app settings config section
         /// </summary>
-        public static KeyValueConfigurationCollection loadAppSettings()
+        public static KeyValueConfigurationCollection LoadAppSettings()
         {
             var path = typeof(RestApiClient).Assembly.Location;
             var config = ConfigurationManager.OpenExeConfiguration(path);

From dbbe5ae884bafecae01be6438832952eb045713f Mon Sep 17 00:00:00 2001
From: vmalinovskiy <vn.malinovskiy@gmail.com>
Date: Tue, 15 Mar 2016 20:42:29 +0200
Subject: [PATCH 2/2] vmalinovskiy - proxy code refactoring

---
 src/CallfireApiClient/RestApiClient.cs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/CallfireApiClient/RestApiClient.cs b/src/CallfireApiClient/RestApiClient.cs
index eeb5ef2..4c3b066 100644
--- a/src/CallfireApiClient/RestApiClient.cs
+++ b/src/CallfireApiClient/RestApiClient.cs
@@ -80,8 +80,8 @@ public RestApiClient(IAuthenticator authenticator)
             RestClient.AddHandler("application/json", JsonDeserializer);
 
             
-            String proxyAddress = ClientConfig[ClientConstants.PROXY_ADDRESS_PROPERTY] != null ? ClientConfig[ClientConstants.PROXY_ADDRESS_PROPERTY].Value : null; 
-            String proxyCredentials = ClientConfig[ClientConstants.PROXY_CREDENTIALS_PROPERTY] != null ? ClientConfig[ClientConstants.PROXY_CREDENTIALS_PROPERTY].Value : null; 
+            String proxyAddress = ClientConfig[ClientConstants.PROXY_ADDRESS_PROPERTY]?.Value; 
+            String proxyCredentials = ClientConfig[ClientConstants.PROXY_CREDENTIALS_PROPERTY]?.Value; 
 
             if (!String.IsNullOrEmpty(proxyAddress))
             {