Skip to content

Commit 37ffa94

Browse files
authored
test(backends): remove now unused supports_arrays_outside_of_select backend flag (ibis-project#8935)
Test case configuration now happens through pytest markers.
1 parent 5095349 commit 37ffa94

8 files changed

Lines changed: 2 additions & 9 deletions

File tree

ibis/backends/druid/tests/conftest.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,6 @@ class TestConf(ServiceBackendTest):
9696
check_dtype = False
9797
returned_timestamp_unit = "s"
9898
supports_arrays = False
99-
supports_arrays_outside_of_select = supports_arrays
10099
native_bool = True
101100
supports_structs = False
102101
supports_json = False # it does, but we haven't implemented it

ibis/backends/exasol/tests/conftest.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ class TestConf(ServiceBackendTest):
2727
check_dtype = False
2828
check_names = False
2929
supports_arrays = False
30-
supports_arrays_outside_of_select = supports_arrays
3130
supports_divide_by_zero = False
3231
returned_timestamp_unit = "us"
3332
supported_to_timestamp_units = {"s", "ms", "us"}

ibis/backends/impala/tests/conftest.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222

2323
class TestConf(BackendTest):
2424
supports_arrays = True
25-
supports_arrays_outside_of_select = False
2625
check_dtype = False
2726
supports_divide_by_zero = True
2827
returned_timestamp_unit = "s"

ibis/backends/mssql/tests/conftest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ class TestConf(ServiceBackendTest):
2424
# MSSQL has the same rounding behavior as postgres
2525
check_dtype = False
2626
returned_timestamp_unit = "s"
27-
supports_arrays_outside_of_select = supports_arrays = False
27+
supports_arrays = False
2828
supports_structs = False
2929
supports_json = False
3030
rounding_method = "half_to_even"

ibis/backends/mysql/tests/conftest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ class TestConf(ServiceBackendTest):
2424
# mysql has the same rounding behavior as postgres
2525
check_dtype = False
2626
returned_timestamp_unit = "s"
27-
supports_arrays = supports_arrays_outside_of_select = False
27+
supports_arrays = False
2828
native_bool = False
2929
supports_structs = False
3030
rounding_method = "half_to_even"

ibis/backends/oracle/tests/conftest.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ class TestConf(ServiceBackendTest):
3636
check_dtype = False
3737
returned_timestamp_unit = "s"
3838
supports_arrays = False
39-
supports_arrays_outside_of_select = False
4039
# Automatic mutate so that logical type in ibis returns as bool
4140
# but the backend will still do whatever it's going to do
4241
native_bool = False

ibis/backends/sqlite/tests/conftest.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616

1717
class TestConf(BackendTest):
1818
supports_arrays = False
19-
supports_arrays_outside_of_select = supports_arrays
2019
check_dtype = False
2120
returned_timestamp_unit = "s"
2221
supports_structs = False

ibis/backends/tests/base.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,6 @@ class BackendTest(abc.ABC):
3636
"Check that column name matches when comparing Pandas Series"
3737
supports_arrays: bool = True
3838
"Whether backend supports Arrays / Lists"
39-
supports_arrays_outside_of_select: bool = supports_arrays
40-
"Whether backend supports Arrays / Lists outside of Select Statements"
4139
supports_divide_by_zero: bool = False
4240
"Whether backend supports division by zero"
4341
returned_timestamp_unit: str = "us"

0 commit comments

Comments
 (0)