Skip to content

Commit 8553915

Browse files
authored
test(backends): remove now unused supports_window_operations backend flag (ibis-project#8932)
Test case configuration now happens through pytest markers.
1 parent fdbe67c commit 8553915

8 files changed

Lines changed: 0 additions & 9 deletions

File tree

ibis/backends/clickhouse/tests/conftest.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424

2525
class TestConf(ServiceBackendTest):
2626
check_dtype = False
27-
supports_window_operations = False
2827
returned_timestamp_unit = "s"
2928
supported_to_timestamp_units = {"s"}
3029
supports_floating_modulus = False

ibis/backends/druid/tests/conftest.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,6 @@ def run_query(session: Session, query: str) -> None:
9494
class TestConf(ServiceBackendTest):
9595
# druid has the same rounding behavior as postgres
9696
check_dtype = False
97-
supports_window_operations = False
9897
returned_timestamp_unit = "s"
9998
supports_arrays = False
10099
supports_arrays_outside_of_select = supports_arrays

ibis/backends/exasol/tests/conftest.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ class TestConf(ServiceBackendTest):
2828
check_names = False
2929
supports_arrays = False
3030
supports_arrays_outside_of_select = supports_arrays
31-
supports_window_operations = True
3231
supports_divide_by_zero = False
3332
returned_timestamp_unit = "us"
3433
supported_to_timestamp_units = {"s", "ms", "us"}

ibis/backends/mssql/tests/conftest.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
class TestConf(ServiceBackendTest):
2424
# MSSQL has the same rounding behavior as postgres
2525
check_dtype = False
26-
supports_window_operations = False
2726
returned_timestamp_unit = "s"
2827
supports_arrays_outside_of_select = supports_arrays = False
2928
supports_structs = False

ibis/backends/mysql/tests/conftest.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ class TestConf(ServiceBackendTest):
3030
rounding_method = "half_to_even"
3131
service_name = "mysql"
3232
deps = ("pymysql",)
33-
supports_window_operations = True
3433

3534
@property
3635
def test_files(self) -> Iterable[Path]:

ibis/backends/oracle/tests/conftest.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@
3434

3535
class TestConf(ServiceBackendTest):
3636
check_dtype = False
37-
supports_window_operations = False
3837
returned_timestamp_unit = "s"
3938
supports_arrays = False
4039
supports_arrays_outside_of_select = False

ibis/backends/sqlite/tests/conftest.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
class TestConf(BackendTest):
1818
supports_arrays = False
1919
supports_arrays_outside_of_select = supports_arrays
20-
supports_window_operations = True
2120
check_dtype = False
2221
returned_timestamp_unit = "s"
2322
supports_structs = False

ibis/backends/tests/base.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,6 @@ class BackendTest(abc.ABC):
3838
"Whether backend supports Arrays / Lists"
3939
supports_arrays_outside_of_select: bool = supports_arrays
4040
"Whether backend supports Arrays / Lists outside of Select Statements"
41-
supports_window_operations: bool = True
42-
"Whether backend supports Window Operations"
4341
supports_divide_by_zero: bool = False
4442
"Whether backend supports division by zero"
4543
returned_timestamp_unit: str = "us"

0 commit comments

Comments
 (0)