ENH: Add isort pre-commit hooks

Author: Phillip Cloud <cpcloud@gmail.com>

Closes ibis-project#1759 from cpcloud/isort-pre-commit and squashes the following commits:

acd6ea1 [Phillip Cloud] Pass CIRCLECI envar through
388f450 [Phillip Cloud] Add isort pre-commit hooks

Author: cpcloud

.circleci/config.yml

@@ -62,7 +62,7 @@ test: &test
     - run:
         name: Execute Pytest
         command: |
-          docker-compose run -e PYTHONHASHSEED=$PYTHONHASHSEED ibis \
+          docker-compose run -e PYTHONHASHSEED=$PYTHONHASHSEED -e CIRCLECI=$CIRCLECI ibis \
             pytest ibis -m "not udf" \
                         -ra \
                         --numprocesses auto \

.isort.cfg

@@ -0,0 +1,2 @@
+[settings]
+known_third_party = asv,click,clickhouse_driver,dateutil,google,graphviz,impala,jinja2,kudu,multipledispatch,numpy,pandas,pkg_resources,plumbum,psycopg2,pyarrow,pydata_google_auth,pymapd,pymysql,pytest,pytz,regex,requests,ruamel,setuptools,sphinx_rtd_theme,sqlalchemy,toolz

.pre-commit-config.yaml

@@ -1,12 +1,12 @@
 repos:
-  - repo: git://github.com/pre-commit/pre-commit-hooks
-    rev: v2.1.0
+  - repo: https://github.com/asottile/seed-isort-config
+    rev: v1.7.0
     hooks:
-      - id: flake8
-        types:
-          - python
-        args: ['--config=setup.cfg']
-
+      - id: seed-isort-config
+  - repo: https://github.com/pre-commit/mirrors-isort
+    rev: v4.3.17
+    hooks:
+      - id: isort
   - repo: https://github.com/ambv/black
     # we need to use this commit or later, to pickup the fix that splits
     # trailing comma syntax into call vs def, both of which weren't implemented
@@ -15,9 +15,14 @@ repos:
     rev: cea13f498418784e22f8fbd78db3f9240a2bad11
     hooks:
       - id: black
-        args: ['--config=pyproject.toml']
         # a side effect of black running exclude filters and then include
         # filters (the built-in black behavior) is that a command line such as
         # black --exclude foo.py foo.py will still format foo.py. We avoid this
         # in pre-commit by not passing staged files.
         pass_filenames: false
+  - repo: git://github.com/pre-commit/pre-commit-hooks
+    rev: v2.1.0
+    hooks:
+      - id: flake8
+        types:
+          - python

ci/asvconfig.py

@@ -1,10 +1,10 @@
 #!/usr/bin/env python
 
-import sys
-import asv
 import json
 import socket
+import sys
 
+import asv
 
 if __name__ == '__main__':
     if len(sys.argv) > 1:

ci/datamgr.py

@@ -1,22 +1,21 @@
 #!/usr/bin/env python
 
-import os
 import json
 import logging
-import zipfile
+import os
 import tempfile
 import warnings
+import zipfile
 from pathlib import Path
 
 import click
 import pandas as pd
 import sqlalchemy as sa
-from toolz import dissoc
 from plumbum import local
+from toolz import dissoc
 
 import ibis
 
-
 SCRIPT_DIR = Path(__file__).parent.absolute()
 DATA_DIR_NAME = 'ibis-testing-data'
 DATA_DIR = Path(

ci/feedstock.py

@@ -4,18 +4,15 @@
 import shutil
 import sys
 import tempfile
-
 from pathlib import Path
 
 import click
 import ruamel.yaml
-
 from jinja2 import Environment, FileSystemLoader
-from plumbum.cmd import git, conda
+from plumbum.cmd import conda, git
 
 import ibis
 
-
 IBIS_DIR = Path(__file__).parent.parent.absolute()
 
 

ci/impalamgr.py

@@ -3,22 +3,18 @@
 import concurrent.futures
 import itertools
 import os
-
 from io import BytesIO
 from pathlib import Path
 
 import click
 import toolz
-
-from plumbum import local, CommandNotFound
-from plumbum.cmd import make, cmake
+from plumbum import CommandNotFound, local
+from plumbum.cmd import cmake, make
 
 import ibis
-
 from ibis.common import IbisError
 from ibis.impala.tests.conftest import IbisTestEnv
 
-
 SCRIPT_DIR = Path(__file__).parent.absolute()
 DATA_DIR = Path(
     os.environ.get(

ci/requirements-3.5-dev.yml

@@ -13,12 +13,14 @@ dependencies:
   - google-cloud-bigquery>=1.0.0
   - graphviz
   - impyla<0.14.2
+  - isort
   - jinja2
   - lz4
   - multipledispatch>=0.6.0
   - mypy
   - numpy
   - pandas>=0.21
+  - pip
   - plumbum
   - pre_commit
   - psycopg2
@@ -43,3 +45,5 @@ dependencies:
   - toolz
   - xorg-libxpm
   - xorg-libxrender
+  - pip:
+    - seed-isort-config

ci/requirements-3.6-dev.yml

@@ -11,12 +11,14 @@ dependencies:
   - google-cloud-bigquery>=1.0.0
   - graphviz
   - impyla>=0.14.2
+  - isort
   - jinja2
   - lz4
   - multipledispatch>=0.6.0
   - mypy
   - numpy
   - pandas>=0.21
+  - pip
   - plumbum
   - pre_commit
   - psycopg2
@@ -41,3 +43,5 @@ dependencies:
   - toolz
   - xorg-libxpm
   - xorg-libxrender
+  - pip:
+      - seed-isort-config

ci/requirements-3.7-dev.yml

@@ -11,12 +11,14 @@ dependencies:
   - google-cloud-bigquery>=1.0.0
   - graphviz
   - impyla>=0.14.2
+  - isort
   - jinja2
   - lz4
   - multipledispatch>=0.6.0
   - mypy
   - numpy
   - pandas>=0.21
+  - pip
   - plumbum
   - pre_commit
   - psycopg2
@@ -41,3 +43,5 @@ dependencies:
   - toolz
   - xorg-libxpm
   - xorg-libxrender
+  - pip:
+    - seed-isort-config