Skip to content

Commit ede3a83

Browse files
kszucsgforsyth
andauthored
test(backends): remove now unused supports_floating_modulus backend flag (ibis-project#8939)
Test case configuration now happens through pytest markers. depends on ibis-project#8937 --------- Co-authored-by: Gil Forsyth <gforsyth@users.noreply.github.com>
1 parent a19bb00 commit ede3a83

5 files changed

Lines changed: 0 additions & 6 deletions

File tree

docs/contribute/05_reference.qmd

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ from ibis.backends.tests.base import BackendTest
1818
class TestConf(BackendTest):
1919
"""Backend-specific class with information for testing."""
2020

21-
supports_floating_modulus = False
2221
returned_timestamp_unit = "us"
2322
supports_structs = True
2423
supports_json = True

ibis/backends/bigquery/tests/conftest.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
class TestConf(BackendTest):
2222
"""Backend-specific class with information for testing."""
2323

24-
supports_floating_modulus = False
2524
returned_timestamp_unit = "us"
2625
supports_structs = True
2726
supports_json = True

ibis/backends/clickhouse/tests/conftest.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ class TestConf(ServiceBackendTest):
2626
check_dtype = False
2727
returned_timestamp_unit = "s"
2828
supported_to_timestamp_units = {"s"}
29-
supports_floating_modulus = False
3029
supports_json = False
3130
force_sort = True
3231
rounding_method = "half_to_even"

ibis/backends/exasol/tests/conftest.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ class TestConf(ServiceBackendTest):
2929
supports_arrays = False
3030
returned_timestamp_unit = "us"
3131
supported_to_timestamp_units = {"s", "ms", "us"}
32-
supports_floating_modulus = True
3332
native_bool = True
3433
supports_structs = False
3534
supports_json = False

ibis/backends/tests/base.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,6 @@ class BackendTest(abc.ABC):
3838
"Whether backend supports Arrays / Lists"
3939
returned_timestamp_unit: str = "us"
4040
supported_to_timestamp_units = {"s", "ms", "us"}
41-
supports_floating_modulus: bool = True
42-
"Whether backend supports floating point in modulus operations"
4341
native_bool: bool = True
4442
"Whether backend has native boolean types"
4543
supports_structs: bool = True

0 commit comments

Comments
 (0)