From 63090077f26f4a5d7569ac607123077757730c25 Mon Sep 17 00:00:00 2001 From: Samiya Akhtar Date: Tue, 31 Mar 2020 16:37:25 -0700 Subject: [PATCH 1/3] Fixing bug 1280 --- docs/commands/data.json | 6 ++++++ package.json | 2 +- src/commands/deployment/get.ts | 2 +- yarn.lock | 8 ++++---- 4 files changed, 12 insertions(+), 6 deletions(-) diff --git a/docs/commands/data.json b/docs/commands/data.json index 966eda283..f08996ada 100644 --- a/docs/commands/data.json +++ b/docs/commands/data.json @@ -417,6 +417,12 @@ ], "markdown": "## Description\n\nCreate new variable group in Azure DevOps project\n\n## Command Prerequisites\n\nIn addition to an existing\n[Azure DevOps project](https://azure.microsoft.com/en-us/services/devops/), to\nlink secrets from an Azure key vault as variables in Variable Group, you will\nneed an existing key vault containing your secrets and the Service Principal for\nauthorization with Azure Key Vault.\n\n1. Use existng or\n [create a service principal either in Azure Portal](https://docs.microsoft.com/en-us/azure/active-directory/develop/howto-create-service-principal-portal)\n or\n [with Azure CLI](https://docs.microsoft.com/en-us/cli/azure/create-an-azure-service-principal-azure-cli?view=azure-cli-latest).\n2. Use existing or\n [create a Azure Container Registry in Azure Portal](https://docs.microsoft.com/en-us/azure/container-registry/container-registry-get-started-portal)\n or\n [with Azure CLI](https://docs.microsoft.com/en-us/azure/container-registry/container-registry-get-started-azure-cli).\n" }, + "project get-display-name": { + "command": "get-display-name", + "alias": "gdn", + "description": "Gets display name for a service", + "options": [] + }, "project init": { "command": "init", "alias": "i", diff --git a/package.json b/package.json index d47a16df1..20359968b 100644 --- a/package.json +++ b/package.json @@ -97,7 +97,7 @@ "open": "^6.4.0", "shelljs": "^0.8.3", "simple-git": "^1.126.0", - "spektate": "^1.0.4", + "spektate": "^1.0.6", "ssh-url": "^0.1.5", "uuid": "^3.3.3", "winston": "^3.2.1" diff --git a/src/commands/deployment/get.ts b/src/commands/deployment/get.ts index 3eea9c783..b9644d2f3 100644 --- a/src/commands/deployment/get.ts +++ b/src/commands/deployment/get.ts @@ -572,7 +572,7 @@ export const fetchPRInformation = ( const strPr = deployment.pr.toString(); if (repo) { - const promise = fetchPR(repo, strPr, initObj.accountName); + const promise = fetchPR(repo, strPr, initObj.accessToken); promise.then((pr) => { if (pr) { pullRequests[strPr] = pr; diff --git a/yarn.lock b/yarn.lock index d8e5bbf28..b3908a6ce 100644 --- a/yarn.lock +++ b/yarn.lock @@ -6729,10 +6729,10 @@ spdx-license-ids@^3.0.0: resolved "https://registry.yarnpkg.com/spdx-license-ids/-/spdx-license-ids-3.0.5.tgz#3694b5804567a458d3c8045842a6358632f62654" integrity sha512-J+FWzZoynJEXGphVIS+XEh3kFSjZX/1i9gFBaWQcB+/tmpe2qUsSBABpcxqxnAxFdiUFEgAX1bjYGQvIZmoz9Q== -spektate@^1.0.4: - version "1.0.4" - resolved "https://registry.yarnpkg.com/spektate/-/spektate-1.0.4.tgz#672e6d7cdf282adadddaf455d1ae41513d522637" - integrity sha512-Yd31la4eMPg9lX9RztoATeu7fzONunvpPVncbO9jdhoJPkvdrT9jcctFjf1j1rb5/us8rxA0F1Ufju1u3UIv0A== +spektate@^1.0.6: + version "1.0.6" + resolved "https://registry.yarnpkg.com/spektate/-/spektate-1.0.6.tgz#b855654d7ec57442b11e30a901e6ebdc0d0cd36d" + integrity sha512-P+TOQPdJjmYPwAucwIju818QaeaOrpCVfWj1RVMN6wj5iGszTk39FB9yCckHQ6o12TIo6UkZM+3I3OM1ZczN5g== dependencies: axios "^0.19.0" azure-storage "^2.10.3" From 302549a40d417b865190454e7696006040f7421d Mon Sep 17 00:00:00 2001 From: Samiya Akhtar Date: Tue, 31 Mar 2020 16:39:25 -0700 Subject: [PATCH 2/3] Remove get-display-name From ff6d75c059c0a859571212a3e480c5d31685901d Mon Sep 17 00:00:00 2001 From: Samiya Akhtar Date: Tue, 31 Mar 2020 16:40:55 -0700 Subject: [PATCH 3/3] Update data.json --- docs/commands/data.json | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/docs/commands/data.json b/docs/commands/data.json index f08996ada..79b206aa9 100644 --- a/docs/commands/data.json +++ b/docs/commands/data.json @@ -417,12 +417,6 @@ ], "markdown": "## Description\n\nCreate new variable group in Azure DevOps project\n\n## Command Prerequisites\n\nIn addition to an existing\n[Azure DevOps project](https://azure.microsoft.com/en-us/services/devops/), to\nlink secrets from an Azure key vault as variables in Variable Group, you will\nneed an existing key vault containing your secrets and the Service Principal for\nauthorization with Azure Key Vault.\n\n1. Use existng or\n [create a service principal either in Azure Portal](https://docs.microsoft.com/en-us/azure/active-directory/develop/howto-create-service-principal-portal)\n or\n [with Azure CLI](https://docs.microsoft.com/en-us/cli/azure/create-an-azure-service-principal-azure-cli?view=azure-cli-latest).\n2. Use existing or\n [create a Azure Container Registry in Azure Portal](https://docs.microsoft.com/en-us/azure/container-registry/container-registry-get-started-portal)\n or\n [with Azure CLI](https://docs.microsoft.com/en-us/azure/container-registry/container-registry-get-started-azure-cli).\n" }, - "project get-display-name": { - "command": "get-display-name", - "alias": "gdn", - "description": "Gets display name for a service", - "options": [] - }, "project init": { "command": "init", "alias": "i", @@ -680,4 +674,4 @@ } ] } -} \ No newline at end of file +}