Skip to content

Commit 47ebc27

Browse files
committed
Fix crash when screen scale factor greater than 1
1 parent 1b67503 commit 47ebc27

2 files changed

Lines changed: 8 additions & 4 deletions

File tree

src/QCefView.cpp

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,9 @@ QCefView::QCefView(const QString url, const QCefSetting* setting, QWidget* paren
2828

2929
setMouseTracking(true);
3030
setFocusPolicy(Qt::WheelFocus);
31+
32+
// create browser
33+
d_ptr->createCefBrowser(this, url, setting);
3134
}
3235

3336
QCefView::QCefView(QWidget* parent /*= 0*/)
@@ -37,6 +40,11 @@ QCefView::QCefView(QWidget* parent /*= 0*/)
3740
QCefView::~QCefView()
3841
{
3942
qDebug() << this << "is being destructed";
43+
44+
if (d_ptr) {
45+
d_ptr->destroyCefBrowser();
46+
d_ptr.reset();
47+
}
4048
}
4149

4250
void

src/details/QCefViewPrivate.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,14 +52,10 @@ QCefViewPrivate::QCefViewPrivate(QCefContextPrivate* ctx,
5252
sLiveInstances.insert(this);
5353

5454
isOSRModeEnabled_ = pContextPrivate_->cefConfig()->WindowlessRenderingEnabled().toBool();
55-
56-
createCefBrowser(view, url, setting);
5755
}
5856

5957
QCefViewPrivate::~QCefViewPrivate()
6058
{
61-
destroyCefBrowser();
62-
6359
sLiveInstances.remove(this);
6460
}
6561

0 commit comments

Comments
 (0)