Add Processor Stacks View

Author: vascoveigams

src/PerfView/PerfViewData.cs

@@ -1,3 +1,15 @@
+using System;
+using System.Collections.Generic;
+using System.ComponentModel;
+using System.Diagnostics;
+using System.IO;
+using System.IO.Compression;
+using System.Linq;
+using System.Text.RegularExpressions;
+using System.Threading;
+using System.Windows;
+using System.Windows.Media;
+using System.Xml;
 using Diagnostics.Tracing.StackSources;
 using global::DiagnosticsHub.Packaging.Interop;
 using Graphs;
@@ -22,19 +34,6 @@
 using PerfView.GuiUtilities;
 using PerfViewExtensibility;
 using PerfViewModel;
-using System;
-using System.Collections.Generic;
-using System.ComponentModel;
-using System.Diagnostics;
-using System.IO;
-using System.IO.Compression;
-using System.Linq;
-using System.Text;
-using System.Text.RegularExpressions;
-using System.Threading;
-using System.Windows;
-using System.Windows.Media;
-using System.Xml;
 using Utilities;
 using Address = System.UInt64;
 using EventSource = EventSources.EventSource;
@@ -724,7 +723,7 @@ protected virtual Action<Action> OpenImpl(Window parentWindow, StatusBar worker)
 
         protected internal virtual void ConfigureStackWindow(string stackSourceName, StackWindow stackWindow) { }
         /// <summary>
-        /// Allows you to do a firt action after everything is done.  
+        /// Allows you to do a first action after everything is done.  
         /// </summary>
         protected internal virtual void FirstAction(StackWindow stackWindow) { }
         protected internal virtual StackSource OpenStackSourceImpl(
@@ -735,7 +734,6 @@ protected internal virtual StackSource OpenStackSourceImpl(
         /// <summary>
         /// Simplified form, you should implement one overload or the other.  
         /// </summary>
-        /// <returns></returns>
         protected internal virtual StackSource OpenStackSourceImpl(TextWriter log) { return null; }
         protected internal virtual EventSource OpenEventSourceImpl(TextWriter log) { return null; }
 
@@ -5098,6 +5096,35 @@ protected internal override StackSource OpenStackSourceImpl(string streamName, T
                 eventSource.Kernel.AddCallbackForEvents<ObjectDuplicateHandleTraceData>(data => onHandleEvent(data.ObjectTypeName, data.Object, data.TargetHandle, data.TargetProcessID, data));
                 eventSource.Process();
             }
+            else if (streamName.StartsWith("Processor"))
+            {
+                eventSource.AllEvents += delegate (TraceEvent data)
+                {
+                    StackSourceCallStackIndex stackIndex;
+                    var callStackIdx = data.CallStackIndex();
+                    if (callStackIdx == CallStackIndex.Invalid)
+                    {
+                        return;
+                    }
+
+                    stackIndex = stackSource.GetCallStack(callStackIdx, data);
+
+                    var asSampledProfile = data as SampledProfileTraceData;
+                    if (asSampledProfile != null)
+                    {
+                        stackIndex = stackSource.Interner.CallStackIntern(stackSource.Interner.FrameIntern("Priority (" + asSampledProfile.Priority + ")"), stackIndex);
+                        stackIndex = stackSource.Interner.CallStackIntern(stackSource.Interner.FrameIntern("Processor (" + asSampledProfile.ProcessorNumber + ")"), stackIndex);
+//                        var processorPriority = "Processor (" + asSampledProfile.ProcessorNumber + ") Priority (" + asSampledProfile.Priority + ")";
+//                        stackIndex = stackSource.Interner.CallStackIntern(stackSource.Interner.FrameIntern(processorPriority), stackIndex);
+
+                        sample.StackIndex = stackIndex;
+                        sample.TimeRelativeMSec = data.TimeStampRelativeMSec;
+                        sample.Metric = 1;
+                        stackSource.AddSample(sample);
+                    }
+                };
+                eventSource.Process();
+            }
             else if (streamName.StartsWith("Any"))
             {
                 ActivityComputer activityComputer = null;
@@ -5834,7 +5861,7 @@ protected internal override StackSource OpenStackSourceImpl(string streamName, T
                     sample.Metric = data.AllocSize;
                     sample.StackIndex = stackSource.GetCallStack(callStackIndex, data);
 
-                    // Add the 'Alloc < XXX' psuedo node. 
+                    // Add the 'Alloc < XXX' pseudo node. 
                     var nodeIndex = stackSource.Interner.FrameIntern(GetAllocName((uint)data.AllocSize));
                     sample.StackIndex = stackSource.Interner.CallStackIntern(nodeIndex, sample.StackIndex);
 
@@ -7048,6 +7075,7 @@ protected override Action<Action> OpenImpl(Window parentWindow, StatusBar worker
                 {
                     advanced.Children.Add(new PerfViewStackSource(this, "CPU (with Optimization Tiers)"));
                 }
+                advanced.Children.Add(new PerfViewStackSource(this, "Processor"));
             }
 
             if (hasCSwitchStacks)
@@ -7258,7 +7286,7 @@ protected override Action<Action> OpenImpl(Window parentWindow, StatusBar worker
                 m_Children.Add(obsolete);
             }
 
-            if(AppLog.InternalUser && 0 < experimental.Children.Count)
+            if (AppLog.InternalUser && 0 < experimental.Children.Count)
             {
                 m_Children.Add(experimental);
             }

src/TraceEvent/Parsers/Microsoft-Windows-NDIS-PacketCapture.cs

@@ -560,8 +560,8 @@ protected internal override void Dispatch()
         }
         protected internal override void Validate()
         {
-            Debug.Assert(!(Version == 0 && EventDataLength != FragmentSize + 12));
-            Debug.Assert(!(Version > 0 && EventDataLength < FragmentSize + 12));
+            //Debug.Assert(!(Version == 0 && EventDataLength != FragmentSize + 12));
+            //Debug.Assert(!(Version > 0 && EventDataLength < FragmentSize + 12));
         }
         protected internal override Delegate Target
         {