Fix double value parsing in trigger expressions

vascoveigams · vascoveigams · commit a38a4575b581 · 2020-06-04T23:56:41.000-07:00
diff --git a/src/PerfView/Triggers.cs b/src/PerfView/Triggers.cs
@@ -1410,7 +1410,7 @@ public bool Succeeds(string fieldValue)
                         var expressionValue = Convert.ToInt64(Value);
                         result = -expressionValue.CompareTo(longValue);     // negated because the x and y arguments are swapped.  
                     }
-                    else if (double.TryParse(fieldValue, System.Globalization.NumberStyles.Integer | System.Globalization.NumberStyles.AllowDecimalPoint, null, out double doubleValue))
+                    else if (double.TryParse(fieldValue, System.Globalization.NumberStyles.Number, null, out double doubleValue))
                     {
                         var expressionValue = Convert.ToDouble(Value);
                         result = -expressionValue.CompareTo(doubleValue);   // negated because the x and y arguments are swapped.

Original file line number	Diff line number	Diff line change
`@@ -1410,7 +1410,7 @@ public bool Succeeds(string fieldValue)`
`1410`	`1410`	`var expressionValue = Convert.ToInt64(Value);`
`1411`	`1411`	`result = -expressionValue.CompareTo(longValue); // negated because the x and y arguments are swapped.`
`1412`	`1412`	`}`
`1413`		`- else if (double.TryParse(fieldValue, System.Globalization.NumberStyles.Integer \| System.Globalization.NumberStyles.AllowDecimalPoint, null, out double doubleValue))`
	`1413`	`+ else if (double.TryParse(fieldValue, System.Globalization.NumberStyles.Number, null, out double doubleValue))`
`1414`	`1414`	`{`
`1415`	`1415`	`var expressionValue = Convert.ToDouble(Value);`
`1416`	`1416`	`result = -expressionValue.CompareTo(doubleValue); // negated because the x and y arguments are swapped.`