13.7.4 - Fixes

- **Updated**
    - Added extra/packing for the packs in this module
    - `Token Shake on Damaged`
        - Updated the enable text to include a warning about the possibility of tokens turning invisible
    - `Critical`
        - Fix some logic for the `Show On...` settings (🐛 @fumu)

Author: ChasarooniZ

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 - **Updated**
     - Added extra/packing for the packs in this module
+    - `Token Shake on Damaged`
+        - Updated the enable text to include a warning about the possibility of tokens turning invisible
     - `Critical`
         - Fix some logic for the `Show On...` settings (🐛 @Fumu)
 

languages/en.json

@@ -283,7 +283,7 @@
             "token-dmg-shake": {
                 "enabled": {
                     "name": "Enable Token Shaking on Damage",
-                    "hint": "When you apply damage to a token cause it to shake"
+                    "hint": "When you apply damage to a token cause it to shake (Note: This can behave unexpectedly if you have an inconsistent internet connection, if your tokens become hidden, you'll need to set their opacity back to the expected value)"
                 },
                 "distance": {
                     "name": "Shake Distance",

scripts/helpers/animation/crit/critAnimation.js

@@ -72,11 +72,12 @@ export function createTestCritAnimation(data) {
 /**
  * Determines if the critical hit animation should be canceled.
  * @param {object} rollDeets - The details of the roll.
- * @returns {boolean} True if the animation should be canceled, false otherwise.
+ * @returns {'default' | 'yes' | 'no'} True if the animation should be canceled, false otherwise.
  */
-function shouldCancelCriticalHit(rollDeets, isEnabled) {
-    if (isEnabled) return false;
-    if (rollDeets.type !== "custom") return false;
+function shouldCancelCriticalHit(rollDeets, enabledType) {
+    if (enabledType === 'no') return false;
+    if (enabledType === 'yes') return true;
+    if (rollDeets.type === "custom") return false;
 
     const isAttack = rollDeets.type === "attack-roll";
     const showOn = getSetting("critical.show-on");