Skip to content

Commit 3d06d60

Browse files
committed
Added type definitions
1 parent 3c0240d commit 3d06d60

File tree

7 files changed

+32
-44
lines changed

7 files changed

+32
-44
lines changed

.npmignore

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,2 @@
11
**/**/*.*
2-
!dist/**/*.*
3-
dist/**/*.d.ts
2+
!dist/**/*.*

README.md

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
# karma-chromiumedge-launcher
1+
# karma-chromium-edge-launcher
22

33
> Launcher for Chromium Edge Canary, Dev, Beta and Stable channels for Windows OS and Mac OS
44
5-
Now available on [NPM Registry](https://www.npmjs.com/package/@chiragrupani/karma-chromium-edge-launcher) 🎉
5+
Available in [NPM Registry](https://www.npmjs.com/package/@chiragrupani/karma-chromium-edge-launcher) ??
66

77
## Installation
88

@@ -44,6 +44,21 @@ If you want to launch browser in headless mode, below is correspondling list:
4444
- "EdgeBetaHeadless"
4545
- "EdgeCanaryHeadless"
4646

47+
If you want to explicity specify the path for browser installation, set environment variable from this list, corresponding to release channel:
48+
49+
```bash
50+
EDGE_BIN, EDGE_BETA_BIN, EDGE_DEV_BIN, EDGE_CANARY_BIN
51+
```
52+
53+
Example:
54+
55+
```bash
56+
# Add at top of karma.conf.js
57+
process.env.EDGE_DEV_BIN =
58+
"C:\\Program Files (x86)\\Microsoft\\Edge Dev\\Application\\msedge.exe";
59+
60+
```
61+
4762
That's all is required to use Karma with Chromium Edge browser.
4863

4964
The browser can also be specified with `npm test` commmand like below:
@@ -54,7 +69,7 @@ The browser can also be specified with `npm test` commmand like below:
5469

5570
## Build from Source
5671

57-
In case you want to build package from github sources
72+
In case if you want to build package from github source
5873

5974
```bash
6075
# Clone/download the package

package-lock.json

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@chiragrupani/karma-chromium-edge-launcher",
3-
"version": "1.2.3",
3+
"version": "1.2.4",
44
"description": "A Karma plugin. Launcher for different Chromium Edge channels - Dev, Canary, Beta and Stable",
55
"main": "dist/index.js",
66
"types": "dist/index.d.ts",
@@ -25,7 +25,9 @@
2525
"Chromium Edge Beta",
2626
"Chromium Edge Stable",
2727
"microsoft",
28-
"edge"
28+
"edge",
29+
"Chromium Edge Launcher",
30+
"Karma"
2931
],
3032
"author": "Chirag",
3133
"dependencies": {
@@ -38,7 +40,7 @@
3840
"@types/node": "^14.0.5",
3941
"@types/sinon": "^9.0.4",
4042
"chai": "^4.2.0",
41-
"mocha": "^7.1.2",
43+
"mocha": "^7.2.0",
4244
"mocha-junit-reporter": "^1.23.3",
4345
"nyc": "^15.0.1",
4446
"ts-node": "^8.10.1",

src/EdgeDevHeadless.ts

Lines changed: 0 additions & 28 deletions
This file was deleted.

src/channels/EdgeBeta.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import BaseBrowser from '../BaseBrowser';
22
import Utilities from '../Utilities';
33

4-
const EdgeBetaBrowser = function(baseBrowserDecorator, args) {
4+
const EdgeBetaBrowser = function (baseBrowserDecorator, args) {
55
baseBrowserDecorator(this);
66
var flags = args.flags || [];
77
var userDataDir = args.edgeDataDir || this._tempDir;
@@ -19,10 +19,10 @@ EdgeBetaBrowser.prototype = {
1919
darwin: Utilities.GetEdgeDarwin(
2020
'/Applications/Microsoft Edge Beta.app/Contents/MacOS/Microsoft Edge Beta'
2121
),
22-
win32: Utilities.GetEdgeExe('Edge Beta')
22+
win32: Utilities.GetEdgeExe('Edge Beta'),
2323
},
2424

25-
ENV_CMD: 'EDGE_Beta_BIN'
25+
ENV_CMD: 'EDGE_BETA_BIN',
2626
};
2727

2828
export default EdgeBetaBrowser;

src/headlessChannels/EdgeBetaHeadless.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ EdgeBetaHeadlessBrowser.prototype = {
2222
win32: Utilities.GetEdgeExe('Edge Beta')
2323
},
2424

25-
ENV_CMD: 'EDGE_Beta_BIN'
25+
ENV_CMD: 'EDGE_BETA_BIN'
2626
};
2727

2828
export default EdgeBetaHeadlessBrowser;

0 commit comments

Comments
 (0)