Bug, StringView !=重载逻辑错误

Author: mingkuang-Chuyu

include/YY/Base/Containers/Span.h

@@ -578,6 +578,20 @@ namespace YY
                     return true;
                 }
 
+                bool __YYAPI operator!=(_In_ const Span& _Other) const
+                {
+                    if (GetLength() != _Other.GetLength())
+                        return true;
+
+                    for (size_t i = 0; i < GetLength(); ++i)
+                    {
+                        if (pData[i] == _Other.pData[i])
+                            return true;
+                    }
+
+                    return false;
+                }
+
                 _Type* __YYAPI begin() noexcept
                 {
                     return pData;

include/YY/Base/Strings/String.h

@@ -657,16 +657,16 @@ namespace YY
 
                 bool __YYAPI operator!=(const StringBase& _szSrc) const
                 {
-                    if (this->GetSize() == _szSrc.GetSize())
-                        return false;
+                    if (this->GetSize() != _szSrc.GetSize())
+                        return true;
 
                     return memcmp(this->GetConstString(), _szSrc.GetConstString(), this->GetSize() * sizeof(char_t)) != 0;
                 }
 
                 bool __YYAPI operator!=(const StringView& _szSrc) const
                 {
-                    if (this->GetSize() == _szSrc.GetSize())
-                        return false;
+                    if (this->GetSize() != _szSrc.GetSize())
+                        return true;
 
                     return memcmp(this->GetConstString(), _szSrc.GetConstString(), this->GetSize() * sizeof(char_t)) != 0;
                 }

include/YY/Base/Strings/StringView.h

@@ -139,8 +139,8 @@ namespace YY
 
                 bool __YYAPI operator!=(StringView _sOther) const
                 {
-                    if (cchString == _sOther.cchString)
-                        return false;
+                    if (cchString != _sOther.cchString)
+                        return true;
 
                     return memcmp(sString, _sOther.sString, cchString * sizeof(sString[0])) != 0;
                 }
@@ -860,8 +860,8 @@ namespace YY
 
                 bool __YYAPI operator!=(StringView _sOther) const
                 {
-                    if (cchString == _sOther.cchString)
-                        return false;
+                    if (cchString != _sOther.cchString)
+                        return true;
 
                     return memcmp(sString, _sOther.sString, cchString * sizeof(sString[0])) != 0;
                 }