From 20ba4b599aef4d6b0bc2e122c398cf4638d32f72 Mon Sep 17 00:00:00 2001 From: Nick Desaulniers Date: Fri, 16 Dec 2022 12:45:49 -0800 Subject: [PATCH] disable pylint W1509 subprocess-popen-preexec-fn I'm not sure how to work around boot-qemu.py:768:17: W1509: Using preexec_fn keyword which may be unsafe in the presence of threads (subprocess-popen-preexec-fn) For python 3.10.8. I might be able to use process_group=1 in the subprocess.Popen constructor, but seems it's only available in python 3.11+. Link: https://github.com/ClangBuiltLinux/boot-utils/pull/87 --- .github/workflows/python_lint.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/python_lint.yml b/.github/workflows/python_lint.yml index 36ff839..6da35a1 100644 --- a/.github/workflows/python_lint.yml +++ b/.github/workflows/python_lint.yml @@ -51,8 +51,9 @@ jobs: # R0913: too-many-arguments # R0914: too-many-locals # R0915: too-many-statements + # W1509: subprocess-popen-preexec-fn - name: pylint - run: pylint --disable C0114,C0115,C0116,C0301,C0302,R0902,R0903,R0911,R0912,R0913,R0914,R0915 --jobs $(nproc) $(git ls-files '*.py') + run: pylint --disable C0114,C0115,C0116,C0301,C0302,R0902,R0903,R0911,R0912,R0913,R0914,R0915,W1509 --jobs $(nproc) $(git ls-files '*.py') - name: yapf run: yapf --diff --recursive $GITHUB_WORKSPACE