Merge issue: GitHash in Info.plist

[austincondiff]

I've noticed that people want to gitignore Info.plist because it changes the GitHash every commit which causes merge conflicts every time. This is very annoying but we can't ignore this file as it contains things pertinent to the project. This is something we need to figure out so we can avoid these issues going forward. Any thoughts or ideas?

[theMuslimDev]

This is a good read explaining https://liquidsoftware.com/blog/the-7-deadly-sins-of-versioning-part-2/

[theMuslimDev]

For this repository I don't see any benefits of using git hash in the future. We are going to be using version numbers anyways, right? So if any user has any issues or find bugs in a particular version of CodeEdit when it's released. They can mention this version number in the bug report.

If anyone knows any definitive benefits of using this, please let me know. I'm all ears. However, in my opinion we can omit using this. If not now then definitely in the near future.

Looks like GitHash was introduced in March 2022 in PR #358. There's also a build phase which creates the GitHash inside the info.plist called Update commit hash that will need to be removed if we go down this route. I believe we can only go down this route if we have a release number such as 0.0.1. If this is looking like long way off. Then unfortunately, I think we will need to keep using GitHash as its the only best way to deduce where the issue lies in a bug report.

[Kyle-Ye]

Update the PR to use xcconfig files.

This is how many large projects managed their Xcode configures. (#include other xcconfig files in a common xcconfig file.)

[austincondiff]

It look like the GitHash is used in the welcome window if you click on the version number it copies the following:

CodeEdit: 1.0 (1)
Commit: 7a96cf534b4118d9c5f69164c85f06e501b322d2
MacOS: 12.5.1 (21G83)
Xcode: 14.0.1 (14A400)

We are also using it in the About window.

The question is, is this necessary?

[Kyle-Ye]

Yes. But on the welcome screen we would need to include the version number. Which doesn't exist at the moment. Need to think over that point.

Maybe we can use the "versionString" or "buildString"

[theMuslimDev]

That sounds like a viable option. I'll let @austincondiff gives the go ahead on that one.

[Kyle-Ye]

Yes. But on the welcome screen we would need to include the version number. Which doesn't exist at the moment. Need to think over that point.

Looks like we already include it on the first line.

Format: "CodeEdit: ${version} (${build})"

[austincondiff]

Let's use versionString

[Kyle-Ye]

Let's use versionString

Both versionString and buildString are already included in the first line. And I've closed the original PR and open a new one #799.

[theMuslimDev]

For anyone reading this in the future. Solutions raised in this discussion was applied in PR #799 by @Kyle-Ye, which has been merged