Set Image and Registry Seperately in Otel Collector#1070
Merged
aaronpowell merged 1 commit intoJan 28, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the OpenTelemetry Collector integration to separate the registry and image properties when configuring the container, enabling registry rewriting in BeforeStart hooks for organizations with locked-down firewalls that need to redirect to internal mirrors.
Key Changes
- Changed from passing the full image path (including registry) via
WithImageto separating the registry and image usingWithImageandWithImageRegistryrespectively - Now uses
settings.Imageandsettings.Registryseparately instead of the computedsettings.CollectorImageproperty
Rather than fudge the registry into the image name, set the registry property explicitly.
b859886 to
becf466
Compare
Contributor
Author
|
SurrealDb test failures seem unrelated to this change. |
Member
re-ran and tests pass. |
Contributor
Author
|
@aaronpowell Can you reopen this. @martinjt Do you mind reviewing? |
martinjt
approved these changes
Jan 20, 2026
aaronpowell
approved these changes
Jan 28, 2026
This was referenced May 14, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than fudge the registry into the image name, set the registry property explicitly.
For some context of why this matters to me - my org's build agents have locked down firewalls, and we have to rewrite public registries to internal mirrors - we do this by looking at the Registry property in a
BeforeStarthook - see more at https://youtu.be/u0iK6Bv5BZ0?si=AtJ_DmYCn1t0Mq5f&t=1124 .PR Checklist
Other information